Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(webpack): add --sentry status to webpack's --dry-run output #30021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Jan 30, 2025

webpack --dry-run logs the applied settings and then exits. The status of the sentry flag was missing. Now it isn't.

Before

~/code/metamask-extension (webpack-dry-run-sentry) $ yarn webpack --dry-run
🦊 Build Config 🦊

Environment: development
Minify: false
Watch: false
Cache: true
Progress: true
Zip: false
Snow: false
LavaMoat: false
Lockdown: false
Manifest version: 2
Release version: 0
Browsers: chrome
Devtool: source-map
Build type: main
Features: build-main, keyring-snaps
Test: false

After:

~/code/metamask-extension (webpack-dry-run-sentry) $ yarn webpack --dry-run
🦊 Build Config 🦊

Environment: development
Minify: false
Watch: false
Cache: true
Progress: true
Zip: false
Snow: false
LavaMoat: false
Lockdown: false
Sentry: false
Manifest version: 2
Release version: 0
Browsers: chrome
Devtool: source-map
Build type: main
Features: build-main, keyring-snaps
Test: false

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4fe3479]
Page Load Metrics (1834 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25520771682477229
domContentLoaded15562052179314972
load15612086183417584
domInteractive267137136
backgroundConnect9196384220
firstReactRender1695462814
getState5183314019
initialActions01000
loadScripts11441538131712861
setupStore980222211
uiStartup182627312182283136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch marked this pull request as ready for review January 30, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants