Skip to content

Conversation

@MoMannn
Copy link
Contributor

@MoMannn MoMannn commented Dec 1, 2025

Description

This bumps gator-controller-package to version 0.7.0. Which includes logic to call refresh of gator permissions after state is changed.

Changelog

CHANGELOG entry: Refresh gator permissions after revoke state is changed.

Manual testing steps

  1. Create an advance permission
  2. Revoke an advance permission
  3. Go to permissions details page before the transaction is confirmed.
  4. The permission should refresh (disappear) after it has been confirmed on chain.

Screenshots/Recordings

Before

Screen.Recording.2025-12-01.at.13.34.21.mov

After

Screen.Recording.2025-12-01.at.13.29.32.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Upgrade @metamask/gator-permissions-controller to ^0.7.0 and update lockfile/dependency graph accordingly.

  • Dependencies:
    • Bump @metamask/gator-permissions-controller to ^0.7.0 in package.json.
    • Update yarn.lock resolution and adjust related deps (@metamask/snaps-controllers, @metamask/transaction-controller).

Written by Cursor Bugbot for commit 483a918. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-delegation MetaMask Delegation Team label Dec 1, 2025
@MoMannn MoMannn marked this pull request as ready for review December 1, 2025 12:40
@socket-security
Copy link

socket-security bot commented Dec 1, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​gator-permissions-controller@​0.5.0 ⏵ 0.7.09910086 +195 +1100

View full report

@socket-security
Copy link

socket-security bot commented Dec 1, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@MoMannn
Copy link
Contributor Author

MoMannn commented Dec 1, 2025

@SocketSecurity ignore npm/@metamask/[email protected]
It is our internal package which we trust.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 1, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [483a918]
UI Startup Metrics (1259 ± 124 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12591000161812413431475
load1055864134710811321251
domContentLoaded1049859134010711271243
domInteractive2515101182275
firstPaint51491125340110111200
backgroundConnect21620024010223237
firstReactRender3420255253857
getState3617107174081
initialActions105113
loadScripts83965411181049101013
setupStore1173551223
numNetworkReqs1257820572
BrowserifyPower User HomeuiStartup21571847276622723272630
load1058949155712410591427
domContentLoaded1042937153712410421412
domInteractive36181822634101
firstPaint626108156842310181362
backgroundConnect288215844144251727
firstReactRender63411311667100
getState20713777882220268
initialActions104113
loadScripts82371613021258221198
setupStore21115592446
numNetworkReqs1186833459129263
WebpackStandard HomeuiStartup8427031276978861044
load657568102990691851
domContentLoaded652564101789688846
domInteractive2714145232289
firstPaint249861044194205746
backgroundConnect1054171028
firstReactRender27197473238
getState271367113545
initialActions105112
loadScripts649562100687685837
setupStore1154051218
numNetworkReqs1257620570
WebpackPower User HomeuiStartup17071286260229419892255
load6955941302114696950
domContentLoaded6855891289114685937
domInteractive38192453534121
firstPaint2821031298219257749
backgroundConnect63758714719570
firstReactRender6345128136688
getState201127791108194242
initialActions105112
loadScripts6825861278112683926
setupStore201056112350
numNetworkReqs1736943585218407
FirefoxBrowserifyStandard HomeuiStartup13051084172815213971598
load1088939147210911581294
domContentLoaded1087939147211011581293
domInteractive62311863386123
firstPaint------
backgroundConnect49211873855158
firstReactRender21173742232
getState126147161028
initialActions103112
loadScripts105892314509811241232
setupStore135224231041
numNetworkReqs1256916663
BrowserifyPower User HomeuiStartup27302119582754128273908
load1241994262122512931634
domContentLoaded1241994262122512921633
domInteractive12634562111121466
firstPaint------
backgroundConnect140291646197137358
firstReactRender63421291767105
getState29974880211415763
initialActions207126
loadScripts1201977250121212331608
setupStore1656849188190585
numNetworkReqs102622506181242
WebpackStandard HomeuiStartup14591247204914915411715
load12071036146110612911422
domContentLoaded12071036146110612911422
domInteractive53271583275128
firstPaint------
backgroundConnect52212233560126
firstReactRender26206262735
getState147158211224
initialActions102012
loadScripts1180101914189812471391
setupStore12597111134
numNetworkReqs1156715754
WebpackPower User HomeuiStartup30932131591682632784967
load15611166304551116032831
domContentLoaded15601165304451116022831
domInteractive122281007140105424
firstPaint------
backgroundConnect1903113222831491157
firstReactRender66402492767113
getState300621319245434810
initialActions2126323
loadScripts14571148288737515232590
setupStore1505790203177700
numNetworkReqs101542546180242
📊 Page Load Benchmark Results

Current Commit: 483a918 | Date: 12/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±60ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 722ms (±58ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 60ms 997ms 1.31s 1.24s 1.31s
domContentLoaded 722ms 58ms 690ms 988ms 923ms 988ms
firstPaint 77ms 12ms 60ms 184ms 88ms 184ms
firstContentfulPaint 77ms 12ms 60ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 1.17 KiB (0.01%)

Copy link
Contributor

@jeffsmale90 jeffsmale90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MoMannn MoMannn added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit dfe6e68 Dec 2, 2025
191 of 197 checks passed
@MoMannn MoMannn deleted the fix/refresh-permissions-map-after-permission-is-processed branch December 2, 2025 10:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
@metamaskbot metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-13.13.0 Issue or pull request that will be included in release 13.13.0 size-XS team-delegation MetaMask Delegation Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants