release(runway): cherry-pick fix: layout inconsistencies cp-13.12.0 #38455
+10
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…38410) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fix layout inconsistencies in sidepanel and fullscreen modes Also aligns "Fund your wallet" [](https://codespaces.new/MetaMask/metamask-extension/pull/38410?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix: confirmation layout in sidepanel ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-740 ## **Manual testing steps** In sidepanel and fullscreen - Confirmations - Accounts list - Import SRP - Import PK ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** | Confirmations | Accounts | |---|---| |<img width="619" height="368" alt="image" src="https://github.com/user-attachments/assets/840d484c-99ff-4ee0-bf20-21fa10d947a6" />|<img width="834" height="292" alt="image" src="https://github.com/user-attachments/assets/b0e3cba9-f849-4134-8235-0c7c9a433a7b" />| ### **After** | Confirmations | Accounts | |---|---| |<img width="578" height="277" alt="image" src="https://github.com/user-attachments/assets/bda115c2-5d5b-4102-b19b-ded9871c0423" />|<img width="839" height="222" alt="image" src="https://github.com/user-attachments/assets/4185ac6e-4426-4132-8a0a-3a11a6e76652" />| ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Switches confirmations and Import SRP to RootLayout and removes fixed widths/padding across multichain pages to align sidepanel/fullscreen layouts. > > - **Routing/Layout**: > - Move `CONFIRM_TRANSACTION_ROUTE` and `CONFIRMATION_V_NEXT_ROUTE` to `RootLayout`. > - Move `IMPORT_SRP_ROUTE` to `RootLayout`. > - Remove `MultichainMetaFoxLogo` rendering on confirm routes and related `isConfirmTransactionRoute` import. > - **Multichain Account Pages**: > - Drop fixed `max-w-[600px]` on `Page` wrappers in `add-wallet-page`, `multichain-account-address-list-page`, `multichain-account-private-key-list-page`, and `smart-account-page`. > - Remove `account-list` stylesheet and its import. > - **Styles**: > - Remove extra padding rule for `.multichain-page` when not using app header. > - Import SRP: remove fixed `max-width`/`height`; keep responsive layout. > - Wallet overview: widen and center `BalanceEmptyState` (`max-w[460px]`, `self-center`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 1a5118e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (5 files, +4 -11)
|
gauthierpetetin
approved these changes
Dec 1, 2025
Collaborator
Builds ready [6fb88fe]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Collaborator
Builds ready [7a069b0]
UI Startup Metrics (1248 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
metamaskbot
added
the
release-13.12.0
Collaborator
|
No release label on PR. Adding release label release-13.12.0 on PR, as PR was cherry-picked in branch 13.12.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/38410?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix layout inconsistencies in sidepanel and fullscreen modes
Also aligns "Fund your wallet"
Changelog
CHANGELOG entry: fix: confirmation layout in sidepanel
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-740
Manual testing steps
In sidepanel and fullscreen
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Unifies layouts across views by switching key routes to RootLayout, removing legacy width constraints, deleting unused styles, and tweaking empty-state styling.
IMPORT_SRP_ROUTE,CONFIRM_TRANSACTION_ROUTE, andCONFIRMATION_V_NEXT_ROUTEtoRootLayoutinui/pages/routes/routes.component.tsx.MultichainMetaFoxLogoandisConfirmTransactionRouteusage from routes.max-w-[600px]on multichain pages (add-wallet-page,multichain-account-address-list-page,multichain-account-private-key-list-page,smart-account-page) to allow full-width within layout.multi-srp/import-srp/index.scss: remove fixedmax-width/height; rely on responsive behavior; keep floating import button responsive.multichain-accounts/account-list/account-list.scssand its import frompages.scss.BalanceEmptyStatewidened and centered (max-w-[460px] self-center) incoin-overview.tsx.Written by Cursor Bugbot for commit 7a069b0. This will update automatically on new commits. Configure here.
35ba498