Skip to content

Conversation

@gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Dec 1, 2025

Description

The diff we observe in this stable sync PR comes from this PR, which were merged to main AFTER the 13.12.0 release cut, but were cherry-picked into 13.11.2:

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates @metamask/bitcoin-wallet-snap to v1.8.0 and adds 13.11.2 entry/link corrections to CHANGELOG and attributions.

  • Dependencies:
    • Bump @metamask/bitcoin-wallet-snap from ^1.7.0 to ^1.8.0 in package.json and yarn.lock.
  • Docs/Meta:
    • Add 13.11.2 section in CHANGELOG.md noting the bitcoin snap upgrade; update comparison links accordingly.
    • Update attribution.txt to reflect @metamask/bitcoin-wallet-snap 1.8.0.

Written by Cursor Bugbot for commit 5b35004. This will update automatically on new commits. Configure here.

metamaskbot and others added 6 commits December 1, 2025 14:21
This PR updates the change log for 13.11.2. (Hotfix - no test plan
generated.)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Updates `CHANGELOG.md` for 13.11.2 with a Bitcoin Snap upgrade fix and
refreshed version comparison links.
> 
> - **Changelog (`CHANGELOG.md`)**:
> - Adds `13.11.2` section under *Fixed*: upgrade Bitcoin Snap (#38437).
> - Updates version comparison references: `[Unreleased]` baseline to
`v13.11.2...HEAD` and adds `[13.11.2]` link.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
bee7ccf. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: metamaskbot <[email protected]>
Co-authored-by: Gauthier Petetin <[email protected]>
- fix: cp-13.11.2 bump bitcoin (#38437)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates bitcoin to 1.8.0, which removes onRpcRequest method..

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38437?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Removed `onRpcRequest`
([#568](MetaMask/snap-bitcoin-wallet#568))

## **Related issues**

Fixes: Remove `onRpcRequest`.

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Bumps @metamask/bitcoin-wallet-snap to 1.8.0 and updates lockfile and
attributions.
> 
> - **Dependencies**:
> - Bump `@metamask/bitcoin-wallet-snap` from `^1.6.0` to `^1.8.0` in
`package.json` and `yarn.lock`.
> - **Attributions**:
> - Update `attribution.txt` entry for `@metamask/bitcoin-wallet-snap`
to `1.8.0`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
797426d. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


[3160a77](3160a77)

---------

Co-authored-by: Fred <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Dec 1, 2025
@gauthierpetetin gauthierpetetin changed the title Sync v13.12.0 with stable 2 release: Sync v13.12.0 with stable Dec 1, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​bitcoin-wallet-snap@​1.7.0 ⏵ 1.8.01001008398 +1100

View full report

"@metamask/assets-controllers": "patch:@metamask/assets-controllers@patch%3A@metamask/assets-controllers@npm%253A89.0.1%23~/.yarn/patches/@metamask-assets-controllers-npm-89.0.1-02fa7acd54.patch%3A%3Aversion=89.0.1&hash=6be0d3#~/.yarn/patches/@metamask-assets-controllers-patch-7c7d711c8c.patch",
"@metamask/base-controller": "^9.0.0",
"@metamask/bitcoin-wallet-snap": "^1.7.0",
"@metamask/bitcoin-wallet-snap": "^1.8.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes in this file come from this PR #38437, which was not included in 13.12.0, but was cherry-picked in 13.11.2.

"@metamask/auto-changelog": "npm:^5.1.0"
"@metamask/base-controller": "npm:^9.0.0"
"@metamask/bitcoin-wallet-snap": "npm:^1.7.0"
"@metamask/bitcoin-wallet-snap": "npm:^1.8.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes in this file come from this PR #38437, which was not included in 13.12.0, but was cherry-picked in 13.11.2.

@metamaskbot
Copy link
Collaborator

Builds ready [5b35004]
UI Startup Metrics (1218 ± 122 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1218999185012212831400
load1027861163511210871209
domContentLoaded1021856162711110821202
domInteractive2615188242177
firstPaint55981123541010081193
backgroundConnect21319425513219249
firstReactRender311860103749
getState3316133163954
initialActions107113
loadScripts81364913801098491001
setupStore1172441320
numNetworkReqs1257920573
BrowserifyPower User HomeuiStartup20831815277321921502609
load1031922145312010421358
domContentLoaded1015903140411910271348
domInteractive35181432733122
firstPaint5449214404059731347
backgroundConnect265203761109236544
firstReactRender6241113166999
getState18913570359203241
initialActions107114
loadScripts80269111811167921127
setupStore221192122540
numNetworkReqs1166933858118267
WebpackStandard HomeuiStartup8336981218848621005
load64557398674666799
domContentLoaded64056797973661792
domInteractive2816162242290
firstPaint24086832175215695
backgroundConnect1063751019
firstReactRender282010193342
getState261350103547
initialActions103111
loadScripts63756496972659784
setupStore1062431219
numNetworkReqs1257720575
WebpackPower User HomeuiStartup17101303263625619332152
load6935981116101696954
domContentLoaded6835911097101681948
domInteractive37191563034126
firstPaint2841081125209263719
backgroundConnect124958820196578
firstReactRender634394106985
getState17612976564186213
initialActions104112
loadScripts680589108399678939
setupStore23981132653
numNetworkReqs1116935561102287
FirefoxBrowserifyStandard HomeuiStartup12881056175415513601612
load105891013609410981267
domContentLoaded105891013609410971267
domInteractive5131134236699
firstPaint------
backgroundConnect46211813253111
firstReactRender23185252234
getState136147191032
initialActions102022
loadScripts103389312938710711246
setupStore155194231153
numNetworkReqs1256817662
BrowserifyPower User HomeuiStartup26772023481056027924257
load12001000253519911981508
domContentLoaded12001000253419911981508
domInteractive12838582105115402
firstPaint------
backgroundConnect126311058141117459
firstReactRender63401562167116
getState28559971230306889
initialActions207126
loadScripts1161977210916711671480
setupStore176151055221186742
numNetworkReqs104643456981241
WebpackStandard HomeuiStartup15991358200513716871884
load1308112215669113741462
domContentLoaded1308112215659113741462
domInteractive72291502885127
firstPaint------
backgroundConnect58201993679125
firstReactRender312289113246
getState167147201474
initialActions113122
loadScripts1275110215318413351419
setupStore176205281444
numNetworkReqs1256616763
WebpackPower User HomeuiStartup29542178544476729074904
load14111138299531214611934
domContentLoaded14101138299531214611934
domInteractive1102853396112358
firstPaint------
backgroundConnect170271742277136898
firstReactRender66373173366128
getState326621335264501860
initialActions2130326
loadScripts13281097206117314161716
setupStore15891111213160742
numNetworkReqs1035826052133242
📊 Page Load Benchmark Results

Current Commit: 5b35004 | Date: 12/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±63ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 736ms (±61ms) 🟢 | historical mean value: 732ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 63ms 1.02s 1.34s 1.25s 1.34s
domContentLoaded 736ms 61ms 708ms 1.02s 935ms 1.02s
firstPaint 78ms 11ms 64ms 176ms 84ms 176ms
firstContentfulPaint 78ms 11ms 64ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

@gauthierpetetin gauthierpetetin merged commit b1b2289 into release/13.12.0 Dec 2, 2025
186 of 187 checks passed
@gauthierpetetin gauthierpetetin deleted the sync-v13.12.0-with-stable-2 branch December 2, 2025 07:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
@metamaskbot metamaskbot added the release-13.12.0 Issue or pull request that will be included in release 13.12.0 label Dec 4, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-13.12.0 on PR, as PR was added to branch 13.12.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

extension-delivery release-13.12.0 Issue or pull request that will be included in release 13.12.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants