-
Notifications
You must be signed in to change notification settings - Fork 5.4k
release: Sync v13.12.0 with stable #38457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR updates the change log for 13.11.2. (Hotfix - no test plan generated.) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates `CHANGELOG.md` for 13.11.2 with a Bitcoin Snap upgrade fix and refreshed version comparison links. > > - **Changelog (`CHANGELOG.md`)**: > - Adds `13.11.2` section under *Fixed*: upgrade Bitcoin Snap (#38437). > - Updates version comparison references: `[Unreleased]` baseline to `v13.11.2...HEAD` and adds `[13.11.2]` link. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit bee7ccf. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: metamaskbot <[email protected]> Co-authored-by: Gauthier Petetin <[email protected]>
- fix: cp-13.11.2 bump bitcoin (#38437) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Updates bitcoin to 1.8.0, which removes onRpcRequest method.. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/38437?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Removed `onRpcRequest` ([#568](MetaMask/snap-bitcoin-wallet#568)) ## **Related issues** Fixes: Remove `onRpcRequest`. ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps @metamask/bitcoin-wallet-snap to 1.8.0 and updates lockfile and attributions. > > - **Dependencies**: > - Bump `@metamask/bitcoin-wallet-snap` from `^1.6.0` to `^1.8.0` in `package.json` and `yarn.lock`. > - **Attributions**: > - Update `attribution.txt` entry for `@metamask/bitcoin-wallet-snap` to `1.8.0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 797426d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [3160a77](3160a77) --------- Co-authored-by: Fred <[email protected]> Co-authored-by: MetaMask Bot <[email protected]>
release: 13.11.2
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@metamask/assets-controllers": "patch:@metamask/assets-controllers@patch%3A@metamask/assets-controllers@npm%253A89.0.1%23~/.yarn/patches/@metamask-assets-controllers-npm-89.0.1-02fa7acd54.patch%3A%3Aversion=89.0.1&hash=6be0d3#~/.yarn/patches/@metamask-assets-controllers-patch-7c7d711c8c.patch", | ||
| "@metamask/base-controller": "^9.0.0", | ||
| "@metamask/bitcoin-wallet-snap": "^1.7.0", | ||
| "@metamask/bitcoin-wallet-snap": "^1.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes in this file come from this PR #38437, which was not included in 13.12.0, but was cherry-picked in 13.11.2.
| "@metamask/auto-changelog": "npm:^5.1.0" | ||
| "@metamask/base-controller": "npm:^9.0.0" | ||
| "@metamask/bitcoin-wallet-snap": "npm:^1.7.0" | ||
| "@metamask/bitcoin-wallet-snap": "npm:^1.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes in this file come from this PR #38437, which was not included in 13.12.0, but was cherry-picked in 13.11.2.
Builds ready [5b35004]
UI Startup Metrics (1218 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
|
No release label on PR. Adding release label release-13.12.0 on PR, as PR was added to branch 13.12.0 when release was cut. |
Description
The diff we observe in this stable sync PR comes from this PR, which were merged to main AFTER the 13.12.0 release cut, but were cherry-picked into 13.11.2:
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Updates @metamask/bitcoin-wallet-snap to v1.8.0 and adds 13.11.2 entry/link corrections to CHANGELOG and attributions.
@metamask/bitcoin-wallet-snapfrom^1.7.0to^1.8.0inpackage.jsonandyarn.lock.13.11.2section inCHANGELOG.mdnoting the bitcoin snap upgrade; update comparison links accordingly.attribution.txtto reflect@metamask/bitcoin-wallet-snap1.8.0.Written by Cursor Bugbot for commit 5b35004. This will update automatically on new commits. Configure here.