refactor: convert shared/lib/transactions-controller-utils to TypeScript (level 29) by Copilot · Pull Request #41333 · MetaMask/metamask-extension

Copilot · 2026-03-27T21:43:39Z

[skip-e2e]
Converts shared/lib/transactions-controller-utils.js and its test file to TypeScript, removing both from files-to-convert.json.

Changes

transactions-controller-utils.ts — typed all exports:
- calcGasTotal: string | number params (was JS untyped, callers pass numbers)
- toPrecisionWithoutTrailingZeros: string | number | BigNumber → string
- calcTokenAmount: string | number | BigNumber → BigNumber
- getSwapsTokensReceivedFromTxMeta: all params optional to match existing JS call-site patterns; chainId: string | number; precision: number | null = 6
- Cast txReceipt to { type?: string } to access MetaMask's internal envelope-type field (absent from @metamask/transaction-controller's TransactionReceipt)
- Cast Log[] to a local LogWithTopicsArray[] type since Log.topics is incorrectly typed as string instead of string[] in the upstream package
transactions-controller-utils.test.ts (renamed from transaction-controller-utils.test.js):
- Partial mock objects cast via as unknown as TransactionMeta
- Added /* eslint-disable @typescript-eslint/naming-convention */ for token_to_amount (external API snake_case property)
- Removed spurious second arg from a .toBe() call (silently ignored in JS, TypeScript surfaced it)
transaction-breakdown-utils.ts: removed now-unnecessary @ts-expect-error on precision: null call (previously required because the JS version had no type for this parameter)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Note

Medium Risk
Mostly a type-migration, but it touches getSwapsTokensReceivedFromTxMeta logic (default-token detection, receipt typing, and output formatting), which could subtly affect swaps amount display in the UI.

Overview
Migrates shared/lib/transactions-controller-utils and its tests from JS to TS. Exports are now explicitly typed (including optional params for getSwapsTokensReceivedFromTxMeta) and tests use typed TransactionMeta fixtures.

getSwapsTokensReceivedFromTxMeta adds stricter handling around txReceipt.type, chainId (supports number by converting to hex), optional gasPrice access, and log topic typing, and slightly changes formatting behavior (e.g., removes an ignored extra arg in a .toBe() assertion). The transaction breakdown caller drops an unnecessary @ts-expect-error for passing precision: null.

Also removes the converted files from development/ts-migration-dashboard/files-to-convert.json.

^{Written by Cursor Bugbot for commit 170fb34. This will update automatically on new commits. Configure here.}

Agent-Logs-Url: https://github.com/MetaMask/metamask-extension/sessions/bda8384d-d827-4f0e-a207-e6abddb13981 Co-authored-by: DDDDDanica <12678455+DDDDDanica@users.noreply.github.com>

metamaskbotv2 · 2026-03-27T23:40:46Z

Builds ready [8fcd6f5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 944 902 1004 44 1004 1004
total 944 902 1004 44 1004 1004
Confirm Tx confirm_tx 6061 6051 6069 7 6069 6069
total 6061 6051 6069 7 6069 6069
Bridge User Actions bridge_load_page 308 272 353 30 326 353
bridge_load_asset_picker 203 132 288 57 249 288
bridge_search_token 805 743 860 55 859 860
total 1322 1201 1458 94 1344 1458

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1472 1274 1785 90 1517 1629
load 1204 1011 1448 86 1254 1351
domContentLoaded 1197 1004 1441 86 1248 1344
domInteractive 26 17 67 8 27 43
firstPaint 187 77 1266 168 235 301
backgroundConnect 210 187 253 11 216 230
firstReactRender 20 12 50 5 22 26
initialActions 1 0 7 1 1 4
loadScripts 1002 808 1241 83 1051 1141
setupStore 12 7 45 5 15 23
numNetworkReqs 34 31 55 5 37 45
Chrome Browserify Startup Power User Home uiStartup 5582 1971 16544 3432 5983 15488
load 1311 1144 1640 113 1362 1543
domContentLoaded 1285 1134 1630 101 1340 1501
domInteractive 35 21 140 17 37 60
firstPaint 273 93 1636 239 301 397
backgroundConnect 2524 288 13434 3304 2924 12288
firstReactRender 27 18 50 6 28 38
initialActions 1 0 10 1 1 3
loadScripts 1078 937 1384 93 1137 1278
setupStore 16 5 40 7 19 31
numNetworkReqs 236 96 372 66 281 345

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 221 2 221 221
srpButtonToSrpForm 96 89 103 6 101 103
confirmSrpToPwForm 22 21 23 1 22 23
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 15 15 16 0 16 16
doneButtonToHomeScreen 502 497 508 5 508 508
openAccountMenuToAccountListLoaded 2990 2899 3124 106 3115 3124
total 3864 3762 4087 128 3929 4087
Onboarding New Wallet createWalletToSocialScreen 219 215 222 2 220 222
srpButtonToPwForm 109 108 110 0 109 110
createPwToRecoveryScreen 8 8 9 0 8 9
skipBackupToMetricsScreen 40 39 42 1 42 42
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 446 374 518 71 517 518
total 840 766 909 68 908 909
Asset Details assetClickToPriceChart 73 62 88 9 78 88
total 73 62 88 9 78 88
Solana Asset Details assetClickToPriceChart 59 56 61 2 61 61
total 59 56 61 2 61 61
Import Srp Home loginToHomeScreen 2053 1988 2128 51 2094 2128
openAccountMenuAfterLogin 58 56 60 2 60 60
homeAfterImportWithNewWallet 1188 337 2523 1016 2337 2523
total 3301 2427 4588 1006 4474 4588
Send Transactions openSendPageFromHome 28 19 35 6 33 35
selectTokenToSendFormLoaded 33 25 43 7 38 43
reviewTransactionToConfirmationPage 1091 797 1358 215 1235 1358
total 1151 860 1424 210 1279 1424
Swap openSwapPageFromHome 114 107 121 6 119 121
fetchAndDisplaySwapQuotes 2689 2684 2696 5 2694 2696
total 2805 2794 2815 7 2806 2815

🌐 Dapp Page Load Benchmarks

Current Commit: 8fcd6f5 | Date: 3/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 725ms (±36ms) 🟢 | historical mean value: 727ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 85ms (±10ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	38ms	1.00s	1.31s	1.05s	1.31s
domContentLoaded	725ms	36ms	699ms	984ms	748ms	984ms
firstPaint	85ms	10ms	72ms	172ms	92ms	172ms
firstContentfulPaint	85ms	10ms	72ms	172ms	92ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: -36 Bytes (0%)

…s-to-typescrip

github-actions · 2026-03-30T12:38:49Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-30T13:12:56Z

Builds ready [5e8ac6f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 817 339 1119 312 1112 1119
total 817 339 1119 312 1112 1119
Confirm Tx confirm_tx 6051 6031 6101 29 6041 6101
total 6051 6031 6101 29 6041 6101
Bridge User Actions bridge_load_page 274 269 279 4 279 279
bridge_load_asset_picker 279 272 284 5 284 284
bridge_search_token 853 741 1044 131 980 1044
total 1395 1224 1602 164 1585 1602

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Startup Standard Home uiStartup 1486 1280 1767 96 1554 1635
load 1220 991 1411 92 1289 1355
domContentLoaded 1211 983 1407 91 1272 1345
domInteractive 26 17 87 10 27 46
firstPaint 195 74 1401 179 247 313
backgroundConnect 210 187 263 13 217 226
firstReactRender 21 15 50 6 22 31
initialActions 1 0 6 1 2 4
loadScripts 1018 809 1222 88 1076 1156
setupStore 13 5 47 6 16 22
numNetworkReqs 35 31 66 7 38 50
Startup Power User Home uiStartup 4843 2240 16837 3229 5543 13364
load 1420 1179 1797 125 1484 1629
domContentLoaded 1399 1173 1735 118 1461 1610
domInteractive 40 22 254 28 42 72
firstPaint 273 108 1295 173 335 438
backgroundConnect 2000 290 13192 2751 2356 9875
firstReactRender 27 18 58 7 29 43
initialActions 1 0 7 1 1 3
loadScripts 1170 975 1437 105 1220 1368
setupStore 18 7 107 12 20 34
numNetworkReqs 202 86 449 65 229 338

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 217 220 1 219 220
srpButtonToSrpForm 95 93 96 1 96 96
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 16 0 15 16
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 1087 976 1182 68 1119 1182
openAccountMenuToAccountListLoaded 2599 2484 2758 121 2732 2758
total 4057 3873 4224 128 4170 4224
Onboarding New Wallet createWalletToSocialScreen 220 218 222 2 222 222
srpButtonToPwForm 119 110 128 8 125 128
createPwToRecoveryScreen 9 9 10 0 9 10
skipBackupToMetricsScreen 44 39 53 6 47 53
agreeButtonToOnboardingSuccess 17 16 18 1 17 18
doneButtonToAssetList 1168 1020 1380 133 1248 1380
total 1583 1413 1812 139 1655 1812
Asset Details assetClickToPriceChart 82 66 94 12 93 94
total 82 66 94 12 93 94
Solana Asset Details assetClickToPriceChart 72 60 95 14 80 95
total 72 60 95 14 80 95
Import Srp Home loginToHomeScreen 2104 2044 2141 39 2136 2141
openAccountMenuAfterLogin 45 40 53 5 44 53
homeAfterImportWithNewWallet 8781 8607 8920 110 8871 8920
total 10982 10787 11101 130 11087 11101
Send Transactions openSendPageFromHome 21 15 26 3 22 26
selectTokenToSendFormLoaded 23 23 23 0 23 23
reviewTransactionToConfirmationPage 850 847 852 2 850 852
total 893 887 898 4 896 898
Swap openSwapPageFromHome 59 32 81 21 77 81
fetchAndDisplaySwapQuotes 2701 2686 2721 14 2712 2721
total 2760 2724 2789 22 2777 2789

🌐 Dapp Page Load Benchmarks

Current Commit: 5e8ac6f | Date: 3/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 721ms (±37ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±10ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.00s	1.32s	1.06s	1.32s
domContentLoaded	721ms	37ms	697ms	997ms	743ms	997ms
firstPaint	84ms	10ms	68ms	168ms	96ms	168ms
firstContentfulPaint	84ms	10ms	68ms	168ms	96ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: -36 Bytes (0%)

…s-to-typescrip

metamaskbotv2 · 2026-03-30T16:16:35Z

Builds ready [83a3186]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 658 278 973 298 944 973
total 658 278 973 298 944 973
Confirm Tx confirm_tx 6032 6012 6067 22 6049 6067
total 6032 6012 6067 22 6049 6067
Bridge User Actions bridge_load_page 241 219 252 12 250 252
bridge_load_asset_picker 221 197 255 22 225 255
bridge_search_token 859 701 1017 116 930 1017
total 1279 1117 1397 118 1387 1397

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Startup Standard Home uiStartup 1512 1325 1830 83 1566 1620
load 1239 1050 1444 73 1285 1348
domContentLoaded 1231 1038 1432 73 1273 1337
domInteractive 27 17 60 9 28 49
firstPaint 189 78 1313 138 261 307
backgroundConnect 216 188 271 14 222 239
firstReactRender 23 14 66 8 24 42
initialActions 1 0 4 1 2 3
loadScripts 1031 850 1228 71 1073 1127
setupStore 13 6 39 6 17 25
numNetworkReqs 35 31 62 6 38 45
Startup Power User Home uiStartup 4785 1991 15951 3018 5341 12756
load 1307 1135 1632 107 1370 1522
domContentLoaded 1285 1120 1552 92 1338 1467
domInteractive 37 20 180 25 36 87
firstPaint 285 98 1583 237 312 450
backgroundConnect 2026 272 12608 2804 2604 9823
firstReactRender 25 16 71 8 27 40
initialActions 1 0 6 1 1 2
loadScripts 1075 923 1330 84 1130 1231
setupStore 16 7 35 6 18 30
numNetworkReqs 209 81 382 75 256 341

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 219 223 1 222 223
srpButtonToSrpForm 97 97 97 0 97 97
confirmSrpToPwForm 24 23 25 1 24 25
pwFormToMetricsScreen 16 16 16 0 16 16
metricsToWalletReadyScreen 17 17 17 0 17 17
doneButtonToHomeScreen 1094 1044 1139 44 1136 1139
openAccountMenuToAccountListLoaded 2797 2490 3131 214 2910 3131
total 4207 3999 4341 120 4275 4341
Onboarding New Wallet createWalletToSocialScreen 224 218 231 4 226 231
srpButtonToPwForm 113 107 122 6 119 122
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 39 39 40 0 39 40
agreeButtonToOnboardingSuccess 17 15 18 1 18 18
doneButtonToAssetList 1170 986 1288 108 1260 1288
total 1573 1379 1695 117 1680 1695
Asset Details assetClickToPriceChart 87 61 119 24 111 119
total 87 61 119 24 111 119
Solana Asset Details assetClickToPriceChart 76 74 78 2 78 78
total 76 74 78 2 78 78
Import Srp Home loginToHomeScreen 2182 2133 2247 43 2192 2247
openAccountMenuAfterLogin 50 33 63 11 61 63
homeAfterImportWithNewWallet 9111 8994 9186 71 9137 9186
total 11348 11176 11439 105 11423 11439
Send Transactions openSendPageFromHome 23 20 27 3 25 27
selectTokenToSendFormLoaded 25 20 33 4 26 33
reviewTransactionToConfirmationPage 865 846 898 21 880 898
total 918 888 947 22 934 947
Swap openSwapPageFromHome 70 67 75 3 72 75
fetchAndDisplaySwapQuotes 2694 2688 2699 5 2698 2699
total 2764 2755 2774 7 2765 2774

🌐 Dapp Page Load Benchmarks

Current Commit: 83a3186 | Date: 3/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 732ms (±36ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 85ms (±10ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	38ms	1.01s	1.32s	1.07s	1.32s
domContentLoaded	732ms	36ms	702ms	997ms	758ms	997ms
firstPaint	85ms	10ms	68ms	152ms	100ms	152ms
firstContentfulPaint	85ms	10ms	68ms	152ms	100ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 30 Bytes (0%)

…actions-controller-utils-to-typescrip

metamaskbotv2 · 2026-03-31T13:26:35Z

Builds ready [2c01f08]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)

Baseline (latest main): 84188b5 | Date: 4/28/58216 | Pipeline: 23798282244 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount 🟢 [Show logs]
confirmTx 🟢 [Show logs]
bridgeUserActions 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ bridgeUserActions/bridge_load_asset_picker: +14%

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ startupStandardHome/initialActions: +25%
↓ startupStandardHome/setupStore: -13%
↓ startupPowerUserHome/backgroundConnect: -17%
↓ startupPowerUserHome/numNetworkReqs: -16%
↓ startupPowerUserHome/numNetworkReqs: -32%
↓ startupStandardHome/initialActions: -17%
↑ startupPowerUserHome/domInteractive: +12%
↓ startupStandardHome/initialActions: -29%
↓ startupStandardHome/setupStore: -55%
↓ startupPowerUserHome/domInteractive: -14%
↓ startupPowerUserHome/firstReactRender: -14%
↓ startupPowerUserHome/setupStore: -22%

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟢 [Show logs]
solanaAssetDetails 🟢 [Show logs]
importSrpHome 🟢 [Show logs]
sendTransactions 🟢 [Show logs]
swap 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ onboardingImportWallet/metricsToWalletReadyScreen: +41%
↓ onboardingImportWallet/doneButtonToHomeScreen: -76%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +41%
↓ onboardingImportWallet/total: -42%
↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +34%
↓ onboardingNewWallet/doneButtonToAssetList: -31%
↓ onboardingNewWallet/total: -23%
↓ assetDetails/assetClickToPriceChart: -44%
↓ assetDetails/total: -44%
↓ solanaAssetDetails/assetClickToPriceChart: -53%
↓ solanaAssetDetails/total: -53%
↑ importSrpHome/loginToHomeScreen: +16%
↓ importSrpHome/openAccountMenuAfterLogin: -19%
↓ importSrpHome/homeAfterImportWithNewWallet: -15%
↓ importSrpHome/total: -13%
↑ sendTransactions/openSendPageFromHome: +67%
↑ sendTransactions/reviewTransactionToConfirmationPage: +28%
↑ sendTransactions/total: +28%
↓ swap/openSwapPageFromHome: -88%
↑ swap/fetchAndDisplaySwapQuotes: +24%

🌐 Dapp Page Load Benchmarks

Current Commit: 2c01f08 | Date: 3/31/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.02s ⬆️ (historical data)
domContentLoaded-> current mean value: 730ms (±38ms) 🟢 | historical mean value: 720ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 86ms (±13ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	40ms	1.01s	1.31s	1.06s	1.31s
domContentLoaded	730ms	38ms	704ms	987ms	743ms	987ms
firstPaint	86ms	13ms	64ms	192ms	96ms	192ms
firstContentfulPaint	86ms	13ms	64ms	192ms	96ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 30 Bytes (0%)

sonarqubecloud · 2026-03-31T15:30:39Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-31T15:52:19Z

Builds ready [170fb34]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 2 warn · 🔴 0 fail)

Baseline (latest main): dbaaa4f | Date: 8/13/58216 | Pipeline: 23804995151 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount
🟡 load_new_account
[Show logs]
confirmTx 🟢 [Show logs]
bridgeUserActions 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ loadNewAccount/load_new_account: +13%
↑ loadNewAccount/total: +13%
↑ bridgeUserActions/bridge_load_page: +11%
↑ bridgeUserActions/bridge_load_asset_picker: +24%

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome
🟡 uiStartup
[Show logs]
🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ startupStandardHome/firstReactRender: +12%
↑ startupStandardHome/initialActions: +43%
↓ startupPowerUserHome/backgroundConnect: -12%
↑ startupStandardHome/firstReactRender: +23%
↑ startupPowerUserHome/uiStartup: +15%
↓ startupPowerUserHome/domInteractive: -15%
↑ startupPowerUserHome/backgroundConnect: +13%
↓ startupPowerUserHome/numNetworkReqs: -54%
↑ startupStandardHome/firstReactRender: +25%
↓ startupStandardHome/initialActions: -17%
↑ startupStandardHome/backgroundConnect: +14%
↑ startupStandardHome/firstReactRender: +25%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/setupStore: -26%
↑ startupPowerUserHome/domInteractive: +14%
↓ startupPowerUserHome/setupStore: -20%

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟢 [Show logs]
solanaAssetDetails 🟢 [Show logs]
importSrpHome 🟢 [Show logs]
sendTransactions 🟢 [Show logs]
swap 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/pwFormToMetricsScreen: -10%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -16%
↓ onboardingImportWallet/doneButtonToHomeScreen: -76%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +29%
↓ onboardingImportWallet/total: -39%
↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +18%
↓ onboardingNewWallet/doneButtonToAssetList: -44%
↓ onboardingNewWallet/total: -37%
↓ assetDetails/assetClickToPriceChart: -55%
↓ assetDetails/total: -55%
↓ solanaAssetDetails/assetClickToPriceChart: -55%
↓ solanaAssetDetails/total: -55%
↑ importSrpHome/loginToHomeScreen: +20%
↓ importSrpHome/openAccountMenuAfterLogin: -19%
↓ importSrpHome/homeAfterImportWithNewWallet: -31%
↓ importSrpHome/total: -26%
↓ swap/openSwapPageFromHome: -88%
↑ swap/fetchAndDisplaySwapQuotes: +25%

🌐 Dapp Page Load Benchmarks

Current Commit: 170fb34 | Date: 3/31/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±41ms) 🟡 | historical mean value: 1.02s ⬇️ (historical data)
domContentLoaded-> current mean value: 717ms (±38ms) 🟢 | historical mean value: 721ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±10ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	41ms	1.00s	1.31s	1.03s	1.31s
domContentLoaded	717ms	38ms	698ms	993ms	727ms	993ms
firstPaint	84ms	10ms	68ms	164ms	92ms	164ms
firstContentfulPaint	84ms	10ms	68ms	164ms	92ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -21.4 KiB (-0.25%)
common: -1.27 KiB (-0.01%)

MajorLift · 2026-08-01T00:02:57Z

🧪 Validation Run

Verdict: ⚠️ the hand-written type genuinely disagrees with its upstream source — Claim: converting this file to TypeScript preserves its behaviour, with a local type restating Log.topics because upstream types it as string. head 7e59505f5fb · 2026-08-02 · authored-vs-authoritative check

Note

Trial run of the MetaMask evidence skills —
feedback welcome, on the finding or on whether this format is useful to a reviewer.
Not a review verdict; nothing here blocks the PR.

The conversion adds LogWithTopicsArray, whose comment records the divergence in prose: upstream Log.topics is string, and this file needs string[]. Whether the two shapes actually differ is a question only the compiler settles, so the local declaration was replaced with the upstream one and tsc re-run in CI.

Substitution alone:

Authored type vs authoritative source · `substitution silent`

Arm	Change	distinct `tsc` errors
A — baseline	none	0
B — substituted	`shared/lib/transactions-controller-utils.ts`:146	0
new under substitution		0

Silent — this is not proof of agreement. Existing call sites may satisfy both
shapes; indexing and .match() compile against string and string[] alike.
Re-run with --probe to inject a sink only the authoritative type accepts.

_{Produced by tsc-substitution.sh; source restored after the run. head 7e59505f5fbbb7e75daf0db18f56194b436b6d07 · 0 tracked changes · Version 5.6.3. Run: https://github.com/MajorLift/metamask-skills/actions/runs/30766103170 — logs and artifacts attached there.}

The same substitution with a sink typed to accept only the array shape:

Authored type vs authoritative source · `divergence surfaced`

Arm	Change	distinct `tsc` errors
A — baseline	none	0
B — substituted	`shared/lib/transactions-controller-utils.ts`:146 + typed sink	1
new under substitution		1

Errors present in B and absent in A — what the local type was concealing:

shared/lib/transactions-controller-utils.ts(150,11): error TS2322

_{Produced by tsc-substitution.sh; source restored after the run. head 7e59505f5fbbb7e75daf0db18f56194b436b6d07 · 0 tracked changes · Version 5.6.3. Run: https://github.com/MajorLift/metamask-skills/actions/runs/30766466349 — logs and artifacts attached there.}

Follows from the arms above

Replacing string[] with string produces zero new errors on its own. The obvious check reports a false clean.
Adding const _probe: string[] | undefined = …topics surfaces one TS2322 at line 150 — not assignable. The types do diverge; nothing in the existing call sites distinguishes them.
The reason is visible in the call sites: topics[0] and topics[2].match(…) compile against string and string[] alike — indexing a string yields a character, and .match exists on both.

Open for review: this shows the local type and the upstream one are not interchangeable, not which is correct. If upstream's string is the error — as the comment asserts and the Ethereum spec suggests — the durable fix is upstream in @metamask/transaction-controller, and the local type is a correct workaround that should carry a link to that issue rather than a prose note. If upstream is right for some log shapes, indexing a string here would silently yield characters.

Initial plan

f27da81

Copilot AI assigned Copilot and DDDDDanica Mar 27, 2026

Copilot started work on behalf of DDDDDanica March 27, 2026 21:43 View session

DDDDDanica added team-extension-platform Extension Platform team skip-e2e-quality-gate skip-release-validation skip-release-validation[chrome] skip-release-validation[firefox] skip-release-validation[design] labels Mar 27, 2026

feat: convert shared/lib/transactions-controller-utils to TypeScript

8fcd6f5

Agent-Logs-Url: https://github.com/MetaMask/metamask-extension/sessions/bda8384d-d827-4f0e-a207-e6abddb13981 Co-authored-by: DDDDDanica <12678455+DDDDDanica@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Convert shared/lib/transactions-controller-utils.js to TypeScript~~ feat: convert shared/lib/transactions-controller-utils to TypeScript (level 29) Mar 27, 2026

Copilot AI requested a review from DDDDDanica March 27, 2026 22:08

Copilot finished work on behalf of DDDDDanica March 27, 2026 22:08

DDDDDanica changed the title ~~feat: convert shared/lib/transactions-controller-utils to TypeScript (level 29)~~ refactor: convert shared/lib/transactions-controller-utils to TypeScript (level 29) Mar 27, 2026

Copilot AI temporarily deployed to pr-comment March 27, 2026 23:05 Inactive

github-actions Bot added the size-M label Mar 27, 2026

Copilot AI temporarily deployed to pr-comment March 27, 2026 23:35 Inactive

Merge branch 'main' into copilot/convert-transactions-controller-util…

5e8ac6f

…s-to-typescrip

DDDDDanica temporarily deployed to pr-comment March 30, 2026 12:38 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to pr-comment March 30, 2026 13:08 — with GitHub Actions Inactive

Merge branch 'main' into copilot/convert-transactions-controller-util…

ae9610d

…s-to-typescrip

DDDDDanica temporarily deployed to pr-comment March 30, 2026 13:39 — with GitHub Actions Inactive

DDDDDanica marked this pull request as ready for review March 30, 2026 14:05

DDDDDanica temporarily deployed to pr-comment March 30, 2026 14:05 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to pr-comment March 30, 2026 14:10 — with GitHub Actions Inactive

cursor Bot reviewed Mar 30, 2026

View reviewed changes

Comment thread shared/lib/transactions-controller-utils.ts

DDDDDanica disabled auto-merge March 30, 2026 16:15

DDDDDanica enabled auto-merge March 30, 2026 16:26

DDDDDanica approved these changes Mar 30, 2026

View reviewed changes

itsyoboieltr previously approved these changes Mar 30, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into copilot/convert-trans…

e964950

…actions-controller-utils-to-typescrip

DDDDDanica dismissed itsyoboieltr’s stale review via e964950 March 31, 2026 12:42

DDDDDanica temporarily deployed to pr-comment March 31, 2026 12:42 — with GitHub Actions Inactive

refactor: fix lint failure

2c01f08

DDDDDanica temporarily deployed to pr-comment March 31, 2026 12:52 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to pr-comment March 31, 2026 13:22 — with GitHub Actions Inactive

refactor: fix lint failure

170fb34

DDDDDanica temporarily deployed to pr-comment March 31, 2026 15:17 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to pr-comment March 31, 2026 15:47 — with GitHub Actions Inactive

gauthierpetetin approved these changes Apr 1, 2026

View reviewed changes

HowardBraham approved these changes Apr 2, 2026

View reviewed changes

DDDDDanica added this pull request to the merge queue Apr 2, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 2, 2026

HowardBraham added this pull request to the merge queue Apr 2, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 2, 2026

DDDDDanica added this pull request to the merge queue Apr 2, 2026

Merged via the queue into main with commit 7e59505 Apr 2, 2026
207 checks passed

DDDDDanica deleted the copilot/convert-transactions-controller-utils-to-typescrip branch April 2, 2026 13:14

github-actions Bot locked and limited conversation to collaborators Apr 2, 2026

metamaskbot added the release-13.26.0 Issue or pull request that will be included in release 13.26.0 label Apr 2, 2026

Uh oh!

Conversation

Copilot AI commented Mar 27, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

metamaskbotv2 Bot commented Mar 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

metamaskbotv2 Bot commented Mar 30, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbotv2 Bot commented Mar 30, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 Bot commented Mar 31, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud Bot commented Mar 31, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 Bot commented Mar 31, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MajorLift commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Validation Run

Authored type vs authoritative source · substitution silent

Authored type vs authoritative source · divergence surfaced

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Copilot AI commented Mar 27, 2026 •

edited by cursor Bot

Loading

MajorLift commented Aug 1, 2026 •

edited

Loading

Authored type vs authoritative source · `substitution silent`

Authored type vs authoritative source · `divergence surfaced`