fix(confirmations): submit money account deposits without false insufficient funds - #45555
Draft
jpuri wants to merge 1 commit into
Draft
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (27 files, +1958 -156)
|
jpuri
force-pushed
the
feat/confirmations-money-account-amount-ui
branch
from
August 17, 2026 04:28
d144d9f to
385fd56
Compare
jpuri
force-pushed
the
fix/confirmations-money-account-deposit-submit
branch
from
August 17, 2026 04:29
4707159 to
f7594c7
Compare
jpuri
force-pushed
the
feat/confirmations-money-account-amount-ui
branch
from
August 17, 2026 09:58
385fd56 to
af818b9
Compare
…ficient funds Align deposit encode and Max with mobile, compare the live funding-account balance, and convert deposit USD with the mUSD rate so non-Max amounts can submit. Also match mobile pay-token selection (no defaulting to under-min tokens, empty Pay with row when none exist, no quotes for a 0 transfer amount) and leave the Relay order-id placeholder unsigned on subsidized execute: subsidized quotes inject the real request id after signing, and exact-execution caveats made Delegation Manager reject the redeem with InvalidERC1271Signature. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jpuri
force-pushed
the
fix/confirmations-money-account-deposit-submit
branch
from
August 17, 2026 10:05
f7594c7 to
4d93f51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Money Account deposits could not submit: Max was the only amount that cleared the footer, other amounts showed insufficient funds, a $0 pay token left the amount on a skeleton, and switching tokens crashed on a high-precision BigNumber rate.
This aligns deposit encode and Max with mobile (ROUND_DOWN, non-atomic Max), compares the live funding-account balance instead of the money-account snapshot, converts deposit USD with the mUSD rate (not Monad/vault), and shows
0.0when the selected token has no balance.Stacked on #45543.
Changelog
CHANGELOG entry: Fixed Money Account deposits failing to submit or showing insufficient funds for amounts other than Max
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1743
Manual testing steps
yarn start) with the Money Account feature flag enabled and a wallet that has a Money Account plus a small funding balance (for example ETH or a stablecoin).0.0instead of a skeleton.Pre-merge author checklist
Pre-merge reviewer checklist