fix(analytics): exclude redirect deep links from tracking - #45559
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Contributor
Builds ready [767cadf]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 11 warn · 🔴 3 fail)
Bundle size diffs
|
davidmurdoch
commented
Aug 20, 2026
| }) | ||
| .on('navigate', async ({ url, parsed }) => { | ||
| // don't track deep links that are immediately redirected (like /buy) | ||
| if (!('redirectTo' in parsed)) { |
Contributor
Author
There was a problem hiding this comment.
'redirectTo' in parsed is always false, since parsed will never have a redirectTo property. The redirectTo property sometimes lives on parsed.destination.
HowardBraham
approved these changes
Aug 20, 2026
HowardBraham
added
the
skip-benchmark-gate
Contributor
Builds ready [767cadf]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 11 warn · 🔴 3 fail)
Bundle size diffs
|
DDDDDanica
approved these changes
Aug 20, 2026
metamaskbot
added
the
release-13.47.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Deep links whose destinations redirect outside the extension, such as
/buy, are intentionally excluded from theDeep Link Usedanalytics event.Problem
The background listener checked for
redirectToon the parsed deep-link wrapper. The property actually belongs toparsed.destination, so the guard always allowed valid parsed links through and external redirect destinations were tracked despite the accompanying comment.Solution
This PR extracts the tracking decision into a typed
shouldTrackDeepLinkNavigationpredicate that checks the destination itself, then uses that predicate in the background listener. Regression coverage verifies that external redirect destinations are excluded while extension route destinations remain trackable.Changelog
CHANGELOG entry: null
Manual testing steps
https://link.metamask.io/buy, proceeding through the deep-link interstitial if it appears.Deep Link Usedevent is captured for/buy.https://link.metamask.io/perps, proceeding through the interstitial if it appears.Deep Link Usedevent is captured for/perps.Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Narrow analytics guard fix with unit tests; no auth, vault, or navigation behavior changes beyond which deep links emit metrics.
Overview
Fixes a bug where Deep Link Used analytics fired for routes that only redirect outside the extension (e.g.
/buy), because the background listener looked forredirectToon the parsed link object instead of onparsed.destination.Introduces
shouldTrackDeepLinkNavigation, which skips tracking when the destination hasredirectToand still tracks in-extension routes. The deep-link navigate handler uses this helper instead of the broken inline check. Unit tests cover external redirect vs extension route destinations.Reviewed by Cursor Bugbot for commit 767cadf. Bugbot is set up for automated code reviews on this repo. Configure here.