refactor: replace deprecated Popover with Modal in SetApproveForAllWarning - #45562
Open
chiliec wants to merge 1 commit into
Open
refactor: replace deprecated Popover with Modal in SetApproveForAllWarning#45562chiliec wants to merge 1 commit into
chiliec wants to merge 1 commit into
Conversation
…rning Part of MetaMask#19555. Migrates the SetApproveForAllWarning confirmation component from the deprecated ui/components/ui/popover Popover to the component-library Modal (Modal/ModalOverlay/ModalContent/ModalHeader/ ModalBody/ModalFooter), matching the pattern used elsewhere (e.g. bridge-alert-modal). Adds isOpen/onClose props (onClose defaults to onCancel) to drive the Modal. Existing BEM classNames are preserved so styling is unchanged; no functional change to the approve/reject actions.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Author
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
SetApproveForAllWarning(the NFT set-approval-for-all security warning) from the deprecatedui/components/ui/popoverPopoverto the component-libraryModal(Modal/ModalOverlay/ModalContent/ModalHeader/ModalBody/ModalFooter), matching the pattern already used bybridge-alert-modalisOpen/onCloseprops to drive theModal(onClosedefaults toonCancel)Modal's own built-in behavior (adds a close button in the header, top-aligns the dialog instead of vertically centering it — same as otherModalcall sites in the app)Part of #19555.
CHANGELOG entry: Replace deprecated Popover with Modal from the component-library in the SetApproveForAllWarning confirmation dialog.
Test plan
yarn lint:changedpassesSetApproveForAllWarningstory) that the dialog renders correctly with no functional change to the approve/reject actionsmain) and after (Modal, this branch) screenshots — only difference is theModal's standard chrome (close button, top alignment), consistent withbridge-alert-modalNote
Cursor Bugbot is generating a summary for commit 3b14fc4. Configure here.