Skip to content

refactor: replace deprecated Popover with Modal in SetApproveForAllWarning - #45562

Open
chiliec wants to merge 1 commit into
MetaMask:mainfrom
chiliec:fix/popover-to-modal-set-approval-for-all-warning
Open

refactor: replace deprecated Popover with Modal in SetApproveForAllWarning#45562
chiliec wants to merge 1 commit into
MetaMask:mainfrom
chiliec:fix/popover-to-modal-set-approval-for-all-warning

Conversation

@chiliec

@chiliec chiliec commented Aug 15, 2026

Copy link
Copy Markdown

Summary

  • Migrates SetApproveForAllWarning (the NFT set-approval-for-all security warning) from the deprecated ui/components/ui/popover Popover to the component-library Modal (Modal/ModalOverlay/ModalContent/ModalHeader/ModalBody/ModalFooter), matching the pattern already used by bridge-alert-modal
  • Adds isOpen/onClose props to drive the Modal (onClose defaults to onCancel)
  • Existing BEM classNames are preserved, so styling is unchanged aside from the Modal's own built-in behavior (adds a close button in the header, top-aligns the dialog instead of vertically centering it — same as other Modal call sites in the app)

Part of #19555.

CHANGELOG entry: Replace deprecated Popover with Modal from the component-library in the SetApproveForAllWarning confirmation dialog.

Test plan

  • yarn lint:changed passes
  • Verified via Storybook (SetApproveForAllWarning story) that the dialog renders correctly with no functional change to the approve/reject actions
  • Compared before (Popover, main) and after (Modal, this branch) screenshots — only difference is the Modal's standard chrome (close button, top alignment), consistent with bridge-alert-modal

Note

Cursor Bugbot is generating a summary for commit 3b14fc4. Configure here.

…rning

Part of MetaMask#19555. Migrates the SetApproveForAllWarning confirmation component
from the deprecated ui/components/ui/popover Popover to the
component-library Modal (Modal/ModalOverlay/ModalContent/ModalHeader/
ModalBody/ModalFooter), matching the pattern used elsewhere (e.g.
bridge-alert-modal). Adds isOpen/onClose props (onClose defaults to onCancel)
to drive the Modal. Existing BEM classNames are preserved so styling is
unchanged; no functional change to the approve/reject actions.
@chiliec
chiliec requested a review from a team as a code owner August 15, 2026 15:18
@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chiliec

chiliec commented Aug 15, 2026

Copy link
Copy Markdown
Author
after-modal before-popover

@chiliec

chiliec commented Aug 15, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@metamask-ci metamask-ci Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant