fix(confirmations): submit money account withdrawals on Monad - #45563
Draft
jpuri wants to merge 1 commit into
Draft
fix(confirmations): submit money account withdrawals on Monad#45563jpuri wants to merge 1 commit into
jpuri wants to merge 1 commit into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (42 files, +2268 -186)
|
jpuri
force-pushed
the
fix/confirmations-money-account-deposit-submit
branch
from
August 17, 2026 10:05
f7594c7 to
4d93f51
Compare
Make money-account withdrawals (including the default same-token mUSD on Monad path) actually move funds, mirroring mobile: - Treat the Money Keyring as EIP-7702-relay capable. Sponsored withdrawals are externally signed and must publish via the sentinel relay; skipping the relay hook raw-sent an unsigned payload that Monad rejected with "Transaction decoding error". - Relay the parent execute() as a single exactExecution delegation like mobile's publish hook, instead of expanding nestedTransactions into a batch redeem that mined without moving funds. - Throw (like mobile) when a sponsored or gas-included transaction lands on a chain without EIP-7702 support instead of silently falling through to the unsigned raw send. - Approve only funded withdraw batches: re-encode the typed amount at confirm, rebuild the parent batch calldata from the funded nested calls, and log why a submit was refused instead of silently no-oping. - Hide result rows for zero withdraw amounts even when a no-op quote is stored. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jpuri
force-pushed
the
fix/confirmations-money-account-withdraw-submit
branch
from
August 17, 2026 10:13
eb55e66 to
9a9a1c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make money-account withdrawals (including the default same-token mUSD on Monad path) actually move funds, mirroring the mobile implementation:
execute()as a singleexactExecutiondelegation like mobile's publish hook, instead of expandingnestedTransactionsinto a batch redeem that mined without moving funds.Changelog
CHANGELOG entry: Fixed money account withdrawals not submitting on Monad
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1816
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
🤖 Generated with Claude Code