feat(confirmations): block money account withdrawals above withdrawable balance as user types - #45564
Draft
jpuri wants to merge 1 commit into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +52 -2)
|
jpuri
force-pushed
the
fix/confirmations-money-account-withdraw-submit
branch
from
August 17, 2026 10:13
eb55e66 to
9a9a1c7
Compare
…le balance as user types The insufficient-money-account-balance alert compared the withdrawable vmUSD against the amount parsed from committed calldata, which lags the input by the debounced encode. Prefer the synchronously recorded last withdraw amount so the blocking alert reacts on every keystroke — Send disables and shows "Insufficient funds" immediately, and clears immediately when the amount is reduced. Mirrors mobile, which evaluates the pending typed amount. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jpuri
force-pushed
the
feat/confirmations-money-account-withdraw-balance-alert
branch
from
August 17, 2026 10:15
602c006 to
3ae3ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The insufficient-money-account-balance alert compared the withdrawable vmUSD against the amount parsed from committed calldata, which lags the input by the debounced encode. Prefer the synchronously recorded last withdraw amount so the blocking alert reacts on every keystroke — Send disables and shows "Insufficient funds" immediately, and clears immediately when the amount is reduced. Mirrors mobile, which evaluates the pending typed amount.
Changelog
CHANGELOG entry: Fixed money account withdrawal insufficient funds alert lagging behind the typed amount
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1814
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
🤖 Generated with Claude Code