fix(confirmations): hide irrelevant alerts on money account transactions - #45572
Draft
jpuri wants to merge 1 commit into
Draft
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (4 files, +86 -4)
|
jpuri
force-pushed
the
feat/confirmations-money-account-withdraw-balance-alert
branch
from
August 17, 2026 10:15
602c006 to
3ae3ee1
Compare
Money account deposits/withdrawals showed two alerts that do not apply to them: - "Different account selected": these flows are wallet-initiated and always sent from the dedicated money account, which is never the selected account group, so the warning always fired as noise. - "Unnecessary permission": pay flows batch their own approvals internally; mirrors mobile's MM_PAY_TRANSACTION_TYPES skip in useBatchedUnusedApprovalsAlert. Fixes CONF-1822 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jpuri
force-pushed
the
feat/money-account-suppress-irrelevant-alerts
branch
from
August 17, 2026 10:16
bad6d95 to
57aa70f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Money account deposits and withdrawals were showing two confirmation alerts that are not relevant to them:
useSelectedAccountAlerts): money account flows are wallet-initiated and always sent from the dedicated money account, which is never the selected account group — so this warning fired on every money account transaction as noise.useMultipleApprovalsAlerts): MetaMask Pay flows (money account deposits/withdrawals, perps, mUSD) batch their own approvals internally. This mirrors mobile'sMM_PAY_TRANSACTION_TYPESskip inuseBatchedUnusedApprovalsAlert.Changes
useSelectedAccountAlerts: skip the alert when the confirmation is a money account transaction (viagetMoneyAccountTransactionType).useMultipleApprovalsAlerts: skip the alert when the confirmation contains aPAY_TRANSACTION_TYPEStransaction, matching mobile parity.Related issues
Fixes: CONF-1822
Manual testing steps
🤖 Generated with Claude Code