feat(activity): show money account deposits and withdrawals as MM Pay rows - #45577
Draft
jpuri wants to merge 1 commit into
Draft
Conversation
… rows Money-account deposits and withdrawals were invisible or generic in the activity list. Surface them like the other MM Pay transactions (perps), mirroring mobile's money activity rows: - Include money-account batches in the local activity list. They execute from the Money Keyring account, so the selected-address filter dropped them entirely. - Add extension-local `moneyAccountDeposit` / `moneyAccountWithdraw` activity kinds. `mapLocalTransaction` only reads the top-level type, so these EIP-7702 batches arrived as `contractInteraction` (deposits) or a raw mUSD `send` (withdrawals); `enrichLocalActivity` now re-types them from the nested batch types. - Resolve the mUSD amount from the committed `requiredAssets` entry or the nested approve/transfer calldata, with MM Pay's quoted target fiat as the placeholder fallback, and expose it as fiat (mUSD is pegged 1:1 to USD). - Render rows perps-style: status-derived title, "Money account" subtitle, signed fiat amount (green for deposits), mUSD avatar. - Add a money-account details template modeled on the perps details: fiat hero, status/date, MM Pay fee breakdown, transaction summary, and an "Add funds" CTA for confirmed deposits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (4 files, +199 -2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Money-account deposits and withdrawals were invisible or generic in the activity list. This PR surfaces them like the other MM Pay transactions (perps), mirroring mobile's money activity rows.
selectLocalTransactionsdropped them entirely — this is why nothing changed in the list before.moneyAccountDeposit/moneyAccountWithdrawactivity kinds (extension-local extension of the@metamask/client-utilsunion).mapLocalTransactiononly reads the top-level type, so these EIP-7702 batches arrived ascontractInteraction(deposits) or a raw mUSDsend(withdrawals);enrichLocalActivitynow re-types them from the nested batch types viahasTransactionType.requiredAssetsentry or the nested approve/transfer calldata, with MM Pay's quotedtargetFiatas the placeholder fallback. Exposed as fiat since mUSD is pegged 1:1 to USD.Related issues
Fixes: CONF-1826
Manual testing steps
+$5.00), with the mUSD icon.-$X.XX, details show the same layout with a block explorer button.Pre-merge author checklist
Pre-merge reviewer checklist
🤖 Generated with Claude Code