Skip to content

feat: integrate variational to defi referral program - #45582

Merged
ameliejyc merged 12 commits into
mainfrom
integrate-variational-defi-referral-program
Aug 19, 2026
Merged

feat: integrate variational to defi referral program#45582
ameliejyc merged 12 commits into
mainfrom
integrate-variational-defi-referral-program

Conversation

@ameliejyc

@ameliejyc ameliejyc commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds a referral prompt to Variational (variational.io) following the same logic as the other DeFi referral prompts. New strings and an image for Variational are added. One difference between Variational and the other partners is that they are in private beta and their referral prompt works as an access code right now. If the user is not on Arbitrum, a prompt on their side to switch to Arbitrum interrupts their access flow. Therefore we only show the prompt when the user is already on Arbitrum, to ensure that when accepted the referral code gets applied.

Changelog

CHANGELOG entry: Adds referral prompt to Variational

Related issues

Fixes:

Manual testing steps

  1. Go to variational.io
  2. Connect MM with an account that hasn't signed up before
  3. View the referral prompt
  4. Check the info link works
  5. Test acceptance - see the url gets updated with our referral code (which immediately gets removed) and the referral code gets populated in their UI
  6. Check the code works and sign up can be completed
  7. Test again with a different account and decline the prompt
  8. Check that no code gets populated in their UI

Screenshots/Recordings

Before

After

variational.metamask.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Changes extend an established referral-consent pattern with optional chain gating; no auth, signing, or payment logic is modified beyond deferring when the wrong chain is selected.

Overview
Adds Variational (omni.variational.io) to the existing DeFi referral consent flow, including a new variational_referral_consent approval type, default referrals.variational preference state, and partner-specific copy (variationalReferralSubtitle).

Introduces optional requiredChainId on partner config (Variational uses Arbitrum 0xa4b1). Before showing the referral prompt, the background service now resolves the dapp’s selected network via SelectedNetworkController:getNetworkClientIdForDomain and returns without persisting referral state if the active chain doesn’t match—so the prompt can appear again after the user switches chains.

Wiring updates mirror other partners: shared constants, confirmation templates/stories, and e2e fixture expectations for the new referral slot.

Reviewed by Cursor Bugbot for commit 041243e. Bugbot is set up for automated code reviews on this repo. Configure here.

@ameliejyc
ameliejyc deployed to pr-comment August 17, 2026 13:23 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Aug 17, 2026
@metamask-ci

metamask-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (3 files, +27 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 confirmation/
          • 📁 stories/
            • 📄 defi-referral-consent.stories.tsx +23 -0
          • 📁 templates/
            • 📄 approval-templates.ts +2 -0
            • 📄 approval-types.ts +2 -0

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 core/
        • 📁 defi-referral-consent/
          • 📄 defi-referral-consent-control.tsx +1 -0

🫰 @MetaMask/core-platform (2 files, +106 -0)
  • 📁 app/
    • 📁 scripts/
      • 📁 services/
        • 📄 legacy-background-api-service.test.ts +85 -0
        • 📄 legacy-background-api-service.ts +21 -0

👨‍🔧 @MetaMask/extension-platform (1 files, +2 -1)
  • 📁 test/
    • 📁 e2e/
      • 📁 fixtures/
        • 📄 onboarding-fixture.json +2 -1

🕵️ @MetaMask/extension-privacy-reviewers (1 files, +2 -1)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs.json +2 -1

🧪 @MetaMask/qa (2 files, +4 -2)
  • 📁 test/
    • 📁 e2e/
      • 📁 fixtures/
        • 📄 onboarding-fixture.json +2 -1
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs.json +2 -1

@ameliejyc
ameliejyc force-pushed the integrate-variational-defi-referral-program branch from 7236606 to 041243e Compare August 17, 2026 13:34
@ameliejyc
ameliejyc deployed to pr-comment August 17, 2026 13:34 — with GitHub Actions Active

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 041243e. Configure here.

Comment thread app/scripts/services/legacy-background-api-service.ts
@ameliejyc
ameliejyc deployed to pr-comment August 17, 2026 14:08 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor
Builds ready [041243e]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 13 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 32035823576 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +188%
  • loadNewAccount/total: +188%
  • loadNewAccount/inp: -17%
  • loadNewAccount/fcp: -17%
  • loadNewAccount/lcp: -23%
  • confirmTx/longTaskCount: -33%
  • confirmTx/longTaskTotalDuration: -44%
  • confirmTx/longTaskMaxDuration: +13%
  • confirmTx/tbt: -48%
  • confirmTx/inp: -24%
  • confirmTx/lcp: -13%
  • bridgeUserActions/bridge_load_asset_picker: +34%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/fcp: -17%
  • loadNewAccount/load_new_account: +189%
  • loadNewAccount/total: +189%
  • loadNewAccount/fcp: -67%
  • loadNewAccount/lcp: +943%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/fcp: -61%
  • confirmTx/lcp: +972%
  • bridgeUserActions/bridge_load_page: +153%
  • bridgeUserActions/bridge_load_asset_picker: +80%
  • bridgeUserActions/bridge_search_token: -12%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +13%
  • bridgeUserActions/inp: +115%
  • bridgeUserActions/fcp: -67%
  • bridgeUserActions/lcp: +1103%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/INP: p75 224ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -16%
  • startupStandardHome/load: -14%
  • startupStandardHome/domContentLoaded: -14%
  • startupStandardHome/domInteractive: -16%
  • startupStandardHome/backgroundConnect: -11%
  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/loadScripts: -14%
  • startupStandardHome/setupStore: -17%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/longTaskCount: -33%
  • startupStandardHome/longTaskTotalDuration: -25%
  • startupStandardHome/longTaskMaxDuration: -18%
  • startupStandardHome/tbt: -23%
  • startupStandardHome/fcp: -14%
  • startupStandardHome/lcp: +285%
  • startupStandardHome/domInteractive: -27%
  • startupStandardHome/firstReactRender: -98%
  • startupStandardHome/numNetworkReqs: -20%
  • startupStandardHome/fcp: -22%
  • startupPowerUserHome/uiStartup: -11%
  • startupPowerUserHome/domInteractive: -26%
  • startupPowerUserHome/backgroundConnect: -23%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: +11%
  • startupPowerUserHome/setupStore: -75%
  • startupPowerUserHome/numNetworkReqs: -45%
  • startupPowerUserHome/fcp: -38%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 2.9s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +17%
  • onboardingImportWallet/metricsToWalletReadyScreen: -11%
  • onboardingImportWallet/doneButtonToHomeScreen: -92%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -48%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -95%
  • onboardingImportWallet/longTaskMaxDuration: -91%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -81%
  • onboardingNewWallet/skipBackupToMetricsScreen: -14%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -14%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -77%
  • onboardingNewWallet/longTaskMaxDuration: -47%
  • onboardingNewWallet/tbt: -94%
  • solanaAssetDetails/assetClickToPriceChart: +316%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +316%
  • solanaAssetDetails/inp: +11%
  • solanaAssetDetails/fcp: +17%
  • importSrpHome/homeAfterImportWithNewWallet: -11%
  • importSrpHome/longTaskTotalDuration: -24%
  • importSrpHome/longTaskMaxDuration: -10%
  • importSrpHome/tbt: -31%
  • importSrpHome/inp: -46%
  • importSrpHome/fcp: +19%
  • importSrpHome/lcp: +11%
  • importSrpHome/cls: +484%
  • sendTransactions/openSendPageFromHome: +32%
  • sendTransactions/selectTokenToSendFormLoaded: +69%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -37%
  • sendTransactions/fcp: +18%
  • sendTransactions/lcp: -61%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +824%
  • swap/fetchAndDisplaySwapQuotes: +86%
  • swap/longTaskCount: -100%
  • swap/longTaskTotalDuration: -100%
  • swap/longTaskMaxDuration: -100%
  • swap/tbt: -100%
  • swap/total: +101%
  • swap/lcp: -71%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 2.0s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🔴 swap/INP: p75 760ms
  • 🟡 swap/FCP: p75 1.8s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -58%
  • dappPageLoad/firstPaint: -46%
  • dappPageLoad/firstContentfulPaint: -46%
Bundle sizes
  • background: 14.4 MiB
  • ui: 18.57 MiB
  • common: 0 Bytes
  • other: 1000.53 KiB
  • contentScripts: 1.88 MiB
  • zip: 21.76 MiB
No bundle-size baseline commit was available for this build, so diff values are omitted.

@metamask-ci

metamask-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor
Builds ready [fb3e1a3]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 6 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 32159155223 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +190%
  • loadNewAccount/total: +190%
  • confirmTx/longTaskMaxDuration: +43%
  • confirmTx/tbt: -17%
  • bridgeUserActions/bridge_load_asset_picker: +61%
  • bridgeUserActions/longTaskCount: +11%
  • bridgeUserActions/longTaskTotalDuration: +22%
  • bridgeUserActions/longTaskMaxDuration: +18%
  • bridgeUserActions/tbt: +48%
  • bridgeUserActions/inp: +15%
  • loadNewAccount/load_new_account: +191%
  • loadNewAccount/total: +191%
  • loadNewAccount/inp: -24%
  • loadNewAccount/fcp: -47%
  • loadNewAccount/lcp: +1067%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -24%
  • confirmTx/fcp: -51%
  • confirmTx/lcp: +1164%
  • bridgeUserActions/bridge_load_page: +214%
  • bridgeUserActions/bridge_load_asset_picker: +75%
  • bridgeUserActions/bridge_search_token: +39%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +61%
  • bridgeUserActions/inp: -23%
  • bridgeUserActions/fcp: -50%
  • bridgeUserActions/lcp: +1147%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/setupStore: +44%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/uiStartup: -14%
  • startupStandardHome/domInteractive: -34%
  • startupStandardHome/firstReactRender: -98%
  • startupStandardHome/numNetworkReqs: -20%
  • startupStandardHome/fcp: -29%
  • startupPowerUserHome/domInteractive: -50%
  • startupPowerUserHome/backgroundConnect: -23%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: +11%
  • startupPowerUserHome/setupStore: -68%
  • startupPowerUserHome/numNetworkReqs: -45%
  • startupPowerUserHome/fcp: -46%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 2.9s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: -18%
  • onboardingImportWallet/confirmSrpToPwForm: -18%
  • onboardingImportWallet/pwFormToMetricsScreen: -20%
  • onboardingImportWallet/metricsToWalletReadyScreen: -31%
  • onboardingImportWallet/doneButtonToHomeScreen: -92%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -69%
  • onboardingImportWallet/longTaskCount: -100%
  • onboardingImportWallet/longTaskTotalDuration: -100%
  • onboardingImportWallet/longTaskMaxDuration: -100%
  • onboardingImportWallet/tbt: -100%
  • onboardingImportWallet/total: -86%
  • onboardingNewWallet/skipBackupToMetricsScreen: -18%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -17%
  • onboardingNewWallet/doneButtonToAssetList: -80%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -76%
  • onboardingNewWallet/longTaskMaxDuration: -43%
  • onboardingNewWallet/tbt: -89%
  • onboardingNewWallet/total: -76%
  • solanaAssetDetails/assetClickToPriceChart: +235%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +235%
  • solanaAssetDetails/inp: +11%
  • solanaAssetDetails/fcp: +12%
  • solanaAssetDetails/lcp: +18%
  • importSrpHome/loginToHomeScreen: -16%
  • importSrpHome/homeAfterImportWithNewWallet: -14%
  • importSrpHome/longTaskCount: -30%
  • importSrpHome/longTaskTotalDuration: -36%
  • importSrpHome/longTaskMaxDuration: -26%
  • importSrpHome/tbt: -48%
  • importSrpHome/total: -14%
  • importSrpHome/inp: -48%
  • importSrpHome/lcp: -12%
  • importSrpHome/cls: +484%
  • sendTransactions/openSendPageFromHome: +49%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -41%
  • sendTransactions/lcp: -64%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: -16%
  • swap/fetchAndDisplaySwapQuotes: +86%
  • swap/longTaskCount: -100%
  • swap/longTaskTotalDuration: -100%
  • swap/longTaskMaxDuration: -100%
  • swap/tbt: -100%
  • swap/total: +92%
  • swap/lcp: -74%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🔴 swap/INP: p75 720ms
Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -86.2 KiB (-0.59%)
  • ui: -124.85 KiB (-0.66%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 891 Bytes (0.05%)
  • zip: 469.03 KiB (2.14%)

@ameliejyc
ameliejyc marked this pull request as ready for review August 18, 2026 16:52
@ameliejyc
ameliejyc requested review from a team as code owners August 18, 2026 16:52
@ameliejyc
ameliejyc deployed to pr-comment August 18, 2026 17:05 — with GitHub Actions Active
@github-actions github-actions Bot added size-M and removed size-S labels Aug 18, 2026
@ameliejyc
ameliejyc deployed to pr-comment August 18, 2026 17:28 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor
Builds ready [606fd18]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 9 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 32163722853 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +190%
  • loadNewAccount/total: +190%
  • confirmTx/longTaskTotalDuration: -10%
  • confirmTx/longTaskMaxDuration: +43%
  • confirmTx/tbt: -18%
  • bridgeUserActions/bridge_load_asset_picker: +33%
  • bridgeUserActions/longTaskCount: +11%
  • bridgeUserActions/longTaskTotalDuration: -19%
  • bridgeUserActions/longTaskMaxDuration: -29%
  • bridgeUserActions/tbt: -73%
  • bridgeUserActions/inp: +23%
  • loadNewAccount/load_new_account: +194%
  • loadNewAccount/total: +194%
  • loadNewAccount/inp: -24%
  • loadNewAccount/fcp: -45%
  • loadNewAccount/lcp: +1147%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -32%
  • confirmTx/lcp: +1125%
  • bridgeUserActions/bridge_load_page: +187%
  • bridgeUserActions/bridge_load_asset_picker: +75%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +20%
  • bridgeUserActions/inp: +15%
  • bridgeUserActions/fcp: -46%
  • bridgeUserActions/lcp: +1191%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/setupStore: +44%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/domInteractive: -32%
  • startupStandardHome/firstReactRender: -98%
  • startupStandardHome/numNetworkReqs: -20%
  • startupStandardHome/fcp: -30%
  • startupPowerUserHome/domInteractive: -23%
  • startupPowerUserHome/backgroundConnect: -24%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: +11%
  • startupPowerUserHome/setupStore: -70%
  • startupPowerUserHome/numNetworkReqs: -41%
  • startupPowerUserHome/fcp: -17%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 2.9s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +18%
  • onboardingImportWallet/pwFormToMetricsScreen: +10%
  • onboardingImportWallet/metricsToWalletReadyScreen: -13%
  • onboardingImportWallet/doneButtonToHomeScreen: -92%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -50%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -96%
  • onboardingImportWallet/longTaskMaxDuration: -92%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -81%
  • onboardingNewWallet/srpButtonToPwForm: -24%
  • onboardingNewWallet/createPwToRecoveryScreen: -32%
  • onboardingNewWallet/skipBackupToMetricsScreen: -38%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -32%
  • onboardingNewWallet/doneButtonToAssetList: -79%
  • onboardingNewWallet/longTaskCount: -100%
  • onboardingNewWallet/longTaskTotalDuration: -100%
  • onboardingNewWallet/longTaskMaxDuration: -100%
  • onboardingNewWallet/tbt: -100%
  • onboardingNewWallet/total: -77%
  • solanaAssetDetails/assetClickToPriceChart: +268%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +268%
  • solanaAssetDetails/fcp: +16%
  • importSrpHome/loginToHomeScreen: -12%
  • importSrpHome/homeAfterImportWithNewWallet: -13%
  • importSrpHome/longTaskCount: -37%
  • importSrpHome/longTaskTotalDuration: -46%
  • importSrpHome/longTaskMaxDuration: -26%
  • importSrpHome/tbt: -53%
  • importSrpHome/total: -13%
  • importSrpHome/inp: -48%
  • importSrpHome/cls: +475%
  • sendTransactions/selectTokenToSendFormLoaded: +29%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -33%
  • sendTransactions/fcp: +15%
  • sendTransactions/lcp: -60%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +803%
  • swap/fetchAndDisplaySwapQuotes: +88%
  • swap/longTaskCount: +33%
  • swap/longTaskTotalDuration: +47%
  • swap/tbt: -100%
  • swap/total: +87%
  • swap/inp: +13%
  • swap/lcp: -71%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
  • 🟡 swap/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🔴 swap/INP: p75 568ms
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -57%
  • dappPageLoad/firstPaint: -41%
  • dappPageLoad/firstContentfulPaint: -41%
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -79.73 KiB (-0.54%)
  • ui: -121.86 KiB (-0.64%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 1001 Bytes (0.05%)
  • zip: 471.21 KiB (2.15%)

@ameliejyc
ameliejyc deployed to pr-comment August 19, 2026 07:31 — with GitHub Actions Active
@sonarqubecloud

Copy link
Copy Markdown

@ameliejyc
ameliejyc deployed to pr-comment August 19, 2026 07:55 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor
Builds ready [e1faa52]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 32228194948 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +190%
  • loadNewAccount/total: +190%
  • loadNewAccount/inp: +14%
  • confirmTx/longTaskTotalDuration: -12%
  • confirmTx/longTaskMaxDuration: +38%
  • confirmTx/tbt: -20%
  • bridgeUserActions/bridge_load_asset_picker: +45%
  • bridgeUserActions/longTaskCount: -44%
  • bridgeUserActions/longTaskTotalDuration: -55%
  • bridgeUserActions/longTaskMaxDuration: -30%
  • bridgeUserActions/tbt: -75%
  • loadNewAccount/load_new_account: +191%
  • loadNewAccount/total: +191%
  • loadNewAccount/inp: -17%
  • loadNewAccount/fcp: -45%
  • loadNewAccount/lcp: +1311%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -17%
  • confirmTx/fcp: +18%
  • confirmTx/lcp: +1246%
  • bridgeUserActions/bridge_load_page: +222%
  • bridgeUserActions/bridge_load_asset_picker: +87%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +29%
  • bridgeUserActions/fcp: -43%
  • bridgeUserActions/lcp: +1241%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/setupStore: +29%
  • startupStandardHome/numNetworkReqs: -14%
  • startupStandardHome/uiStartup: -13%
  • startupStandardHome/firstReactRender: -99%
  • startupStandardHome/numNetworkReqs: -20%
  • startupPowerUserHome/domInteractive: +15%
  • startupPowerUserHome/backgroundConnect: -23%
  • startupPowerUserHome/firstReactRender: -99%
  • startupPowerUserHome/initialActions: +11%
  • startupPowerUserHome/setupStore: -68%
  • startupPowerUserHome/numNetworkReqs: -46%
  • startupPowerUserHome/inp: +10%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 304ms
  • 🟡 startupPowerUserHome/INP: p75 208ms
  • 🟡 startupPowerUserHome/LCP: p75 3.0s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +15%
  • onboardingImportWallet/pwFormToMetricsScreen: +14%
  • onboardingImportWallet/doneButtonToHomeScreen: -92%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -50%
  • onboardingImportWallet/longTaskCount: -86%
  • onboardingImportWallet/longTaskTotalDuration: -95%
  • onboardingImportWallet/longTaskMaxDuration: -90%
  • onboardingImportWallet/tbt: -98%
  • onboardingImportWallet/total: -81%
  • onboardingNewWallet/skipBackupToMetricsScreen: -20%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -16%
  • onboardingNewWallet/doneButtonToAssetList: -82%
  • onboardingNewWallet/longTaskCount: -69%
  • onboardingNewWallet/longTaskTotalDuration: -76%
  • onboardingNewWallet/longTaskMaxDuration: -44%
  • onboardingNewWallet/tbt: -90%
  • onboardingNewWallet/total: -78%
  • solanaAssetDetails/assetClickToPriceChart: +308%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: +308%
  • solanaAssetDetails/inp: +11%
  • solanaAssetDetails/fcp: +19%
  • importSrpHome/homeAfterImportWithNewWallet: -14%
  • importSrpHome/longTaskCount: -30%
  • importSrpHome/longTaskTotalDuration: -38%
  • importSrpHome/longTaskMaxDuration: -25%
  • importSrpHome/tbt: -49%
  • importSrpHome/total: -12%
  • importSrpHome/inp: -38%
  • importSrpHome/fcp: +10%
  • importSrpHome/cls: +478%
  • sendTransactions/openSendPageFromHome: -23%
  • sendTransactions/selectTokenToSendFormLoaded: +41%
  • sendTransactions/reviewTransactionToConfirmationPage: -98%
  • sendTransactions/longTaskCount: -100%
  • sendTransactions/longTaskTotalDuration: -100%
  • sendTransactions/longTaskMaxDuration: -100%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: -95%
  • sendTransactions/inp: -41%
  • sendTransactions/lcp: -59%
  • sendTransactions/cls: +171%
  • swap/openSwapPageFromHome: +798%
  • swap/fetchAndDisplaySwapQuotes: +87%
  • swap/longTaskCount: -100%
  • swap/longTaskTotalDuration: -100%
  • swap/longTaskMaxDuration: -100%
  • swap/tbt: -100%
  • swap/total: +102%
  • swap/lcp: -71%
  • swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🔴 sendTransactions/INP: p75 768ms
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • dappPageLoad/pageLoadTime: -58%
  • dappPageLoad/firstPaint: -46%
  • dappPageLoad/firstContentfulPaint: -46%
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -79.31 KiB (-0.54%)
  • ui: -94.56 KiB (-0.5%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 1.08 KiB (0.06%)
  • zip: 510.98 KiB (2.33%)

@matthewwalsh0
matthewwalsh0 requested a review from dan437 August 19, 2026 11:00
@ameliejyc
ameliejyc enabled auto-merge August 19, 2026 12:28
@ameliejyc
ameliejyc added this pull request to the merge queue Aug 19, 2026
Merged via the queue into main with commit 9f20dfa Aug 19, 2026
257 of 259 checks passed
@ameliejyc
ameliejyc deleted the integrate-variational-defi-referral-program branch August 19, 2026 13:33
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 19, 2026
@metamaskbot metamaskbot added the release-13.46.0 Issue or pull request that will be included in release 13.46.0 label Aug 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.46.0 Issue or pull request that will be included in release 13.46.0 risk:medium size-M team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants