feat: send ramps client identity for version-gated feature flags - #45823
Merged
Conversation
Wires clientProduct/clientVersion into RampsService so the on-ramp API can evaluate version-gated LaunchDarkly flags per client. Bumps @metamask/ramps-controller from ^15.0.0 to the v20 preview of MetaMask/core#9983, adapting to v16+ canonical provider IDs and the v20 required chainId on addPrecreatedOrder. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (1 files, +0 -6)
👨🔧 @MetaMask/money-movement (3 files, +8 -6)
🧪 @MetaMask/qa (1 files, +0 -6)
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Contributor
Builds ready [cbc9d0d]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 8 warn · 🔴 2 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Builds ready [820baea]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 10 warn · 🔴 4 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
matteyusys
previously approved these changes
Aug 27, 2026
4 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Builds ready [71c6887]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 9 warn · 🔴 3 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
pull Bot
pushed a commit
to dmrazzy/core
that referenced
this pull request
Aug 28, 2026
…mp API requests (MetaMask#9983) ## Explanation The on-ramp API is adding server-side feature flags (LaunchDarkly) that are gated per client product and client version — e.g. "enable feature X for MetaMask Mobile >= 8.10.0". To evaluate those gates, the API needs to know which client is calling. This PR adds optional `clientProduct` and `clientVersion` constructor options to `RampsService` and `TransakService`. When the host supplies them, every on-ramp API fetch carries two query params: - `clientProduct` (e.g. `metamask-mobile`) - `clientVersion` (the app SemVer, not the ramps-controller package version) Identity travels **in the URL, not in headers**, because the on-ramp CDN caches responses keyed by URL. If gating identity lived in headers, two clients in different flag cohorts would share the same cache entry and one cohort's response could be served to the other. Query params make the cache key and the flag decision agree by construction. Both fields are optional. Hosts that don't pass them send no identity params, and the API fails closed (feature off) — so this is fully backwards compatible. Also exported for hosts and tests: the `RampsClientIdentity` type, the `addRampsClientIdentityParams` helper, and the `RAMPS_CLIENT_PRODUCT_PARAM` / `RAMPS_CLIENT_VERSION_PARAM` constants. The `controller` query param is intentionally left as the ramps-controller package version; the new params carry the app identity instead of overloading it. ## References Related to the on-ramp API version-gated feature flag rollout (Unified Buy 2.0 catalog gating / fiat soft-default) — [TRAM-3828](https://consensyssoftware.atlassian.net/browse/TRAM-3828). - API: consensys-vertical-apps/va-mmcx-onramp-api#1141 - Mobile: MetaMask/metamask-mobile#35359 - Extension: MetaMask/metamask-extension#45823 ## Changelog Updated `packages/ramps-controller/CHANGELOG.md` (Unreleased → Added). ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc) for new or updated code as appropriate - [x] I've communicated my changes to consumers by updating changelogs for packages I've changed - [x] No breaking changes introduced Made with [Cursor](https://cursor.com) ## Demo <div> <a href="https://www.loom.com/share/9f913895e9bb4ccd95a3a79138566f4c"> <p>Introducing Launchdarkly flags for Ramps Backend - Watch Video</p> </a> <a href="https://www.loom.com/share/9f913895e9bb4ccd95a3a79138566f4c"> <img style="max-width:300px;" src="https://cdn.loom.com/sessions/thumbnails/9f913895e9bb4ccd95a3a79138566f4c-36a975aecd13f632-full-play.gif#t=0.1"> </a> </div> [TRAM-3828]: https://consensyssoftware.atlassian.net/browse/TRAM-3828?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Cursor <cursoragent@cursor.com>
roz0n
previously approved these changes
Aug 28, 2026
ramps-controller 20.x no longer persists the countries catalog, so Sentry before-init masks and wallet fixtures must not expect that key. Co-authored-by: Cursor <cursoragent@cursor.com>
ramps-controller@20.2.0 pulls remote-feature-flag-controller@^6.1.0, which left ^6.0.0 pinned at 6.0.0 and failed `yarn dedupe --check`. Co-authored-by: Cursor <cursoragent@cursor.com>
matteyusys
approved these changes
Aug 28, 2026
amitabh94
enabled auto-merge
August 28, 2026 19:50
|
Contributor
Builds ready [81a8033]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 8 warn · 🔴 2 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [81a8033]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 8 warn · 🔴 2 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
hjetpoluru
approved these changes
Aug 28, 2026
metamaskbot
added
the
release-13.48.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wires the extension's client identity (
clientProduct: 'metamask-extension',clientVersionfromprocess.env.METAMASK_VERSION) intoRampsService. The ramps-controller sends these asclientProduct/clientVersionquery params so CDN cache keys vary per client, letting the on-ramp API evaluate version-gated LaunchDarkly flags — first consumer:ramps-v2-fiat-soft-default(TRAM-3828).This also bumps
@metamask/ramps-controllerfrom^15.0.0to^20.2.0(MetaMask/core#9983 in Release/1216.0.0), adapting to the intervening breaking changes:normalizeProviderCodeinuseRampsBuildQuoteaddPrecreatedOrderrequires a non-emptychainId; the extension param types now require it (no production caller passes params yet)getProviderScope/getDefaultRedirectUrlunused; the messenger spreadsRAMPS_CONTROLLER_REQUIRED_SERVICE_ACTIONS)Pinned to
@metamask/ramps-controller@^20.2.0(released).Changelog
CHANGELOG entry: null
Related issues
Fixes: TRAM-3828
Manual testing steps
clientProduct=metamask-extension&clientVersion=<x.y.z>query params (no client-identity headers)Screenshots/Recordings
N/A — no UI change.
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Large dependency jump on ramps buy/checkout paths and new required
chainIdfor precreated orders; client identity on all ramps API calls affects backend flag rollout behavior.Overview
Wires extension client identity into
RampsServiceviaclientProduct: 'metamask-extension'andclientVersionfromMETAMASK_VERSION, so on-ramp API requests can carry version-gated LaunchDarkly behavior through query params (not headers).Upgrades
@metamask/ramps-controllerfrom^15.0.0to^20.2.0and adapts to breaking changes: buy-quote checkout uses provider IDs as-is (dropsnormalizeProviderCode), andchainIdis required onaddRampsPrecreatedOrder/ hook types. E2E fixtures and metrics snapshots drop the removedRampsController.countriespersisted state.Reviewed by Cursor Bugbot for commit 81a8033. Bugbot is set up for automated code reviews on this repo. Configure here.
Demo
Introducing Launchdarkly flags for Ramps Backend - Watch Video