fix: label main and secondary balances

[bergarces]

Description

It's been reported that setting the primary currency to "Native" was displaying fiat as the main currency and the native currency as secondary. The opposite would happen when setting the primary currency to "Fiat".

This was due to using the wrong nomenclature as the properties of the component responsible for that behaviour (balance was the primary balance and mainBalance was the secondary balance).

The chosen solution to fix nomenclature is leaving balance as the primary balance changing the name of mainBalance to secondaryBalance.

This component is used in three different places:

• Token list items in the home wallet.
• Balance in the asset overview.
• Staking balance in the asset overview.

The behaviour for the token list and balance have been fixed to work as the setting suggests. The staking balance has been left as it currently is pending confirmation of whether it needs to follow the same behaviour.

Related issues

Fixes: No open GitHub issue for the ticket

Manual testing steps

1. Go to Settings -> General -> Primary Currency -> Set to "Native"
2. Got to Wallet Home page and check assets in the Tokens tab display the native currency as primary and fiat as secondary.
3. Click on any of the assets to open the asset overview and check that the balance is displayed correctly.
4. Repeat steps 1, 2 and 3 changing the primary currency to "Fiat"

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[bergarces]

This component is owned by @MetaMask/metamask-staking and is currently displaying fiat balance as the primary and ETH balance as secondary without taking into account the primaryCurrency setting.

Since this is a bug fix for another component, I didn't want to change the behaviour of this one, but it's probably worth checking what it should be.

Note that before this PR, balance was the primary balance and mainBalance was the secondary balance. This PR just renames mainBalance as secondaryBalance to correctly describe how it behaves.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 62f8e82
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f628c195-9be0-407b-b0f8-cfdd71eeedb7

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2b5f232
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2a2014c-7695-4929-a285-1a3e787f5f16

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.02%. Comparing base (4f917be) to head (887c004).
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13462      +/-   ##
==========================================
+ Coverage   61.84%   62.02%   +0.17%     
==========================================
  Files        1977     1983       +6     
  Lines       43895    44010     +115     
  Branches     5933     5956      +23     
==========================================
+ Hits        27146    27295     +149     
+ Misses      14948    14921      -27     
+ Partials     1801     1794       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 887c004
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56f1c9b4-a16f-416a-81b9-518cee1fae6d

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 88171b8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/723ca0c1-1224-4fcd-a7ae-312fa5e58bc5

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise