chore(runway): cherry-pick fix(perps): fix truncated market names and Pro fees layout - #34489
Merged
Merged
Conversation
… Pro fees layout cp-8.7.0 (#34476) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** Long ETF and equity market names were overlapping the leverage badge and price column in the market list, and the Pro market header title was clipped too aggressively because it used a fixed `maxWidth`. The Pro order summary fees row also cropped the VIP badge and used a different text color than the other summary values. This PR makes the market list title and header identity text shrink around the leverage badge and right-side actions, removes the hardcoded header name width, and adjusts the Pro fees summary row so the VIP badge is fully visible and the fee value matches the other summary values. ## **Changelog** CHANGELOG entry: Fixed truncated market names in Perps market lists and headers, and improved Pro order summary fees layout. ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: Perps market layout truncation Scenario: market list shows long ETF names without overlapping price Given I am on the Perps Markets screen And I open the ETFs category When I view markets with long names such as "iShares MSCI South Korea ETF" Then the leverage badge stays within the row And the price column is not overlapped or clipped Scenario: Pro market header adapts to right-side actions Given I open a long-named market in Pro mode When the header shows wallet, favorite, and Pro toggle actions Then the market name truncates within the available center space And the leverage badge and chevron remain visible Scenario: Pro order summary fees row displays correctly Given I am on a Pro market order form with an active VIP fee discount When I view the order summary fees row Then the VIP badge is fully visible And the fee value uses the same color and weight as margin and liquidation values ``` ## **Screenshots/Recordings** ### **Before** | Scenario | Screenshot | | --- | --- | | Pro order summary fees row | - | | Market list (long ETF names) | <img width="300" alt="Market list ETFs" src="https://github.com/user-attachments/assets/7c735f0a-c676-4816-9c48-c6be0652f439" /> | | Pro market header | <img width="300" alt="Pro market header" src="https://github.com/user-attachments/assets/bca8b008-9b1c-4955-891d-5c564c7e4d5d" /> | ### **After** | Scenario | Screenshot | | --- | --- | | Pro order summary fees row | <img width="300" alt="Pro order summary fees row" src="https://github.com/user-attachments/assets/ff6ac1a3-63aa-4318-be5c-acfa8e32e68d" /> | | Market list (long ETF names) | <img width="1206" height="2622" alt="Simulator Screenshot - iPhone 17 - 2026-08-07 at 16 31 30" src="https://github.com/user-attachments/assets/5ee0af4a-845f-4e65-bba7-ad58cc278dc2" /> | | Pro market header | <img width="1206" height="2622" alt="Simulator Screenshot - iPhone 17 - 2026-08-07 at 16 31 34" src="https://github.com/user-attachments/assets/0766d1ae-73be-445a-b251-070d523b79a2" /> | ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
|
sleepytanya
approved these changes
Aug 7, 2026
sleepytanya
enabled auto-merge (squash)
August 7, 2026 16:53
Contributor
|
No release label on PR. Adding release label release-8.7.0 on PR, as PR was cherry-picked in branch 8.7.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Long ETF and equity market names were overlapping the leverage badge and
price column in the market list, and the Pro market header title was
clipped too aggressively because it used a fixed
maxWidth. The Proorder summary fees row also cropped the VIP badge and used a different
text color than the other summary values.
This PR makes the market list title and header identity text shrink
around the leverage badge and right-side actions, removes the hardcoded
header name width, and adjusts the Pro fees summary row so the VIP badge
is fully visible and the fee value matches the other summary values.
Changelog
CHANGELOG entry: Fixed truncated market names in Perps market lists and
headers, and improved Pro order summary fees layout.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Made with Cursor
Co-authored-by: Cursor cursoragent@cursor.com 82ae592