Skip to content

fix: simplify feature notifications gate to a single CTA - #34576

Draft
jasonculbertson wants to merge 1 commit into
feat/feature-notif-gatefrom
fix/notif-gate-single-cta-sheet
Draft

fix: simplify feature notifications gate to a single CTA#34576
jasonculbertson wants to merge 1 commit into
feat/feature-notif-gatefrom
fix/notif-gate-single-cta-sheet

Conversation

@jasonculbertson

Copy link
Copy Markdown

Description

Simplifies the feature notifications gate sheet (stacked on #33821) so it matches the post-onboarding notifications prompt: preview card, centered title/subhead, and a single primary CTA instead of nested Allow / Push / In-app toggles.

Turn on notifications enables master notifications when needed, then turns on both push and in-app for the gated feature (e.g. price alerts). NotifCard is moved into shared UI so Settings can reuse the preview without violating route isolation (ADR 0020).

Changelog

CHANGELOG entry: Simplified the turn-on-notifications prompt for price alerts to a single action

Related issues

Refs: #33821

Manual testing steps

Feature: Feature notifications gate sheet

  Scenario: user turns on notifications from the gate sheet
    Given notifications are off
    And the user opens price alert creation or management

    When the feature notifications gate sheet appears
    And the user taps "Turn on notifications"
    Then push and in-app notifications are enabled for price alerts
    And the sheet dismisses once the gate is satisfied

  Scenario: user dismisses the gate sheet
    Given the feature notifications gate sheet is visible

    When the user taps the close button
    Then the sheet dismisses without enabling notifications

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

Replace nested Allow/Push/In-app toggles with a post-onboarding-style sheet
and one Turn on notifications action that enables push and in-app for the feature.
Move NotifCard into shared UI so Settings can reuse the preview without
crossing route boundaries.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jasonculbertson jasonculbertson self-assigned this Aug 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps, SmokeMMConnect
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (en-locale-change): locales/languages/en.json changed — UI strings and E2E text/label selectors may diverge (including platform casing like Android textAllCaps). Running all tests.

Performance Test Selection:
The changes are entirely within the notification settings UI (feature gate sheet redesign, file rename, import updates, string changes). None of these changes affect app launch, login, onboarding, asset loading, swap flows, account list rendering, or any other performance-sensitive flows measured by the available performance test tags.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant