fix: simplify feature notifications gate to a single CTA - #34576
fix: simplify feature notifications gate to a single CTA#34576jasonculbertson wants to merge 1 commit into
Conversation
Replace nested Allow/Push/In-app toggles with a post-onboarding-style sheet and one Turn on notifications action that enables push and in-app for the feature. Move NotifCard into shared UI so Settings can reuse the preview without crossing route boundaries. Co-authored-by: Cursor <cursoragent@cursor.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|



Description
Simplifies the feature notifications gate sheet (stacked on #33821) so it matches the post-onboarding notifications prompt: preview card, centered title/subhead, and a single primary CTA instead of nested Allow / Push / In-app toggles.
Turn on notifications enables master notifications when needed, then turns on both push and in-app for the gated feature (e.g. price alerts).
NotifCardis moved into shared UI so Settings can reuse the preview without violating route isolation (ADR 0020).Changelog
CHANGELOG entry: Simplified the turn-on-notifications prompt for price alerts to a single action
Related issues
Refs: #33821
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Made with Cursor