test(e2e): skip flaky token-approve Appium smokes until stabilized

[cryptodev-2s]

Description

The token-approve Appium smoke suite fails consistently on main with Element "confirm-button" not in hierarchy after 3000ms. The approve confirmation does not open reliably in CI, so appium-confirmations-android-smoke has been red on main and is blocking confirmations CI for every PR.

This re-skips the three token-approve smoke suites (mirroring #34387) so they stop blocking CI while the flakiness is investigated. No product code changes. Tracked in #34581.

Suites skipped:

• token-approve/approve.spec.ts
• token-approve/increase-allowance.spec.ts
• token-approve/set-approval-for-all.spec.ts

Changelog

CHANGELOG entry: null

Related issues

Refs: #34581

Manual testing steps

N/A. Test-only change that skips flaky E2E suites. CI confirms appium-confirmations-android-smoke no longer fails on these specs.

Screenshots/Recordings

N/A. No UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Test-only change that disables flaky E2E coverage; no application or release behavior is modified.

Overview
Unblocks confirmations CI by skipping three flaky token-approve Appium smoke suites that fail on main when confirm-button never appears in the view hierarchy.

Each suite (approve, increase-allowance, set-approval-for-all) switches from appiumTest.describe to appiumTest.describe.skip, with an inline note pointing to #34581. Test bodies are unchanged; this mirrors the earlier temporary skip in #34387.

^{Reviewed by Cursor Bugbot for commit d114294. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Pre-merge author checklist has only 5 of the required 8 items. Every checklist row must be present and consciously checked — do not delete rows.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (test-spec-tag-extraction): Spec files changed directly. Running their associated tags: SmokeConfirmations

Performance Test Selection:
No app code, performance-sensitive flows, or performance spec files were changed. These are purely test-skipping changes in smoke spec files with no impact on app performance.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cryptodev-2s]

superseded by #34586