Skip to content

test(e2e): skip consistently failing Appium confirmations Android smokes (MMQA-2254) - #34586

Merged
chrisleewilcox merged 1 commit into
mainfrom
MMQA-2254-skip-confirmations-android-blockers
Aug 11, 2026
Merged

test(e2e): skip consistently failing Appium confirmations Android smokes (MMQA-2254)#34586
chrisleewilcox merged 1 commit into
mainfrom
MMQA-2254-skip-confirmations-android-blockers

Conversation

@chrisleewilcox

@chrisleewilcox chrisleewilcox commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

appium-confirmations-android-smoke (shards 1 and 2) is consistently failing across unrelated PRs and blocking merges (see Slack / MMQA-2254).

This PR only quarantines the hard/consistent main blockers so other teams can merge.

Skipped:

Shard Spec Case
1 7702/batch-transaction.spec.ts wallet_sendCalls batch (keep smart-account upgrade running)
1 contract-deployment.spec.ts entire describe (single test)
1 dapp-initiated-transfer.spec.ts entire describe (single test; can hang ~35m)
2 token-approve/set-approval-for-all.spec.ts ERC1155 setApprovalForAll
2 token-approve/set-approval-for-all.spec.ts revoke mode describe (single test; hard-fail on recent main)

Not skipped: ERC721 setApprovalForAll (often recovers), increase-allowance / approve mixes, already-skipped suites.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-2254

Related: https://consensyssoftware.atlassian.net/browse/MMQA-2232

Manual testing steps

Feature: Confirmations Android smoke unblock quarantine

  Scenario: Skipped cases do not run; remaining cases still execute
    Given appium-confirmations-android-smoke on CI
    When the suite runs
    Then the five quarantined cases are reported skipped
    And smart-account upgrade and ERC721 setApprovalForAll still run

Screenshots/Recordings

N/A — skip-only change; no product UI.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…kes (MMQA-2254)

Quarantine the five main blockers so unrelated PRs can merge while the
Test Dapp readiness / confirm-sheet fix lands. Describe-skip files that
only contained the failing case; leave still-green cases running.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-qa QA team label Aug 11, 2026
@metamask-ci

metamask-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (test-spec-tag-extraction): Spec files changed directly. Running their associated tags: SmokeConfirmations

Performance Test Selection:
No app code was changed — only test spec files had tests skipped. There is no performance-sensitive code path affected, so no performance tests are needed.

View GitHub Actions results

@github-actions github-actions Bot added the risk:low AI analysis: low risk label Aug 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@chrisleewilcox
chrisleewilcox added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit 45bd787 Aug 11, 2026
201 of 204 checks passed
@chrisleewilcox
chrisleewilcox deleted the MMQA-2254-skip-confirmations-android-blockers branch August 11, 2026 04:45
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 11, 2026
@metamask-ci metamask-ci Bot added the release-8.8.0 Issue or pull request that will be included in release 8.8.0 label Aug 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.8.0 Issue or pull request that will be included in release 8.8.0 risk:low AI analysis: low risk size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants