Skip to content

fix: fix account api cache cp-8.8.0 #34748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salimtb wants to merge 5 commits into
base: main
Choose a base branch
from
+70 −4
Open

fix: fix account api cache cp-8.8.0 #34748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ed17dc
fix: fix account api cache
salimtb Aug 13, 2026
7c01da0
fix: revert assets-controller forceUpdate cache window to 0/0
salimtb Aug 13, 2026
eb714d4
fix: patch assets-controller to never cache Accounts API balances
salimtb Aug 13, 2026
c52cc32
fix: patch assets-controller to match core#9870
salimtb Aug 13, 2026
a26f683
Merge branch 'main' into fix/fix-account-api-cache
salimtb Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .yarn/patches/@metamask-assets-controller-npm-13.1.3-bb9a075a03.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
diff --git a/dist/data-sources/AccountsApiDataSource.cjs b/dist/data-sources/AccountsApiDataSource.cjs
index bf8742cc220732a274d1f40e20d2a9b2a1dbca66..2fe7a3b92055ba6705d944d0c9ef15e876db8cdf 100644
--- a/dist/data-sources/AccountsApiDataSource.cjs
+++ b/dist/data-sources/AccountsApiDataSource.cjs
@@ -187,7 +187,7 @@ class AccountsApiDataSource extends AbstractDataSource_js_1.AbstractDataSource {
return response;
}
const fetchOptions = request.forceUpdate
- ? { staleTime: 100, gcTime: 100 }
+ ? { staleTime: 0, gcTime: 0 }
: undefined;
// Feature-flagged: v6 endpoint with a fallback to legacy v5. The flag is
// read here (not cached) so a runtime toggle can revert v6 -> v5.
diff --git a/dist/data-sources/AccountsApiDataSource.mjs b/dist/data-sources/AccountsApiDataSource.mjs
index fe209d53cd62299cb5e53c1685ed29d792fe5530..762ab07e282e6b46e90bd4384098c902f1f29230 100644
--- a/dist/data-sources/AccountsApiDataSource.mjs
+++ b/dist/data-sources/AccountsApiDataSource.mjs
@@ -183,7 +183,7 @@ export class AccountsApiDataSource extends AbstractDataSource {
return response;
}
const fetchOptions = request.forceUpdate
- ? { staleTime: 100, gcTime: 100 }
+ ? { staleTime: 0, gcTime: 0 }
: undefined;
// Feature-flagged: v6 endpoint with a fallback to legacy v5. The flag is
// read here (not cached) so a runtime toggle can revert v6 -> v5.
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@
"@react-native/babel-preset@npm:0.83.6": "patch:@react-native/babel-preset@npm%3A0.83.6#~/.yarn/patches/@react-native-babel-preset-npm-0.83.6-90eed53ffb.patch",
"@metamask/network-enablement-controller@npm:^5.4.1": "patch:@metamask/network-enablement-controller@npm%3A5.4.1#~/.yarn/patches/@metamask-network-enablement-controller-npm-5.4.1-020a82a308.patch",
"@ledgerhq/context-module/ethers": "^6.16.0",
"@ledgerhq/device-signer-kit-ethereum/ethers": "^6.16.0"
"@ledgerhq/device-signer-kit-ethereum/ethers": "^6.16.0",
"@metamask/assets-controller@npm:^13.1.3": "patch:@metamask/assets-controller@npm%3A13.1.3#~/.yarn/patches/@metamask-assets-controller-npm-13.1.3-bb9a075a03.patch"
},
"dependencies": {
"@braze/react-native-sdk": "patch:@braze/react-native-sdk@npm%3A19.1.0#~/.yarn/patches/@braze-react-native-sdk-npm-19.1.0-076-reactmoduleinfo.patch",
Expand Down Expand Up @@ -255,7 +256,7 @@
"@metamask/analytics-controller": "^2.0.0",
"@metamask/app-metadata-controller": "^2.0.0",
"@metamask/approval-controller": "^9.0.0",
"@metamask/assets-controller": "^13.1.3",
"@metamask/assets-controller": "patch:@metamask/assets-controller@npm%3A13.1.3#~/.yarn/patches/@metamask-assets-controller-npm-13.1.3-bb9a075a03.patch",
"@metamask/assets-controllers": "^111.0.0",
"@metamask/authenticated-user-storage": "^3.0.1",
"@metamask/base-controller": "^9.0.1",
Expand Down
43 changes: 41 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7746,7 +7746,7 @@ __metadata:
languageName: node
linkType: hard

"@metamask/assets-controller@npm:^13.1.2, @metamask/assets-controller@npm:^13.1.3":
"@metamask/assets-controller@npm:13.1.3, @metamask/assets-controller@npm:^13.1.2":
version: 13.1.3
resolution: "@metamask/assets-controller@npm:13.1.3"
dependencies:
Expand Down Expand Up @@ -7785,6 +7785,45 @@ __metadata:
languageName: node
linkType: hard

"@metamask/assets-controller@patch:@metamask/assets-controller@npm%3A13.1.3#~/.yarn/patches/@metamask-assets-controller-npm-13.1.3-bb9a075a03.patch":
version: 13.1.3
resolution: "@metamask/assets-controller@patch:@metamask/assets-controller@npm%3A13.1.3#~/.yarn/patches/@metamask-assets-controller-npm-13.1.3-bb9a075a03.patch::version=13.1.3&hash=2f37fd"
dependencies:
"@ethereumjs/util": "npm:^9.1.0"
"@ethersproject/abi": "npm:^5.7.0"
"@ethersproject/providers": "npm:^5.7.0"
"@metamask/account-tree-controller": "npm:^7.6.1"
"@metamask/accounts-controller": "npm:^39.1.0"
"@metamask/assets-controllers": "npm:^111.1.0"
"@metamask/base-controller": "npm:^9.1.0"
"@metamask/client-controller": "npm:^1.0.1"
"@metamask/config-registry-controller": "npm:^2.0.1"
"@metamask/controller-utils": "npm:^12.3.0"
"@metamask/core-backend": "npm:^8.1.1"
"@metamask/keyring-api": "npm:^24.0.0"
"@metamask/keyring-controller": "npm:^27.1.1"
"@metamask/keyring-internal-api": "npm:^12.0.0"
"@metamask/keyring-snap-client": "npm:^10.0.0"
"@metamask/messenger": "npm:^2.0.0"
"@metamask/network-controller": "npm:^35.0.1"
"@metamask/network-enablement-controller": "npm:^6.0.3"
"@metamask/permission-controller": "npm:^13.1.1"
"@metamask/phishing-controller": "npm:^17.3.1"
"@metamask/polling-controller": "npm:^16.0.9"
"@metamask/preferences-controller": "npm:^23.1.0"
"@metamask/remote-feature-flag-controller": "npm:^5.0.0"
"@metamask/snaps-controllers": "npm:^19.0.0"
"@metamask/snaps-utils": "npm:^12.1.2"
"@metamask/transaction-controller": "npm:^69.5.2"
"@metamask/utils": "npm:^11.11.0"
async-mutex: "npm:^0.5.0"
bignumber.js: "npm:^9.1.2"
lodash: "npm:^4.17.21"
p-limit: "npm:^3.1.0"
checksum: 10/2b5c3e1d1ee7388f60028b40e190f77e7eb8fa7fc6d20561c2889b954d84fdd9ec417dc9edb5fca3d0ef699b05ecd9687125fa0e6bf7ea2b04e787242819545e
languageName: node
linkType: hard

"@metamask/assets-controllers@npm:^111.0.0, @metamask/assets-controllers@npm:^111.1.0":
version: 111.1.0
resolution: "@metamask/assets-controllers@npm:111.1.0"
Expand Down Expand Up @@ -35607,7 +35646,7 @@ __metadata:
"@metamask/analytics-controller": "npm:^2.0.0"
"@metamask/app-metadata-controller": "npm:^2.0.0"
"@metamask/approval-controller": "npm:^9.0.0"
"@metamask/assets-controller": "npm:^13.1.3"
"@metamask/assets-controller": "patch:@metamask/assets-controller@npm%3A13.1.3#~/.yarn/patches/@metamask-assets-controller-npm-13.1.3-bb9a075a03.patch"
"@metamask/assets-controllers": "npm:^111.0.0"
"@metamask/authenticated-user-storage": "npm:^3.0.1"
"@metamask/auto-changelog": "npm:^6.2.0"
Expand Down
Loading