Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace Hermes with [email protected] and enable SES #8905

Closed
wants to merge 9 commits into from
Closed

feat: Replace Hermes with [email protected] and enable SES #8905

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
853aef5
Disable Hermes
leotm Mar 12, 2024
e0675b3
Add [email protected]
leotm Mar 21, 2024
8209576
Update jscFlavor to org.webkit:android-jsc-intl:+
leotm Mar 21, 2024
2e48dad
Ignore jsc-android with depcheck
leotm Mar 21, 2024
34ebf8c
Add depcheck comment
leotm Mar 21, 2024
b707dea
Deduplicate deps
leotm Mar 21, 2024
5c96aa6
Enable SES on both platforms
leotm Mar 21, 2024
e7542c0
Show SES toggle on both platforms
leotm Mar 21, 2024
447b972
Merge branch 'main' into android-jsc
Cal-L Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions patches/react-native+0.71.15.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
diff --git a/node_modules/react-native/Libraries/Core/InitializeCore.js b/node_modules/react-native/Libraries/Core/InitializeCore.js
index 1379ffd..f2825f5 100644
index 1379ffd..9e5ff61 100644
--- a/node_modules/react-native/Libraries/Core/InitializeCore.js
+++ b/node_modules/react-native/Libraries/Core/InitializeCore.js
@@ -24,26 +24,37 @@
@@ -24,26 +24,35 @@

'use strict';

+const Platform = require('../Utilities/Platform');
+
+if (Platform.OS === 'ios' && !global?.HermesInternal) {
+ require('./setUpSes');
+}
+require('./setUpSes');
Copy link
Member Author

@leotm leotm Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preserve !global?.HermesInternal condition
so enabling Hermes runs app w/o SES
until support lands

then we upgrade SES and remove the condition

+
const start = Date.now();

Expand Down Expand Up @@ -44,7 +42,7 @@ index 1379ffd..f2825f5 100644
// We could just call GlobalPerformanceLogger.markPoint at the top of the file,
diff --git a/node_modules/react-native/Libraries/Core/setUpSes.js b/node_modules/react-native/Libraries/Core/setUpSes.js
new file mode 100644
index 0000000..6013411
index 0000000..5dc1859
--- /dev/null
+++ b/node_modules/react-native/Libraries/Core/setUpSes.js
@@ -0,0 +1,60 @@
Expand Down Expand Up @@ -237,4 +235,4 @@ index 290bd23..20d85e0 100644
+ }
}
return inputConnection;
}
}