feat: Adds data domain - product-analytics knowledge - #143
Draft
MajorLift wants to merge 1 commit into
Draft
Conversation
`metrametrics-identity` and `segment-governance`, split out of the domain that was called `analytics` and is becoming `observability` in #76. Traces, errors and span cost are one subject; product analytics is another, and with MetaMetrics migrating to `AnalyticsController` in both clients this half needs a name that outlives the tool. Knowledge only, no skill yet. `tools/install` copies domain knowledge beside each skill in its domain, so nothing here installs until the domain gains one — stated in the body rather than discovered at install time.
MajorLift
added a commit
to MajorLift/metamask-skills
that referenced
this pull request
Sep 1, 2026
`span-sub-sampling` still declared `domain: analytics` after the rename. `lint-skill-entry` requires `domain` to match the parent directory, so the rename shipped a lint error — caught by checking the merge into `main`, not by checking this branch, which predates `tools/skill-schema.mjs` and cannot run the linter at all. `domains/data/` moves to MetaMask#143 with the same fix applied.
MajorLift
changed the title
data domain for product-analytics knowledgedata domain - product-analytics knowledge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sentry, Tempo and Grafana answer what is the system doing. MetaMetrics and Segment answer what are users doing. One domain name covered both, with different tools, different owners and different failure modes, and sharing a directory made neither findable by the people who wanted it.
MetaMetrics is moving to
AnalyticsControllerin both clients. A domain named for the tool would need renaming again when the tool goes, so this half is named for its subject.Overview
A
datadomain for product analytics, holding two knowledge files taken from the domain that was calledanalytics:metrametrics-identityandsegment-governance. #76 renames the remainder toobservability.This domain ships no skill, so its knowledge installs nowhere yet.
tools/installcopies domain knowledge per skill, and there is no skill indatato trigger the copy.That leaves two things open, neither fixed here:
observability/instrumentationcites both files,observability/sentry-quotacitessegment-governance. fix(cli): Ensureknowledge/citations and cross-skill references resolve #87 (makeknowledge/citations resolve once installed) is the change that fixes those.A skill landing in
datacloses both at once: the knowledge installs, and the citations stop crossing. The natural candidate is the MetaMetrics-and-Segment material currently insideobservability/instrumentation, which stayed there because its Sentry half dominates (#76).