feat: Extends performance domain with measurement skills - #144
Open
MajorLift wants to merge 1 commit into
Open
Conversation
`extension-profiling`, `react-render-delta`, `data-analysis` and `benchmark-design`, split from MetaMask#43 so the audit half reviews separately. The existing `performance` skill is mobile-scoped and advisory — it says what to change. Nothing in the repo says how to prove a change worked, and the extension has no profiling skill at all.
MajorLift
added a commit
to MajorLift/metamask-skills
that referenced
this pull request
Sep 1, 2026
…audit here `react-render-delta`, `extension-profiling`, `data-analysis` and `benchmark-design` measure; the two scans and the mobile reference updates review. Verified disjoint — no citation crosses the split.
performance domain with measurement skills
performance domain with measurement skillsperformance domain - /extension-profiling, /react-render-delta, /data-analysis, /benchmark-design skills
performance domain - /extension-profiling, /react-render-delta, /data-analysis, /benchmark-design skillsperformance domain with profiling, render-delta, benchmarking skills
MajorLift
marked this pull request as ready for review
September 1, 2026 14:25
performance domain with profiling, render-delta, benchmarking skillsperformance domain with measurement skills
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
domains/performancealready has five skills, and none of them measures anything.The
performanceskill is mobile-only. The fourperf-*skills are extension-only pattern guides, andtesting/performance-testingruns mobile E2E.So the repo tells you what to change, per platform, and nothing tells you whether the change worked. Three gaps follow, and each has a specific cost:
The extension has no profiling skill. Every profiling reference on
mainis mobile tooling that does not exist in a browser. An extension engineer asking "where is the time going" has nothing to open.Nothing proves a render optimization landed. A
useMemothat fires on every render still looks correct in review and still ships. The mechanism is plausible either way. Only the re-render count separates a workinguseMemofrom one that fires every render, and a delivery gate is what stops a change shipping on the strength of the story.Nothing says what a benchmark difference means.
performance-testingruns the benchmark. How many rounds, how much variance, and whether a 4% gap is a result are all unanswered. Without that a benchmark reports noise as a win, which is worse than not running one, because it produces a number people cite.Web Vitals gets its own knowledge for the same reason: production and benchmark numbers routinely disagree, and the disagreement is a property of how they are collected rather than a regression.
Overview
Four skills for measuring frontend performance. The antipattern scans are in #43.
extension-profilingcompares two branches with why-did-you-render, the React DevTools Profiler and E2E benchmarks.react-render-deltaproves a memoization change reduced work, using re-render counts, reselect's.recomputations(), A/B arms toggled at a flag, and a delivery gate with a reported band.benchmark-designcovers session hygiene, per-round reporting and artifact grouping.data-analysisruns collection → filtering → curation → questioning → synthesis, with confidence assigned per finding.Knowledge:
metrics-pipeline-design,benchmark-statistical-hygiene, and three on Web Vitals: runtime metrics, attribution import, and why production numbers disagree with benchmark numbers.Showcase
No trial run yet. These are measurement instruments, and the honest evidence for one is a run that moved a decision. There is not one to cite.