Skip to content

feat: route Solana asset balance reads through Core AssetsController - #634

Closed
ulissesferreira wants to merge 12 commits into
mainfrom
feat/core-assets-controller-cutover
Closed

feat: route Solana asset balance reads through Core AssetsController#634
ulissesferreira wants to merge 12 commits into
mainfrom
feat/core-assets-controller-cutover

Conversation

@ulissesferreira

Copy link
Copy Markdown
Contributor

Summary

  • Bump snaps-sdk / platformVersion to 11.2.0 and add endowment:messenger for AssetsController:getAsset and AssetsController:getAssets.
  • Replace Snap-owned balance persistence (AssetsRepository / assetEntities) with Core reads via a slim AssetsService (getAccountAssetByID, getAccountAssetsByIDs, getAccountAssets) and CoreAssetsAdapter.
  • Rewire Keyring, Send, AccountsSynchronizer, and KeyringAccountMonitor so balances come from Core; WS monitoring keeps transaction discovery only. Metadata / market-data handlers stay Snap-side.

Test plan

  • yarn workspace @metamask/solana-wallet-snap test
  • Confirm Keyring listAccountAssets / getAccountBalances return Core-backed data under a client with AssetsController populated
  • Confirm Send form loads balances and amount validation works
  • Confirm account sync still saves transactions without writing Snap assetEntities
  • Confirm WS account/program notifications still persist causing transactions and do not emit Snap balance updates
  • Smoke onAssetsLookup / onAssetsMarketData

@ulissesferreira
ulissesferreira requested a review from a team as a code owner July 31, 2026 10:38

@mikesposito mikesposito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is not accepting PRs anymore, as we are in the process of migrating it to https://github.com/MetaMask/internal-snaps

@ulissesferreira
ulissesferreira marked this pull request as draft July 31, 2026 10:41
@ulissesferreira

Copy link
Copy Markdown
Contributor Author

This repo is not accepting PRs anymore, as we are in the process of migrating it to https://github.com/MetaMask/internal-snaps

Yeah it will be moved when ready

@ulissesferreira

Copy link
Copy Markdown
Contributor Author

Closing as superseded — this monolithic cutover was split into the stacked chain: #635#636#637, then either Lane A (#641#644#643) or Lane B (#638#639#640). Work lives on those branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants