feat: route Solana asset balance reads through Core AssetsController - #634
Closed
ulissesferreira wants to merge 12 commits into
Closed
feat: route Solana asset balance reads through Core AssetsController#634ulissesferreira wants to merge 12 commits into
ulissesferreira wants to merge 12 commits into
Conversation
mikesposito
requested changes
Jul 31, 2026
mikesposito
left a comment
Member
There was a problem hiding this comment.
This repo is not accepting PRs anymore, as we are in the process of migrating it to https://github.com/MetaMask/internal-snaps
ulissesferreira
marked this pull request as draft
July 31, 2026 10:41
Contributor
Author
Yeah it will be moved when ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endowment:messengerforAssetsController:getAssetandAssetsController:getAssets.AssetsRepository/assetEntities) with Core reads via a slimAssetsService(getAccountAssetByID,getAccountAssetsByIDs,getAccountAssets) andCoreAssetsAdapter.Test plan
yarn workspace @metamask/solana-wallet-snap testlistAccountAssets/getAccountBalancesreturn Core-backed data under a client with AssetsController populatedassetEntitiesonAssetsLookup/onAssetsMarketData