fix: add Authorizations section on SignTransaction and SignAuthEntry dialog - #173
Merged
Conversation
| * @param authEntry - Base64-encoded `HashIdPreimage` XDR. | ||
| * @returns Fields displayed in the confirmation dialog. | ||
| */ | ||
| function decodeSorobanAuthPreimage(authEntry: string): ReadableAuthEntry { |
Collaborator
Author
There was a problem hiding this comment.
remove all redundant function, as operationMapper now support the mapping
| const preimage = xdr.HashIdPreimage.fromXDR(authEntry, 'base64'); | ||
| const sorobanAuth = preimage.sorobanAuthorization(); | ||
|
|
||
| let functionType: ReadableInvocation['functionType']; |
Collaborator
Author
There was a problem hiding this comment.
remove all redundant function, as operationMapper now support the mapping
| /** | ||
| * Abstract class for mapping operations to readable JSON. | ||
| */ | ||
| class AbstractOperationMapper { |
Collaborator
Author
There was a problem hiding this comment.
new class to share field and normalizeAmount function
| } | ||
| } | ||
|
|
||
| export class AuthorizationMapper extends AbstractOperationMapper { |
Collaborator
Author
There was a problem hiding this comment.
new class to handle mapping for authorization
| feeSourceAccount: transaction.feeSourceAccount, | ||
| memo: transaction.getMemo(), | ||
| operations, | ||
| authorizations, |
Collaborator
Author
There was a problem hiding this comment.
add authorizations field for UI to handle
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated Authorizations section to the Snap confirmation UIs for SignTransaction and SignAuthEntry, and centralizes Soroban invocation rendering so both dialogs share the same layout.
Changes:
- Introduces shared UI components for Soroban invocation + JSON argument rendering and reuses them in both confirmation views.
- Extends transaction mapping to extract Soroban authorization entries into a separate
readableTransaction.authorizationsstructure. - Adds
getParamhelper (with tests) and updates i18n strings to support the new section.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/snap/src/ui/confirmation/views/ConfirmSignTransaction/ConfirmSignTransaction.tsx | Renders new Authorizations section and uses shared invocation/params summaries. |
| packages/snap/src/ui/confirmation/views/ConfirmSignAuthEntry/ConfirmSignAuthEntry.tsx | Switches sign-auth-entry UI to render Authorizations section and shows nonce/expiry rows. |
| packages/snap/src/ui/confirmation/utils.ts | Adds getParam helper for extracting fields from readable params. |
| packages/snap/src/ui/confirmation/utils.test.ts | Adds unit tests for getParam. |
| packages/snap/src/ui/confirmation/components/JsonParamsSummary.tsx | New component to render JSON/array params as copyable, labeled argument rows. |
| packages/snap/src/ui/confirmation/components/InvocationSummary.tsx | New shared component for Soroban invocation (contract/function/args). |
| packages/snap/src/ui/confirmation/components/index.ts | Exports newly added confirmation UI components. |
| packages/snap/src/ui/confirmation/components/Authorizations.tsx | New component to display a top-level Authorizations section in confirmations. |
| packages/snap/src/services/transaction/OperationMapper.ts | Adds authorization mapping + refactors field normalization and field typing via FieldType. |
| packages/snap/src/services/transaction/OperationMapper.test.ts | Adds coverage for mapping invokeHostFunction auth entries into the new authorizations structure. |
| packages/snap/src/handlers/keyring/signAuthEntry.ts | Refactors SEP-43 preimage decoding to reuse AuthorizationMapper and new readable shape. |
| packages/snap/src/handlers/keyring/signAuthEntry.test.ts | Updates expectations to match the new readable auth-entry structure. |
| packages/snap/messages.json | Updates/renames confirmation strings for new Authorizations + Invocation labels. |
| packages/snap/locales/en.json | Mirrors messages updates for English locale. |
| packages/snap/locales/es.json | Mirrors messages updates for Spanish locale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+55
to
+57
| <Box>{null}</Box> | ||
| <Divider /> | ||
| <Box>{null}</Box> |
Collaborator
Author
There was a problem hiding this comment.
this is by purpose to make space
| 'note', | ||
| `Unhandled or newer operation type "${unknownOp.type}".`, | ||
| 'text', | ||
| `Unhandled or newer operation type.`, |
Collaborator
Author
There was a problem hiding this comment.
we dont need to show the type
| // (whose children we expand into their own card right below) and enabled | ||
| // only for deeper nesting where we don't recurse — there the count is the | ||
| // only signal the user gets that more calls exist beneath. | ||
| const InvocationSummary = ({ |
Collaborator
Author
There was a problem hiding this comment.
move it to share component
| {showNestedCount && subInvocations.length > 0 ? ( | ||
| <Box direction="vertical"> | ||
| <SnapText fontWeight="medium" color="alternative"> | ||
| {translate('confirmation.signAuthEntry.subInvocations')} |
Collaborator
Author
There was a problem hiding this comment.
we dont need to display the length of subInvocations
align with sign txn
| * @param params.translate - Translation function. | ||
| * @returns JSX for the confirmation row value. | ||
| */ | ||
| const JsonParamValue = ({ |
Collaborator
Author
There was a problem hiding this comment.
move it to share JsonParamsSummary
| case 'json': | ||
| return <JsonParamValue value={value} translate={translate} />; | ||
| default: | ||
| if (Array.isArray(value)) { |
Collaborator
Author
There was a problem hiding this comment.
either json, copyable, array, string or object, it already handle in JsonParamsSummary
jeremytsng
reviewed
Aug 6, 2026
Comment on lines
+345
to
+346
| {isInvokeHostFunction ? ( | ||
| <InvocationSummary |
Contributor
There was a problem hiding this comment.
Should this also handle the note and source fields, or do those intentionally not apply here?
Collaborator
Author
There was a problem hiding this comment.
good catch
jeremytsng
self-requested a review
August 6, 2026 10:08
jeremytsng
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds a dedicated Authorizations section to the Snap confirmation UIs for
SignTransactionandSignAuthEntry, and centralizes Soroban invocation rendering so both dialogs share the same layout.Changes:
readableTransaction.authorizationsstructure.getParamhelper (with tests) and updates i18n strings to support the new section.Sign Auth Entry
https://www.loom.com/share/80a6c678019f4e0291eecd67b25a980a
Sign Transaction
https://www.loom.com/share/3acce44e054c4b8f8306967e17925636
References
Checklist