This repository was archived by the owner on Jul 31, 2026. It is now read-only.
feat: read Tron assets from controller with fallback - #361
Closed
ulissesferreira wants to merge 2 commits into
Closed
feat: read Tron assets from controller with fallback#361ulissesferreira wants to merge 2 commits into
ulissesferreira wants to merge 2 commits into
Conversation
Routes transaction and confirmation asset reads through the staged controller adapter. Builds on WPN-1478-migration-foundation. Jira: WPN-1478
4 tasks
Contributor
Author
|
Tentative approach under old ASSETS-2 shape — superseded by WPN-1478 redesign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Stacked on: ##360 (
WPN-1497-migration-foundation)This is PR 2/4 for WPN-1478.
Current state: The Snap reads assets from local state exclusively. Asset queries (balance checks, fee computation, send validation) never touch the AssetsController.
This PR: Routes all 11 asset read sites through
getAssetForStage(), a 4-stage switch that encodes the full rollout:Also introduces
buildControllerSnapshot()for initial sync and gatesKeyringEventson stage < 3 (events fire through stage 2 for rollback safety, per the Jira spec).Files: 8 modified. +411 lines.
References
Checklist