This repository was archived by the owner on Jul 31, 2026. It is now read-only.
feat: push special asset snapshots to controller - #362
Closed
ulissesferreira wants to merge 2 commits into
Closed
Conversation
Disables Snap asset persistence for controller-only migration stages. Builds on WPN-1478-controller-reads-fallback. Jira: WPN-1478
Writes grouped special Tron assets to the controller during asset synchronization. Builds on WPN-1478-stage-gating-telemetry. Jira: WPN-1478
4 tasks
Contributor
Author
|
Tentative approach under old ASSETS-2 shape — superseded by WPN-1478 redesign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Stacked on: ##361 (
WPN-1497-controller-reads)This is PR 3/4 for WPN-1478.
Current state: After the read path migration (PR 2), the Snap still writes asset state locally — the controller never receives updated balances from the Snap's polling cycle.
This PR: Adds the write path: when the Snap polls the chain and detects balance changes,
shouldPushSnapAssets()gates the push at stage ≥ 1, andpushAssetSnapshot()sends the full asset snapshot (all balances for an account) toAssetsController:upsertSnapAssets.Covers all 9 Tron special assets:
Files: 3 modified. +602 lines.
References
AssetsController:upsertSnapAssetsaction (WPN-1473 is read-only — a new ticket or broadening is needed)Checklist