This repository was archived by the owner on Jul 31, 2026. It is now read-only.
feat: gate controller-only asset tracking - #363
Closed
ulissesferreira wants to merge 1 commit into
Closed
Conversation
Disables Snap asset persistence for controller-only migration stages. Builds on WPN-1478-controller-reads-fallback. Jira: WPN-1478
Contributor
Author
|
Tentative approach under old ASSETS-2 shape — superseded by WPN-1478 redesign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Stacked on: ##362 (
WPN-1497-special-assets-writes)This is PR 4/4 — the final stage for WPN-1478.
Current state: Through stage 2, the Snap continues to poll the chain and persist assets locally alongside the controller write path. This dual-write ensures rollback safety (if the rollout flag is reduced, Snap state is still accurate).
This PR: At stage 3 (
ReadAssetsControllerOnly), gates all Snap-side tracking and persistence off:AssetsService.saveMany/ local persistence stopsAccountAssetListUpdated/AccountBalancesUpdatedevents stopThe controller is now the sole source of truth for Tron assets. Rollback requires re-enabling tracking + resync.
Files: 2 modified. Built on reads branch.
References
Checklist