This repository was archived by the owner on Jul 31, 2026. It is now read-only.
fix: allow pending transactions to be updated when confirmed - #194
Merged
ulissesferreira merged 1 commit intoFeb 5, 2026
Merged
Conversation
The incremental sync was filtering out all transactions whose IDs already existed in state, including pending transactions. This meant pending transactions could never be updated to confirmed status. Changed to only skip transactions that are already confirmed/failed, allowing pending transactions to be re-fetched and updated.
ulissesferreira
force-pushed
the
NEB-473/fix-pending-transaction-status-update
branch
from
February 5, 2026 17:16
f5e898b to
d41aa44
Compare
ulissesferreira
deleted the
NEB-473/fix-pending-transaction-status-update
branch
February 5, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The incremental sync was filtering out all transactions whose IDs already existed in state, including pending transactions. This meant pending transactions could never be updated to confirmed status.
Changed to only skip transactions that are already confirmed/failed, allowing pending transactions to be re-fetched and updated.