This repository was archived by the owner on Jul 31, 2026. It is now read-only.
Contract simulation accuracy - #211
Merged
ulissesferreira merged 1 commit intoFeb 20, 2026
Merged
Conversation
- Update supported contract types: TransferContract, CreateSmartContract, TriggerSmartContract - Add 'simulationAccurate' flag to TransactionScanResult - For unsupported transactions: return empty estimated changes instead of blocking - Only block confirm button for accurate simulations with errors - Update tests to reflect new supported contract types Co-authored-by: ulisses.ferreira <ulisses.ferreira@consensys.net>
|
Cursor Agent can help with this pull request. Just |
ulissesferreira
marked this pull request as ready for review
February 20, 2026 10:42
ulissesferreira
merged commit Feb 20, 2026
6f768c3
into
mikesposito/fix/disable-scan-for-unsupported-txs
7 of 8 checks passed
cursor Bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
Enhance security scan accuracy by limiting API calls to supported contract types and adjusting confirmation button behavior based on simulation accuracy. The previous implementation attempted to scan all transaction types, which could lead to misleading or irrelevant security alerts for unsupported contracts. This PR introduces a `simulationAccurate` flag to distinguish between reliable scans (for supported contracts) and unreliable ones (for unsupported contracts or multiple contract calls). For unreliable simulations, the "Estimated Changes" will be empty, and the user will always be able to proceed, even if the scan itself returns an error. For accurate simulations, the "Confirm" button will be blocked if the scan encounters an error, ensuring users are only blocked when the simulation is considered reliable. --- <p><a href="https://cursor.com/background-agent?bcId=bc-3af945ef-4817-4045-9ea9-6281fed76d50"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-3af945ef-4817-4045-9ea9-6281fed76d50"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
![https://cursor.com/assets/images/open-in-cursor-dark.png"><source](https://cursor.com/assets/images/open-in-cursor-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-cursor-light.png"><img](https://cursor.com/assets/images/open-in-cursor-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a](https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"><source](https://cursor.com/assets/images/open-in-web-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-web-light.png"><img](https://cursor.com/assets/images/open-in-web-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p](https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p){kind=link}
ulissesferreira
added a commit
that referenced
this pull request
Feb 20, 2026
Enhance security scan accuracy by limiting API calls to supported contract types and adjusting confirmation button behavior based on simulation accuracy. The previous implementation attempted to scan all transaction types, which could lead to misleading or irrelevant security alerts for unsupported contracts. This PR introduces a `simulationAccurate` flag to distinguish between reliable scans (for supported contracts) and unreliable ones (for unsupported contracts or multiple contract calls). For unreliable simulations, the "Estimated Changes" will be empty, and the user will always be able to proceed, even if the scan itself returns an error. For accurate simulations, the "Confirm" button will be blocked if the scan encounters an error, ensuring users are only blocked when the simulation is considered reliable. --- <p><a href="https://cursor.com/background-agent?bcId=bc-3af945ef-4817-4045-9ea9-6281fed76d50"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-3af945ef-4817-4045-9ea9-6281fed76d50"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
ulissesferreira
added a commit
that referenced
this pull request
Mar 12, 2026
Enhance security scan accuracy by limiting API calls to supported contract types and adjusting confirmation button behavior based on simulation accuracy. The previous implementation attempted to scan all transaction types, which could lead to misleading or irrelevant security alerts for unsupported contracts. This PR introduces a `simulationAccurate` flag to distinguish between reliable scans (for supported contracts) and unreliable ones (for unsupported contracts or multiple contract calls). For unreliable simulations, the "Estimated Changes" will be empty, and the user will always be able to proceed, even if the scan itself returns an error. For accurate simulations, the "Confirm" button will be blocked if the scan encounters an error, ensuring users are only blocked when the simulation is considered reliable. --- <p><a href="https://cursor.com/background-agent?bcId=bc-3af945ef-4817-4045-9ea9-6281fed76d50"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-3af945ef-4817-4045-9ea9-6281fed76d50"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance security scan accuracy by limiting API calls to supported contract types and adjusting confirmation button behavior based on simulation accuracy.
The previous implementation attempted to scan all transaction types, which could lead to misleading or irrelevant security alerts for unsupported contracts. This PR introduces a
simulationAccurateflag to distinguish between reliable scans (for supported contracts) and unreliable ones (for unsupported contracts or multiple contract calls). For unreliable simulations, the "Estimated Changes" will be empty, and the user will always be able to proceed, even if the scan itself returns an error. For accurate simulations, the "Confirm" button will be blocked if the scan encounters an error, ensuring users are only blocked when the simulation is considered reliable.