This repository was archived by the owner on Jul 31, 2026. It is now read-only.
fix: disclose WitnessCreateContract 9,999 TRX burn fee (WPN-1719) - #382
Open
ulissesferreira wants to merge 3 commits into
Open
fix: disclose WitnessCreateContract 9,999 TRX burn fee (WPN-1719)#382ulissesferreira wants to merge 3 commits into
ulissesferreira wants to merge 3 commits into
Conversation
Include getAccountUpgradeCost in fee calculation for WitnessCreateContract so Network fee and insufficient-balance checks reflect the irreversible protocol burn. Replace the generic unsupported-simulation copy with Super Representative candidate disclosure on confirmation. Fixes WPN-1719
ulissesferreira
marked this pull request as ready for review
July 29, 2026 09:04
The Check Changelog CI action requires Unreleased entries to reference the current pull request, not the Jira ticket.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When users sign a TRON
WitnessCreateContracttransaction (registering as a Super Representative candidate), MetaMask's Tron Snap confirmation UI only showed bandwidth fees (~0.291 TRX) and a generic "Unsupported contract for simulation" message. The protocol-enforced irreversible burn of 9,999 TRX (getAccountUpgradeCost) was omitted, so users could approve a transaction believing it cost only network fees.This change:
getAccountUpgradeCostin fee calculation forWitnessCreateContract, so the Network fee line and insufficient-balance checks reflect the full protocol cost (chain parameter with a 9,999 TRX fallback when params are unavailable).References
Checklist