This repository was archived by the owner on Jul 31, 2026. It is now read-only.
refactor: extract SnapAssetsAdapter from AssetsService - #383
Draft
ulissesferreira wants to merge 1 commit into
Draft
refactor: extract SnapAssetsAdapter from AssetsService#383ulissesferreira wants to merge 1 commit into
ulissesferreira wants to merge 1 commit into
Conversation
Move Snap-owned asset reads/fetches into an adapter and thin AssetsService to a facade with clearer method names, with no behavior change.
ulissesferreira
marked this pull request as draft
August 4, 2026 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SnapAssetsAdapter, leavingAssetsServiceas a thin facade over that adaptergetAccountAssetByID,getAccountAssetsByIDs,getAccountAssets) and move account sync orchestration intoAssetsService.synchronizeAccountsTest plan
yarn build:snap && yarn test -- packages/snap/src/services/assets/yarn test -- packages/snap/src/services/accounts/AccountsService.test.tsyarn test -- packages/snap/src/handlers/clientRequest/clientRequest.test.ts@metamask/assets-controller/ migration-stage wiring landed in this PR