Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @metamask/providers from 18.3.1 to 20.0.0 #3057

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 4, 2025

Bumps @metamask/providers from 18.3.1 to 20.0.0.

Release notes

Sourced from @​metamask/providers's releases.

20.0.0

Changed

  • BREAKING: An isConnected boolean property is now expected in the result of metamask_getProviderState and metamask_chainChanged events (#404)
  • BREAKING: A networkVersion value of loading received by the chainChanged event handler is now interpreted to be null. In this case, the networkChanged event emits a null value as well. (#404)
  • BREAKING: The disconnect event is now tied to the new isConnected property instead of the networkVersion property. (#404)
  • A change in the isUnlocked boolean property of the metamask_getProviderState and metamask_accountsChanged events (from what is in state) no longer causes the accountsChanged event to be emitted (#405)
  • MetaMaskInpageProvider.isUnlocked() will always return true until the inpage to contentscript stream ends and the provider enters a permanently disconnected state (#405)

19.0.0

Changed

  • BREAKING: StreamProvider no longer accepts a jsonRpcStreamName parameter (#400)
    • Previously, this parameter was used internally to create an ObjectMultiplex stream and substream for JSON-RPC communication
    • Now, the consumer is responsible for creating and managing the stream multiplexing if needed
    • The provider will use the provided stream connection directly without any multiplexing
  • BREAKING: MetaMaskInpageProvider no longer accepts a jsonRpcStreamName parameter (#400)
    • This change is inherited from StreamProvider, as MetaMaskInpageProvider extends StreamProvider
    • Stream multiplexing should be handled before provider instantiation
  • initializeInpageProvider now handles stream multiplexing internally (#400)
    • Creates an ObjectMultiplex instance and substream using the provided jsonRpcStreamName
    • This maintains backwards compatibility for consumers using initializeInpageProvider
  • createExternalExtensionProvider now handles stream multiplexing internally (#400)
    • Creates an ObjectMultiplex instance and substream for JSON-RPC communication
    • This maintains backwards compatibility for consumers using createExternalExtensionProvider
Changelog

Sourced from @​metamask/providers's changelog.

[20.0.0]

Changed

  • BREAKING: An isConnected boolean property is now expected in the result of metamask_getProviderState and metamask_chainChanged events (#404)
  • BREAKING: A networkVersion value of loading received by the chainChanged event handler is now interpreted to be null. In this case, the networkChanged event emits a null value as well. (#404)
  • BREAKING: The disconnect event is now tied to the new isConnected property instead of the networkVersion property. (#404)
  • A change in the isUnlocked boolean property of the metamask_getProviderState and metamask_accountsChanged events (from what is in state) no longer causes the accountsChanged event to be emitted (#405)
  • MetaMaskInpageProvider.isUnlocked() will always return true until the inpage to contentscript stream ends and the provider enters a permanently disconnected state (#405)

[19.0.0]

Changed

  • BREAKING: StreamProvider no longer accepts a jsonRpcStreamName parameter (#400)
    • Previously, this parameter was used internally to create an ObjectMultiplex stream and substream for JSON-RPC communication
    • Now, the consumer is responsible for creating and managing the stream multiplexing if needed
    • The provider will use the provided stream connection directly without any multiplexing
  • BREAKING: MetaMaskInpageProvider no longer accepts a jsonRpcStreamName parameter (#400)
    • This change is inherited from StreamProvider, as MetaMaskInpageProvider extends StreamProvider
    • Stream multiplexing should be handled before provider instantiation
  • initializeInpageProvider now handles stream multiplexing internally (#400)
    • Creates an ObjectMultiplex instance and substream using the provided jsonRpcStreamName
    • This maintains backwards compatibility for consumers using initializeInpageProvider
  • createExternalExtensionProvider now handles stream multiplexing internally (#400)
    • Creates an ObjectMultiplex instance and substream for JSON-RPC communication
    • This maintains backwards compatibility for consumers using createExternalExtensionProvider
Commits
  • e19bdf5 20.0.0 (#407)
  • bda8d72 fix: eth_accounts / accountsChanged behavior when wallet is locked (#405)
  • d919ab6 feat: allow networkVersion to be set to null. fire connection events base...
  • 11acfb0 19.0.0 (#402)
  • df85bdf refactor(StreamProvider): remove unnecessary stream multiplexing (#400)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner February 4, 2025 06:24
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 4, 2025
Copy link

socket-security bot commented Feb 4, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] Transitive: environment +9 1.35 MB metamaskbot

View full report↗︎

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/providers-20.0.0 branch 5 times, most recently from c2bb42f to 39c6f7a Compare February 6, 2025 09:38
@Mrtenz Mrtenz self-assigned this Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.86%. Comparing base (cc5cc01) to head (868e1cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cution-environments/src/common/BaseSnapExecutor.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   94.88%   94.86%   -0.02%     
==========================================
  Files         506      506              
  Lines       11124    11128       +4     
  Branches     1703     1704       +1     
==========================================
+ Hits        10555    10557       +2     
- Misses        569      571       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dependabot bot and others added 4 commits February 6, 2025 12:25
Bumps [@metamask/providers](https://github.com/MetaMask/providers) from 18.3.1 to 20.0.0.
- [Release notes](https://github.com/MetaMask/providers/releases)
- [Changelog](https://github.com/MetaMask/providers/blob/main/CHANGELOG.md)
- [Commits](MetaMask/providers@v18.3.1...v20.0.0)

---
updated-dependencies:
- dependency-name: "@metamask/providers"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@Mrtenz Mrtenz force-pushed the dependabot/npm_and_yarn/main/metamask/providers-20.0.0 branch from 9a92d7b to 868e1cd Compare February 6, 2025 11:25
const provider = new SnapProvider(this.rpcStream, {
jsonRpcStreamName: 'metamask-provider',
rpcMiddleware: [createIdRemapMiddleware()],
const multiplex = new ObjectMultiplex();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this in the extension?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did, and this works.

@@ -92,7 +92,7 @@
},
"dependencies": {
"@metamask/key-tree": "^10.0.2",
"@metamask/providers": "^18.3.1",
"@metamask/providers": "^20.0.0",
Copy link
Member

@FrederikBolding FrederikBolding Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in scope, but we can probably remove this type dep at this point. Since we control the request function entirely

@Mrtenz Mrtenz merged commit 3fa49bd into main Feb 6, 2025
172 of 174 checks passed
@Mrtenz Mrtenz deleted the dependabot/npm_and_yarn/main/metamask/providers-20.0.0 branch February 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants