chore: change from nomad to k8s #179
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes migrate the eVault provisioning system from Nomad to Kubernetes, replacing the job generation and submission logic with direct Kubernetes resource creation. The Changes
Sequence Diagram(s)sequenceDiagram
participant API as Provisioner API (index.ts)
participant K8S as Kubernetes Cluster
participant PVC as PersistentVolumeClaims
participant NS as Namespace
participant DEP as Deployment
participant SVC as Service
API->>API: Receive provision request (w3id, eVaultId)
API->>API: Call provisionEVault(w3id, eVaultId)
API->>K8S: Create Namespace (w3id)
API->>K8S: Create PVC for Neo4j data
API->>K8S: Create PVC for eVault storage
API->>K8S: Create PVC for eVault secrets
API->>K8S: Create Deployment (Neo4j + eVault containers)
API->>K8S: Create Service (LoadBalancer for eVault)
API->>K8S: Fetch and determine service URL
API-->>API: Return service URI
API->>Registry: Register URI via authenticated POST
API-->>Client: Respond with URI
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (2)
infrastructure/eid-wallet/src/routes/+layout.svelte (1)
56-60: Consider removing debug logging and adding error handling.The safe area implementation looks good, but there are a couple of improvements to consider:
- The debug logging on line 59 should be removed before production
- The
parseFloatoperation could benefit from more robust error handling-const safeAreaTop = $derived.by(() => parseFloat(getComputedStyle(document.documentElement).getPropertyValue('--safe-top')) || 0); - - -$effect(() => console.log("top", safeAreaTop)) +const safeAreaTop = $derived.by(() => { + const value = getComputedStyle(document.documentElement).getPropertyValue('--safe-top'); + const parsed = parseFloat(value); + return !isNaN(parsed) ? parsed : 0; +});infrastructure/evault-provisioner/src/templates/evault.nomad.ts (1)
108-109: Improve logging to avoid exposing sensitive data.Logging the entire service response object could expose sensitive Kubernetes metadata.
Log only the necessary information:
- const res = await coreApi.readNamespacedService({ name: 'evault-service', namespace: namespaceName }); - console.log(JSON.stringify(res)) + const res = await coreApi.readNamespacedService({ name: 'evault-service', namespace: namespaceName }); + const nodePort = res.body.spec?.ports?.[0]?.nodePort; + console.log(`eVault service created successfully. NodePort: ${nodePort}, Namespace: ${namespaceName}`);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet.xcodeproj/project.pbxprojis excluded by!**/gen/**pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
infrastructure/eid-wallet/src/routes/+layout.svelte(2 hunks)infrastructure/evault-core/src/evault.ts(2 hunks)infrastructure/evault-provisioner/package.json(1 hunks)infrastructure/evault-provisioner/src/index.ts(2 hunks)infrastructure/evault-provisioner/src/templates/evault.nomad.ts(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Check Code
infrastructure/eid-wallet/src/routes/+layout.svelte
[warning] 112-112: Unused CSS selector "body" (svelte)
[warning] 119-119: Unused CSS selector "body::-webkit-scrollbar" (svelte)
🪛 Biome (1.9.4)
infrastructure/evault-provisioner/src/templates/evault.nomad.ts
[error] 22-22: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
🔇 Additional comments (5)
infrastructure/eid-wallet/src/routes/+layout.svelte (1)
96-104: LGTM: Dynamic safe area implementation is well-structured.The dynamic height calculations using safe area insets are implemented correctly. The use of Tailwind's
calc()function with the computed safe area value ensures proper UI adaptation across different devices.infrastructure/evault-provisioner/package.json (1)
14-14:❓ Verification inconclusive
Verify dependency versions for security and compatibility.
The new dependencies support the Kubernetes migration well:
@kubernetes/client-nodefor Kubernetes API interactionsha256for password hashing (likely for Neo4j)Please verify that these dependency versions are secure and up-to-date:
Also applies to: 19-19
🏁 Script executed:
#!/bin/bash # Check for security advisories and latest versions echo "Checking @kubernetes/client-node..." npm view @kubernetes/client-node versions --json | jq '.[-5:]' echo "Checking sha256..." npm view sha256 versions --json | jq '.[-5:]' # Check for known vulnerabilities npm audit --audit-level moderateLength of output: 718
Dependency versions are up-to-date; please run a security audit
- infrastructure/evault-provisioner/package.json
@kubernetes/client-node@^1.3.0→ latest published is 1.3.0sha256@^0.2.0→ latest published is 0.2.0The
npm auditstep failed due to a missing lockfile. Please generate one (npm i --package-lock-only) and then rerun:npm audit --audit-level moderateto confirm there are no known vulnerabilities.
infrastructure/evault-core/src/evault.ts (2)
6-9: LGTM: Improved import formatting.The import statement formatting is more consistent and readable.
🧰 Tools
🪛 Biome (1.9.4)
[error] 5-9: Some named imports are only used as types.
This import is only used as a type.
This import is only used as a type.
This import is only used as a type.
Importing the types with import type ensures that they are removed by the compilers and avoids loading unnecessary modules.
Safe fix: Add inline type keywords.(lint/style/useImportType)
20-102: LGTM: Consistent code formatting throughout the class.The reformatting improves code readability and maintains consistent indentation throughout the EVault class. No functional changes were made, which is appropriate for this refactoring.
infrastructure/evault-provisioner/src/index.ts (1)
3-3: LGTM: Import updated for Kubernetes provisioning.The import change from Nomad job generation to Kubernetes provisioning aligns perfectly with the PR objectives of migrating from Nomad to Kubernetes.
infrastructure/evault-provisioner/src/templates/evault.nomad.ts
Outdated
Show resolved
Hide resolved
infrastructure/evault-provisioner/src/templates/evault.nomad.ts
Outdated
Show resolved
Hide resolved
infrastructure/evault-provisioner/src/templates/evault.nomad.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Docstrings generation was requested by @coodos. * #179 (comment) The following files were modified: * `infrastructure/evault-provisioner/src/templates/evault.nomad.ts`
|
Note Generated docstrings for this pull request at #181 |
Docstrings generation was requested by @coodos. * #179 (comment) The following files were modified: * `infrastructure/evault-provisioner/src/templates/evault.nomad.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…roject/prototype into feat/switch-to-k8s
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (5)
infrastructure/evault-provisioner/src/index.ts (1)
73-73:⚠️ Potential issueAdd error handling to the
provisionEVaultfunction.The
provisionEVaultfunction lacks proper error handling and status monitoring for Kubernetes resources. This could leave resources in an inconsistent state if provisioning fails.Run the following script to verify the current implementation:
#!/bin/bash # Check the provisionEVault implementation for error handling ast-grep --pattern $'export async function provisionEVault($$$) { $$$ }'infrastructure/evault-provisioner/src/templates/evault.nomad.ts (4)
22-26: Fix parameter handling, utilizeeVaultId, and strengthen password generation.This duplicates previous feedback about avoiding parameter reassignment and using secure password generation.
🧰 Tools
🪛 Biome (1.9.4)
[error] 24-24: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
33-36: Add namespace name sanitization and error handling.This duplicates previous feedback about sanitizing namespace names for Kubernetes DNS requirements and handling "already exists" errors.
70-95: Improve container configuration for production readiness.This duplicates previous feedback about adding resource limits, security contexts, and using versioned container tags.
22-162: Add comprehensive error handling and consider breaking down the function.This duplicates previous feedback about the function lacking error handling and being too large, which could leave resources in an inconsistent state.
🧰 Tools
🪛 Biome (1.9.4)
[error] 24-24: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
🧹 Nitpick comments (13)
infrastructure/evault-core/src/w3id/w3id.ts (2)
40-66: Improve error handling for key management operations.The current try-catch block silently creates new keys when existing ones can't be retrieved. Consider adding more specific error handling to distinguish between "seed not found" and other potential errors (e.g., decryption failures, file system errors).
- } catch { + } catch (error) { + // Only create new seed if it doesn't exist, re-throw other errors + if (error instanceof Error && !error.message.includes('No seed found')) { + throw error; + } // If no seed exists, create new one
15-19: Consider adding JSDoc documentation for the options parameter.The
getmethod has complex initialization logic and would benefit from clear documentation about when options are required versus optional.+ /** + * Gets or creates a W3ID instance with persistent key management. + * @param options - Required for first initialization, optional for subsequent calls + * @param options.id - The W3ID identifier + * @param options.driver - Neo4j driver for log storage + * @param options.password - Password for encrypting stored keys (required on first call) + */ static async get(options?: {platforms/registry/src/migrations/1748865359304-migration.ts (2)
1-1: Use import type for TypeORM interfaces.The static analysis correctly identifies that these imports are only used as types.
-import { MigrationInterface, QueryRunner } from "typeorm"; +import type { MigrationInterface, QueryRunner } from "typeorm";🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: All these imports are only used as types.
Importing the types with import type ensures that they are removed by the compilers and avoids loading unnecessary modules.
Safe fix: Use import type.(lint/style/useImportType)
7-7: Consider adding constraints and indexes for better data integrity and performance.The current table creation lacks important constraints and indexes that might be needed for a production vault registry.
Consider these improvements to the table schema:
- await queryRunner.query(`CREATE TABLE "vault" ("id" SERIAL NOT NULL, "ename" character varying NOT NULL, "uri" character varying NOT NULL, "evault" character varying NOT NULL, CONSTRAINT "PK_dd0898234c77f9d97585171ac59" PRIMARY KEY ("id"))`); + await queryRunner.query(`CREATE TABLE "vault" ( + "id" SERIAL NOT NULL, + "ename" character varying(255) NOT NULL UNIQUE, + "uri" character varying(2048) NOT NULL, + "evault" character varying(1024) NOT NULL, + CONSTRAINT "PK_dd0898234c77f9d97585171ac59" PRIMARY KEY ("id") + )`); + await queryRunner.query(`CREATE INDEX "IDX_vault_ename" ON "vault" ("ename")`);This adds:
- Column length limits to prevent excessively large data
- Unique constraint on
ename(assuming vault names should be unique)- Index on
enamefor faster lookupsplatforms/registry/src/config/database.ts (2)
4-4: Use Node.js import protocol for built-in modules.The static analysis correctly suggests using the
node:protocol for Node.js built-in modules.-import { join } from "path" +import { join } from "node:path"🧰 Tools
🪛 Biome (1.9.4)
[error] 4-4: A Node.js builtin module should be imported with the node: protocol.
Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.(lint/style/useNodejsImportProtocol)
11-13: Consider adding SSL configuration for production environments.The database configuration lacks SSL settings which are typically required for production PostgreSQL connections.
url: process.env.REGISTRY_DATABASE_URL || "postgresql://postgres:postgres@localhost:5432/registry", + ssl: process.env.NODE_ENV === "production" ? { rejectUnauthorized: false } : false, synchronize: process.env.NODE_ENV !== "production",Note: Adjust SSL settings based on your specific PostgreSQL configuration requirements.
platforms/registry/src/migrations/README.md (1)
44-44: Fix grammar in the best practices section.The static analysis correctly identifies an adverb placement issue.
-5. Always backup your database before running migrations in production +5. Always back up your database before running migrations in productionOr alternatively:
-5. Always backup your database before running migrations in production +5. Back up your database before running migrations in productionplatforms/registry/src/services/VaultService.ts (4)
1-2: Use import type for TypeORM interfaces.The static analysis correctly identifies that these imports are only used as types.
-import { Repository } from "typeorm" -import { Vault} from "../entities/Vault" +import type { Repository } from "typeorm" +import type { Vault } from "../entities/Vault"🧰 Tools
🪛 Biome (1.9.4)
[error] 1-1: All these imports are only used as types.
Importing the types with import type ensures that they are removed by the compilers and avoids loading unnecessary modules.
Safe fix: Use import type.(lint/style/useImportType)
[error] 2-2: All these imports are only used as types.
Importing the types with import type ensures that they are removed by the compilers and avoids loading unnecessary modules.
Safe fix: Use import type.(lint/style/useImportType)
24-27: Optimize the update method to reduce database calls.The current update implementation makes two database calls, which is inefficient and can lead to race conditions.
async update(id: number, data: Partial<Vault>): Promise<Vault| null> { - await this.serviceRepository.update(id, data) - return await this.findOne(id) + const result = await this.serviceRepository.update(id, data) + if (result.affected === 0) { + return null + } + return await this.findOne(id) }Or use a more efficient approach with
preloadandsave:async update(id: number, data: Partial<Vault>): Promise<Vault| null> { - await this.serviceRepository.update(id, data) - return await this.findOne(id) + const vault = await this.serviceRepository.preload({ id, ...data }) + if (!vault) { + return null + } + return await this.serviceRepository.save(vault) }
7-10: Consider adding input validation for vault creation.The service accepts string parameters without validation, which could lead to data quality issues.
async create(ename: string, uri: string, evault: string): Promise<Vault> { + if (!ename?.trim() || !uri?.trim() || !evault?.trim()) { + throw new Error('All fields (ename, uri, evault) are required and cannot be empty') + } const service = this.serviceRepository.create({ ename, uri, evault }) return await this.serviceRepository.save(service) }
29-31: Consider returning deletion success indicator.The delete method doesn't indicate whether the deletion was successful or if the entity existed.
- async delete(id: number): Promise<void> { - await this.serviceRepository.delete(id) + async delete(id: number): Promise<boolean> { + const result = await this.serviceRepository.delete(id) + return result.affected !== undefined && result.affected > 0 }infrastructure/evault-provisioner/src/index.ts (1)
7-8: Use thenode:protocol for Node.js builtin modules.For better clarity and to follow Node.js best practices, prefix builtin modules with
node:.Apply this diff:
-import path from "path"; -import { fileURLToPath } from "url"; +import path from "node:path"; +import { fileURLToPath } from "node:url";🧰 Tools
🪛 Biome (1.9.4)
[error] 7-7: A Node.js builtin module should be imported with the node: protocol.
Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.(lint/style/useNodejsImportProtocol)
[error] 8-8: A Node.js builtin module should be imported with the node: protocol.
Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.(lint/style/useNodejsImportProtocol)
infrastructure/evault-provisioner/src/templates/evault.nomad.ts (1)
1-5: Improve import statements and remove unused imports.
- Use the
node:protocol for Node.js builtin modules as recommended by static analysis- The
jsonimport from Express appears unused in this file-import { execSync } from "child_process"; -import { json } from "express"; +import { execSync } from "node:child_process";🧰 Tools
🪛 Biome (1.9.4)
[error] 3-3: A Node.js builtin module should be imported with the node: protocol.
Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.(lint/style/useNodejsImportProtocol)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (15)
infrastructure/evault-core/src/w3id/w3id.ts(1 hunks)infrastructure/evault-provisioner/src/index.ts(4 hunks)infrastructure/evault-provisioner/src/listeners/alloc.ts(0 hunks)infrastructure/evault-provisioner/src/templates/evault.nomad.ts(2 hunks)infrastructure/web3-adapter/src/__tests__/evault.test.ts(1 hunks)infrastructure/web3-adapter/src/adapter.ts(3 hunks)platforms/registry/package.json(1 hunks)platforms/registry/src/config/database.ts(1 hunks)platforms/registry/src/consul.ts(0 hunks)platforms/registry/src/entities/Vault.ts(1 hunks)platforms/registry/src/index.ts(3 hunks)platforms/registry/src/migrations/1748865359304-migration.ts(1 hunks)platforms/registry/src/migrations/README.md(1 hunks)platforms/registry/src/services/VaultService.ts(1 hunks)platforms/registry/tsconfig.json(1 hunks)
💤 Files with no reviewable changes (2)
- platforms/registry/src/consul.ts
- infrastructure/evault-provisioner/src/listeners/alloc.ts
✅ Files skipped from review due to trivial changes (4)
- platforms/registry/tsconfig.json
- infrastructure/web3-adapter/src/tests/evault.test.ts
- platforms/registry/src/entities/Vault.ts
- infrastructure/web3-adapter/src/adapter.ts
🧰 Additional context used
🧬 Code Graph Analysis (2)
infrastructure/evault-provisioner/src/index.ts (1)
infrastructure/evault-provisioner/src/templates/evault.nomad.ts (1)
provisionEVault(22-162)
infrastructure/evault-core/src/w3id/w3id.ts (5)
infrastructure/evault-core/src/secrets/secrets-store.ts (1)
SecretsStore(25-126)infrastructure/w3id/src/w3id.ts (2)
W3ID(9-30)W3IDBuilder(32-158)infrastructure/evault-core/src/w3id/log-service.ts (1)
LogService(8-42)infrastructure/evault-core/src/utils/signer.ts (1)
createSigner(32-44)infrastructure/evault-core/src/utils/codec.ts (1)
uint8ArrayToHex(1-5)
🪛 Biome (1.9.4)
platforms/registry/src/services/VaultService.ts
[error] 1-1: All these imports are only used as types.
Importing the types with import type ensures that they are removed by the compilers and avoids loading unnecessary modules.
Safe fix: Use import type.
(lint/style/useImportType)
[error] 2-2: All these imports are only used as types.
Importing the types with import type ensures that they are removed by the compilers and avoids loading unnecessary modules.
Safe fix: Use import type.
(lint/style/useImportType)
platforms/registry/src/index.ts
[error] 27-27: Unexpected any. Specify a different type.
any disables many type checking rules. Its use should be avoided.
(lint/suspicious/noExplicitAny)
[error] 27-27: Unexpected any. Specify a different type.
any disables many type checking rules. Its use should be avoided.
(lint/suspicious/noExplicitAny)
infrastructure/evault-provisioner/src/index.ts
[error] 7-7: A Node.js builtin module should be imported with the node: protocol.
Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.
(lint/style/useNodejsImportProtocol)
[error] 8-8: A Node.js builtin module should be imported with the node: protocol.
Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.
(lint/style/useNodejsImportProtocol)
infrastructure/evault-provisioner/src/templates/evault.nomad.ts
[error] 3-3: A Node.js builtin module should be imported with the node: protocol.
Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.
(lint/style/useNodejsImportProtocol)
[error] 24-24: Reassigning a function parameter is confusing.
The parameter is declared here:
Use a local variable instead.
(lint/style/noParameterAssign)
infrastructure/evault-core/src/w3id/w3id.ts
[error] 32-32: Forbidden non-null assertion.
(lint/style/noNonNullAssertion)
platforms/registry/src/config/database.ts
[error] 4-4: A Node.js builtin module should be imported with the node: protocol.
Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.
(lint/style/useNodejsImportProtocol)
platforms/registry/src/migrations/1748865359304-migration.ts
[error] 1-1: All these imports are only used as types.
Importing the types with import type ensures that they are removed by the compilers and avoids loading unnecessary modules.
Safe fix: Use import type.
(lint/style/useImportType)
🪛 LanguageTool
platforms/registry/src/migrations/README.md
[style] ~43-~43: The adverb ‘Always’ is usually put between ‘have’ and ‘been’.
Context: .... Never modify existing migrations that have been committed 5. Always backup your database before running mig...
(ADVERB_WORD_ORDER)
🔇 Additional comments (8)
platforms/registry/src/migrations/README.md (1)
1-44: Excellent documentation for migration management.This README provides comprehensive guidance for database migrations including commands, conventions, and best practices. The structure is clear and will help developers manage schema changes effectively.
🧰 Tools
🪛 LanguageTool
[style] ~43-~43: The adverb ‘Always’ is usually put between ‘have’ and ‘been’.
Context: .... Never modify existing migrations that have been committed 5. Always backup your database before running mig...(ADVERB_WORD_ORDER)
infrastructure/evault-provisioner/src/index.ts (3)
15-15: Port change looks good.The port change from 3000 to 3001 helps avoid potential conflicts with other services.
76-84: Registry integration looks secure and well-implemented.Good implementation with:
- Proper authentication using shared secret
- Clear payload structure
- Integration with the new database-backed registry service
86-89: Response structure improvement.Returning the URI directly is more useful for clients than the previous Nomad job name.
platforms/registry/package.json (1)
1-36: Database migration dependencies and scripts look good.The additions properly support the migration from Consul to a PostgreSQL database:
- TypeORM with PostgreSQL driver for ORM functionality
- Migration scripts follow TypeORM conventions
- Appropriate type definitions included
platforms/registry/src/index.ts (3)
13-25: Database initialization is well-implemented.Good practices:
- Proper async/await usage
- Clear error logging
- Fails fast on initialization errors
40-58: Well-structured vault registration endpoint.Good implementation with:
- Authentication via preHandler middleware
- Input validation for required fields
- Proper error handling and status codes
82-104: Database-backed service resolution looks good.Successfully migrated from Consul to database with:
- Clean service lookup via VaultService
- Proper 404 handling for missing services
- Consistent response structure
* chore: change from nomad to k8s * Update infrastructure/eid-wallet/src/routes/+layout.svelte Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: uri extraction * feat: regitry stuff * feat: registry using local db * 📝 Add docstrings to `feat/switch-to-k8s` (#181) Docstrings generation was requested by @coodos. * #179 (comment) The following files were modified: * `infrastructure/evault-provisioner/src/templates/evault.nomad.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: format --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* initial commit * chore: add w3id readme (#3) * chore: add w3id readme * chore: bold text * chore: better formatting * docs: add w3id details * chore: format * chore: add links * fix: id spec considerations addressal (#8) * fix: id spec considerations addressal * fix: identity -> indentifier * chore: expand on trust list based recovery * chore: expand on AKA --------- Co-authored-by: Merul Dhiman <[email protected]> * Docs/eid wallet (#10) * chore: add eid-wallet folder * chore: add eid wallet docs * feat: add (#9) * feat(w3id): basic setup (#11) * feat(w3id): basic setup * fix(root): add infrastructure workspaces * update: lock file * feat(eidw): setup tauri (#40) * Feat/setup daisyui (#46) * feat: setup-daisyui * fix: index file * feat: colors added * feat: Archivo font added * fix: postcss added * fix: +layout.svelte file added * fix: packages * fix: fully migrating to tailwind v4 * feat: add Archivo font * feat: add danger colors * feat: twmerge and clsx added * feat: shadcn function added --------- Co-authored-by: Bekiboo <[email protected]> Co-authored-by: Julien <[email protected]> * feat: add storybook (#45) * feat: add storybook * update: lockfile * feat: created connection button (#48) * created connection button * added restprops to parent class * added onClick btn and storybook * fix: make font work in storybook (#54) * Feat/header (#55) * feat: add icons lib * fix: make font work in storybook * feat: Header * feat: runtime global added, icon library created, icons added, type file added * feat: header props added * fix: remove icons and type file as we are using lib for icons * fix: heading style * fix: color and icons, git merge branch 51, 54 * fix: color * fix: header-styling * fix: classes * chore: handlers added * chore: handlers added * fix: added heading --------- Co-authored-by: Soham Jaiswal <[email protected]> * Alternative w3id diagram (#52) * Feat/cupertino pane (#49) * feat: Drawer * feat: Drawer and added a function for clickoutside in utils * fix: classes * fix: drawer button position * fix: style and clickoutside * fix: pane height * fix: border-radius * fix: drawer as bulletin * fix: styling * fix: component with inbuilt features * fix: remove redundant code * fix: remove redundant code * fix: cancel button * fix: css in storybook * fix: position * fix: height of pane * fix: remove redundant code * feat: add button action component (#47) * feat: add button action component * fix: add correct weights to Archivo fontt * feat: add base button * fix: set prop classes last * feat: improve loading state * chore: cleanup * feat: add button action component * fix: add correct weights to Archivo fontt * feat: add base button * fix: set prop classes last * feat: improve loading state * chore: cleanup * chore: add documentation * fix: configure Storybook * chore: storybook gunk removal * feat: enhance ButtonAction component with type prop and better error handling --------- Co-authored-by: JulienAuvo <[email protected]> * Feat/splash screen (#63) * feat: SplashScreen * fix: remove redundant code * fix: as per given suggestion * fix: font-size * fix: logo * feat: input-pin (#56) * feat: input-pin * fix: styling as per our design * fix: added small variant * fix: hide pin on select * fix: gap between pins * fix: color of focus state * fix: removed legacy code and also fix some css to tailwind css * fix: css * fix: optional props * feat: added color variants * Feat/improve button component (#60) * feat: add white variant * feat: add small variant * chore: update doc and story for button * chore: rename cb into callback * update: improve small size * update: modify loading style * fix: return getAbsolutePath function to storybook (#58) Co-authored-by: Bekiboo <[email protected]> * feat: add selector component (#59) * feat: add selector component * feat: improve selector + add flag-icon lib * feat: improve selector + doc * feat: add utility function to get language with country name * feat: test page for language selectors * chore: add Selector Story * chore: clean test page * fix: types * fix: normalize custom tailwind colors (#71) * feat: workflows (#64) * feat: workflows * fix: node version * fix: use pnpm 10 * fix: check message * Fix/codebase linting (#73) * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Code / lint * fix: Check Format / lint * fix: unknown property warning * fix: unknown property warning * chore: improve args type * settings nav button :) (#75) * setting bav button all done :) * lint fixski * added component to index.ts * Feat/#32 identity card fragment (#74) * identity card * identity card * lint fixski * lint fixski * lint fixski * fixed the font weight * added component to index.ts * changed span to buttton * feat: add icon button component (#68) * feat: add icon button component * feat: finish up buttonIcon + stories * fix: update with new color naming * feat: polish button icon (and button action too) * chore: format lint * chore: sort imports * chore: format, not sure why * Feat/onboarding flow (#67) * feat: onboarding-page * fix: line height and added handlers * fix: button variant * fix: text-decoration * fix: subtext * fix: underline * fix: padding and button spacing * fix: according to design update * feat: Drawer * feat: verify-pae * fix: verify-page styling * feat: drawer for both confirm pin and add bio metrics added * feat: modal added in fragments * fix: icons and flow * feat: Identifier Card * fix: copy to clipboard * feat: e-passport page * fix: error state * fix: colors * fix: lint error * fix: lint * feat: Typography * fix: typograpy * fix: as per given suggestion * fix: font-sizing * fix: identity card implementation * fix: spacing * fix: padding * fix: padding and spacing * fix: splashscreen * fix: error state * fix: styling to avoid * fix:typo * Fix/remove daisyui (#82) * refactoring: remove DaisyUI + refactor some tailwind classes and logic * refactoring: remove DaisyUI + refactor some tailwind classes and logic * feat: add Button.Nav (#77) * feat: add Button.Nav * chore: format * chore: sort imports * update: remove unused snippet and add missing props * feat: stick to fragment definition * update: documentation * fix: stories * chore: sort imports * Feat/splashscreen animation (#81) * feat: add animation to splashScreen * feat: implement data loading logic with splash screen delay * chore: sort import * update: use ButtonIcon is IdentityCard (#78) * update: use ButtonIcon is IdentityCard * feat: refactor ButtonIcon to be used anywhere in the app * chore: format indent * chore: remove useless change * feat: setup safe area (#80) * feat: setup safe area * chore: simplify implementation * chore: format * Feat/uuidv5 generation (#61) * feat: setup uuidv5 * chore: add test for deterministic UUID * feat: add Hero fragment (#88) * feat: add Hero fragment * chore: sort imports + add doc * feat: add storage specification abstract class (#92) * feat: add storage specification abstract class * chore: format and ignore lint * chore: change format checker on w3id * feat: settings-flow (#86) * feat: settings-flow * feat: settings and language page * feat : history page * feat: change pin page * fix: height of selector * fix: pin change page * fix: size of input pin * fix: spacing of pins * feat: AppNav fragment * fix: height of page * fix: padding * fix: remove redundant code * feat: privacy page * chore: add doc * fix: error state * feat: remove redundant code * chore: used app nav component --------- Co-authored-by: JulienAuvo <[email protected]> * feat: AppNav fragment (#90) * feat: AppNav fragment * chore: add doc * feat: Main page flow (#93) * feat: create root page + layout * feat: complete main page flow beta * chore: fix ts block * chore: sort imports * feat: integrate-flows (#94) * feat: intigrate-flows * fix: spacing in e-passport page * fix: page connectivity * feat: app page transitions * fix: z index * fix: pages * fix: view transition effect on splashscreen * fix: drawer pill and cancel button removed * fix: share button removed when onboarding * fix: remove share and view button when on onboarding flow * fix: remove view button * fix: ci checks * fix: transitions * fix: transititon according to direction * fix: lint error * fix: loop holes * Feat/w3id log generation (#98) * chore: create basic log generation mechanism * chore: add hashing utility function * chore: rotation event * feat: genesis entry * feat: generalize hash function * feat: append entry * chore: basic tests * chore: add tests for rotation * feat: add malform throws * chore: add the right errors * chore: fix CI stuff * chore: add missing file * chore: fix event type enum * chore: format * feat: add proper error * chore: format * chore: remove eventtypes enum * chore: add new error for bad options * chore: add options tests * feat: add codec tests * fix: err handling && jsdoc * fix: run format * fix: remove unused import * fix: improve default error messages * fix: move redundant logic to function * fix: run format * fix: type shadow * fix: useless conversion/cast * fix: run format --------- Co-authored-by: Soham Jaiswal <[email protected]> * Feat/core id creation logic (#99) * feat: create w3id builder * fix: w3id builder * feat: add global config var for w3id * chore: add docs * chore: change rand to crng * chore: add ts type again * chore: fix lint and format * chore: add w3id tests github workflow * Feat/evault core (#100) * feat: migrate neo4j * chore: envelope logic works * chore: envelope logic works * feat: parsed envelopes search * feat: generics * feat: protocol * feat: jwt sigs in w3id * chore: stuff works * chore: tests for evault core * chore: format * chore: fix test * Feat/docker compose and docs (#101) * chore: stash dockerfile progress * fix: getEnvelopesByOntology thing * chore: fix tests * Update infrastructure/evault-core/src/protocol/vault-access-guard.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: remove unused import * chore: remove package * chore: fix pnpm lock * chore: fix workflow * chore: fix port in dockerfile --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Feat/registry and evault provisioning (#106) * feat: evault provisioning * chore: fianlly fixed provisioner * feat: add logic for metadata in consul * feat: registry * chore: format * Feat/watchers logs (#114) * feat: alloc according to entropy and namespace * chore: move exports * chore: docs * feat: `whois` endpoint * feat: watcher endpoints * chore: fix format and lint * chore: fix tests * feat: web3 adapter (#115) * feat: tauri plugins setup (#97) * feat: tauri plugins setup * fix: add editorconfig * fix: add missing biome json * fix: run formatter * feat: biometry homework * feat: add pin set logic * feat: add biometric enabling logic * fix: sec controller qol * feat: stub user controller * fix: run format && lint * fix: sort imports * fix: import statement sort * feat: user controller * feat: pin flow * feat: biometrics unavailable * fix: pin input not working * feat: make checks pass * fix: scan works * fix: actions * feat: format on save * fix: coderabbit suggestions * chore: run format lint check * fix: scan on decline too * feat: documentation links (#117) * feat: bad namespace test (#116) * fix: layouts (#119) * fix: layouts * fix: Onboarding page scroll fixed * fix: page layout and prevent from scroll in all devices * fix: pages layout * chore: try to fix emulator * fix: units * fix: safezones for ios * fix: styling --------- Co-authored-by: Soham Jaiswal <[email protected]> * feat: setup-metagram (#121) * feat: setup-metagram * chore: tailwind css worked * feat: fonts added * feat: typography * fix: removed stories and fixed setup for icons lib * feat: icons and story file * fix: type of args in story * fix: lint errors * feat: colors added * feat: Button * fix: format and lint * fix: colors * fix: spinner * fix: code rebbit suggestions * fix: code rebbit suggestions * fix: paraglide removed * fix: lock file * feat: added user avatar. (#130) * feat: Button (#129) * feat: Button * fix: colors of variants * feat: Input (#131) * feat: Input * feat: styling added * fix: styling * fix: styling * fix: added a new story * fix: focus states * fix: input states * Feat/settings navigation button (#140) * feat: settings-navigation-button * fix: handler added * chore: another variant added * fix: as per given suggestion * feat: BottomNav (#132) * feat: BottomNav * fix: icons * feat: profile icons created * feat: handler added * feat: handler added * fix: correct tags * fix: as per given suggestion, bottomnav moved to fragments and also implemented on page * fix: handler * chore: routes added * feat: app transitions added * fix: direction of transition * fix: transition css * fix: directionable transition * fix: used button instead of label, and used page from state * feat: added post fragment. (#137) * feat: FileInput (#150) * feat: FileInput * fix: added icon * feat: cancel upload * fix: remove redundant code * fix: usage docs added and as per requirements ' * fix: moved to framents * feat: Toggle Switch (#143) * feat: Toggle Switch * feat: Toggle Switch * fix: as per our design * fix: as per our design * feat: Label (#146) * feat: Select (#148) * feat: Select * fix: as per our design * fix: code format and as per svelte 5 * fix: font-size * fix: font-size * fix: icon * feat: message-input (#144) * feat: message-input * fix: classes merge and a files as a prop * feat: variant added * feat: icon replaced * fix: as per code rabbit suggestions * fix: icon * fix: input file button * fix: as per suggestion * fix: classes * fix: no need of error and disabled classes * fix: input * feat: invalid inputs * feat: add number input storybook --------- Co-authored-by: Soham Jaiswal <[email protected]> * feat:Drawer (#152) * feat:Drawer * feat: Drawer with clickoutside * fix: settings * Feat/metagram header (#133) * feat: added metagram header primary linear gradient. * feat: added flash icon. * feat: added secondary state of header. * feat: added secondary state of header with menu. * chore: cleaned some code. * docs: updated component docs. --------- Co-authored-by: SoSweetHam <[email protected]> * Feat/metagram message (#135) * feat: added metagram message component. * feat: added both states of message component. * docs: added usage docs. * chore: exposed component from ui. * fix: component -> fragement --------- Co-authored-by: SoSweetHam <[email protected]> * feat: modal (#154) * fix: styling of modal * fix: modal props * fix: conflicting styles * fix: styles of drawer * fix: hide scrollbar in drawer * fix: padding * fix: used native method for dismissing of drawer * feat: Context-Menu (#156) * feat: Context-Menu * fix: name of component * fix: as per suggestion * fix: action menu position * fix: class * feat: responsive-setup (#157) * feat: responsive-setup * fix: background color * fix: added font fmaily * feat: responsive setup for mobile and desktop (#159) * feat: responsive setup for mobile and desktop * fix: width of sidebar and rightaside * fix: responsive layout * feat: SideBar * fix: added some finishing touches to sidebar and button * fix: prevent pages transition on desktop * fix: icon center * feat: settings page and icon added * feat/layout-enhancement (#168) * feat/infinite-scroll (#170) * feat/infinite-scroll * fix: aspect ratio of post * fix: bottom nav background * settings page (#169) * settings page layout done * settings page layout done * formt fix * format fix * format fix * routing for settings page fixed * settings page buttons * merge conflict * settings page tertiary pages * settings pages all done * settings pages unnecessary page deleted * requested changes done * requested changes done * Feat/comments pane (#171) * feat/comments-pane * fix: overflow and drawer swipe * feat: Comment fragment * fix: comments added * fix: comment fragment * feat: Comments reply * fix: message input position * fix: post type shifted to types file * fix: one level deep only * fix: drawer should only be render on mobile * fix: comments on layout page * fix: format * feat: messages (#174) * feat: messages * feat: ChatMessae * feat: messages by id * fix: messages page * fix: icon name * fix: hide bottom nav for chat * fix: header * fix: message bubble * fix: message bubble * fix: message bubble * fix: as per suggestion * fix: messaging * chore: change from nomad to k8s (#179) * chore: change from nomad to k8s * Update infrastructure/eid-wallet/src/routes/+layout.svelte Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: uri extraction * feat: regitry stuff * feat: registry using local db * 📝 Add docstrings to `feat/switch-to-k8s` (#181) Docstrings generation was requested by @coodos. * #179 (comment) The following files were modified: * `infrastructure/evault-provisioner/src/templates/evault.nomad.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: format --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: make scan qr page work again (#185) * feat: Discover Page (#180) * refactor/Post (#186) * refactor/Post * fix: format and lint * fix: added dots for gallery * fix: added dots for gallery * fix: added dots for gallery * fix: plural name * feat: splash-screen (#187) * Feat/evault provisioning via phone (#188) * feat: eid wallet basic ui for verification * chore: evault provisioning * feat: working wallet with provisioning * feat: restrict people on dupes * 📝 Add docstrings to `feat/evault-provisioning-via-phone` (#189) Docstrings generation was requested by @coodos. * #188 (comment) The following files were modified: * `infrastructure/eid-wallet/src/lib/utils/capitalize.ts` * `infrastructure/evault-provisioner/src/utils/hmac.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: added uploaded post view component. (#182) * feat: added uploaded post view component. * fix: fixed the outline and color. * fix: moved function to external definition. * fix: fixed the restProps. * profile page (#178) * basic layout for profile page * fixed alt text * merge conflict * profile page for other users implemented * fix: profile pages and logics * fixed all the pages of profile * fixed all the pages of profile * fix: format --------- Co-authored-by: gourav <[email protected]> * Feat/radio input (#176) * feat: added a radio button custom * docs: added name option in docs. * chore: cleaned the unnecessary classes and variables for input type radio. * fix: moved input radio to its own component. * fix: keydown events added. * feat: added settings tile component. (#184) * feat: added settings tile component. * chore: fixed the naming convention * chore: renamed callback to onclick * fix: fixed the use of restProps * fix: fixed the unnecessary onclick expose. * fix: fixed the join function params. * Feat/textarea (#194) * chore: removed redundant radio * feat: added textarea. * fix: tabindex * fix: removed type inconsitency. * Feat/mobile upload flow (#193) * fix: header logic in secondary * fix: fixed the text in header in post * feat: trying some hack to get file image input. * feat: added image input on clicking the post bottom nav * chore: got rid of non-required code. * feat: added the logic to get the images from user on clicking post tab. * feat: added store. * feat: added correct conversion of files. * feat: added the correct display of image when uploading. * feat: added settings tile to the post page and fixed the settingsTile component type of currentStatus * feat: added hte correct header for the audience page. * fix: fixed the page transition not happening to audience page. * feat: added audience setting * feat: added store to audience. * chore: removed console log * feat: added post button. * feat: correct button placement * fix: horizontal scroll * fix: positioning of the post button. * fix: protecting post route when no image is selected. * fix: improved type saftey * feat: added memory helper function * feat: added memory cleanup. * Feat/social media platforms (#195) * chore: this part works now wooohooo * chore: stash progress * chore: stash progress * chore: init message data models * feat: different socials * chore: blabsy ready for redesign * Feat/social media platforms (#196) * chore: this part works now wooohooo * chore: stash progress * chore: stash progress * chore: init message data models * feat: different socials * chore: blabsy ready for redesign * chore: add other socials * Feat/blabsy add clone (#198) * chore: clone twitter * feat: custom auth with firebase using w3ds * chore: add chat * feat: chat works with sync * feat: twittex * feat: global schemas * feat: blabsy adapter * refactor: shift some text messages to work on blabsy (#199) * chore: stash progress * chore: stash adapters * chore: stash working extractor * feat: adapter working properly for translating to global with globalIDs * feat: adapter toGlobal pristine * chore: stash * feat: adapter working * chore: stash until global translation from pictique * feat: bi-directional sync prestino * feat: bidir adapters * chore: login redir * chore: swap out for sqlite3 * chore: swap out for sqlite3 * chore: server conf * feat: messages one way * feat: ready to deploy * feat: ready to deploy * chore: auth thing pictique * chore: set adapter to node * chore: fix auth token thingy * chore: auth thing * chore: fix auth token thingy * chore: port for blabsy * feat: provision stuff * feat: provision * feat: provision * feat: provision * chore: fix sync * feat: temporary id thing * chore: android * chore: fix mapper sync * chore: fallback * feat: add error handling on stores * feat: fix issue with posts * chore: fix retry loop * Fix/author details (#229) * fix: author-details * fix: owner-details * fix: author avatar * fix: auth user avatar * fix: error handling * fix: author image in bottom nav --------- Co-authored-by: Merul Dhiman <[email protected]> * Fix/change name (#228) * fix: corrected the name to blabsy * fix: extra shit comming. * fix: fixed the alignment of the display in more to look more like current twitter. * fix: avatars (#226) * fix: avatars * fix: avatar in follow request page * fix: images uploaded shown in user profile * fix: button size * fix: avatar --------- Co-authored-by: Merul Dhiman <[email protected]> * chore: temp fix sync * chore: stash progress * Fix/post context menu (#231) * fix: post-context-menu * fix: user id with post * fix: removed redundant code * fix: images * fix: profile data * fix: profile data * fix: image cover * fix: logout * Fix/wallet text (#234) * changed text as per the request and fixed styling on pages with useless scroll * added settings button in main page which went missing somehow * fix: consistent padding * chore: change tags * feat: change icon * feat: webhook dynamic registry * feat: make camera permission work properlyh * chore: removed all locking mechanism thing from platforms * feat: synchronization works perfectly * feat: fixed everything up * feat: changes * chore: stats fix * chore: fix pictique visual issues * chore: fix cosmetic name issue * feat: fix sync issue * chore: fix logical issue here * chore: add qrcode ename * feat: add packages (#235) * feat: add packages * feat: add sample funcs + docs * fixed the filled color on like icon for liked post (#239) * feat: fake passport name * feat: double confirmation * chore: fix pictique login issue * fix: make no user case redir to login * fix: issues with wallet --------- Co-authored-by: Soham Jaiswal <[email protected]> Co-authored-by: SoSweetHam <[email protected]> Co-authored-by: Gourav Saini <[email protected]> Co-authored-by: Bekiboo <[email protected]> Co-authored-by: Julien <[email protected]> Co-authored-by: Ananya Rana <[email protected]> Co-authored-by: Sergey <[email protected]> Co-authored-by: Julien Connault <[email protected]> Co-authored-by: Ananya Rana <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Sahil Garg <[email protected]> Co-authored-by: Sahil Garg <[email protected]>
Description of change
Switch from consul & nomad to Kubernetes.
Reason: Nomad was being annoying with CNI unless you use their shitty hosted version which was annoying to deal with anyways.
Issue Number
Type of change
How the change has been tested
By provisioning evaults
Change checklist
Summary by CodeRabbit
New Features
Refactor
Chores
Style