Skip to content

fix crash and broken jump mode in criticals module#6380

Open
xvrrv wants to merge 1 commit intoMeteorDevelopment:masterfrom
xvrrv:criticals
Open

fix crash and broken jump mode in criticals module#6380
xvrrv wants to merge 1 commit intoMeteorDevelopment:masterfrom
xvrrv:criticals

Conversation

@xvrrv
Copy link
Copy Markdown
Contributor

@xvrrv xvrrv commented May 3, 2026

Type of change

  • Bug fix
  • New feature

Description

fixes a ClassCastException crash when using minijump or jump mode in criticals

the issue: ServerboundInteractPacket was declared here

private ServerboundInteractPacket attackPacket;

but incoming packet was ServerboundAttackPacket

so when casting here detects wrong class and crash

attackPacket = (ServerboundInteractPacket) event.packet;

the fix is just change class to ServerboundAttackPacket and cast it

private ServerboundAttackPacket attackPacket;
attackPacket = (ServerboundAttackPacket) event.packet;

and jump mode wasnt actually jumping because wrong method was used here

mc.player.isJumping();

actual method is

mc.player.jumpFromGround();

Related issues

#6379

How Has This Been Tested?

singleplayer and multiplayer, every mode works fine

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas. (no needed)
  • I have tested the code in both development and production environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant