Skip to content

Insecure Password Hashing Configuration & API Key Management Security#146

Merged
LaGodxy merged 3 commits into
MettaChain:mainfrom
ahmadogo:builder
Mar 24, 2026
Merged

Insecure Password Hashing Configuration & API Key Management Security#146
LaGodxy merged 3 commits into
MettaChain:mainfrom
ahmadogo:builder

Conversation

@ahmadogo

@ahmadogo ahmadogo commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixed TypeScript error for missing passwordHistory property by regenerating Prisma client after schema changes
  • Added comprehensive unit tests for PasswordRotationService to meet CI coverage thresholds

Changes

  • Ran npx prisma generate to sync Prisma client types with schema
  • Created test/common/password-rotation.service.spec.ts with 29 tests covering all service methods
  • Improved function coverage from 34.22% to 36.68% (above 35% threshold)

closes #93

closes #97

@drips-wave

drips-wave Bot commented Mar 24, 2026

Copy link
Copy Markdown

@ahmadogo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@ahmadogo ahmadogo changed the title Insecure Password Hashing Configuration Insecure Password Hashing Configuration & API Key Management Security Mar 24, 2026
@LaGodxy

LaGodxy commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

@ahmadogo resolve conflicts.

@LaGodxy LaGodxy merged commit f4c3aff into MettaChain:main Mar 24, 2026
1 check passed
@LaGodxy LaGodxy mentioned this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Key Management Security Insecure Password Hashing Configuration

2 participants