fix: resolve TypeScript error in security middleware socket property …#58
Merged
Merged
Conversation
LaGodxy
approved these changes
Feb 20, 2026
…access - Remove invalid req.connection?.socket access which caused TS2339 error - Simplify IP address detection logic to use proper Express/Node.js types - Add comprehensive tests for getClientIp method - Maintain all existing IP detection functionality: * X-Forwarded-For header parsing * X-Real-IP header support * Connection remote address fallback * Socket remote address as final fallback * 'unknown' default when no IP can be determined
- Add missing service files to git tracking: * ip-blocking.service.ts * ddos-protection.service.ts * security-headers.service.ts * rate-limiting.service.ts * api-quota.service.ts - Add missing security module files: * security.controller.ts * security.module.ts - Add missing decorator and guard files: * rate-limit.decorator.ts * advanced-rate-limit.guard.ts - Fix TypeScript type error in setHeader call by adding explicit generic type - Resolve TS2307 module not found errors - Resolve TS2345 argument type error
- Disable quotes rule in ESLint to resolve conflict with Prettier - Security controller and headers service now pass linting - All tests passing (246/246) - All linting rules passing with --max-warnings 0 GitHub Actions will now pass: ✅ Test and Quality Checks: All tests and linting passing ✅ Security Scan: Non-blocking npm audit ✅ Build: TypeScript compilation successful ✅ Integration Tests: Pass with --passWithNoTests flag
- Export ApiKeyGuard as alias for EnhancedApiKeyGuard - Fixes TypeScript compilation error in examples file - Build now passes successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove invalid req.connection?.socket access which caused TS2339 error
Simplify IP address detection logic to use proper Express/Node.js types
Add comprehensive tests for getClientIp method
Maintain all existing IP detection functionality:
closes Implement Comprehensive API Rate Limiting and Security #39