Implement env-driven signed URL strategy providers#855
Merged
nanaf6203-bit merged 1 commit intoJun 30, 2026
Merged
Conversation
This change introduces an env-driven strategy pattern for signed URL generation in the documents module. A factory now selects the active provider based on the SIGNED_URL_PROVIDER environment variable, with explicit S3, GCS, and Azure provider shells that can be wired to real implementations by integrators. The default path remains a not-configured provider that throws a clear error when no backend is selected, making the behavior explicit and extensible for future storage integrations. Closes the issue requesting signed URL generation to be implemented through a strategy pattern driven by environment variables, with S3/GCS/Azure placeholders and a default not-configured failure mode.
|
@Joyyyb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces an env-driven strategy pattern for signed URL generation in the documents module. A factory now selects the active provider based on the SIGNED_URL_PROVIDER environment variable, with explicit S3, GCS, and Azure provider shells that can be wired to real implementations by integrators. The default path remains a not-configured provider that throws a clear error when no backend is selected, making the behavior explicit and extensible for future storage integrations.
Closes the issue requesting signed URL generation to be implemented through a strategy pattern driven by environment variables, with S3/GCS/Azure placeholders and a default not-configured failure mode.
Closes #751