Skip to content

refactor: improve component architecture, loading states, and mobile accessibility#625

Merged
nanaf6203-bit merged 4 commits into
MettaChain:mainfrom
eyooTech:newIssue
Jun 30, 2026
Merged

refactor: improve component architecture, loading states, and mobile accessibility#625
nanaf6203-bit merged 4 commits into
MettaChain:mainfrom
eyooTech:newIssue

Conversation

@eyooTech

Copy link
Copy Markdown
Contributor

Summary

This PR introduces several frontend improvements focused on maintainability, user experience, and accessibility.

Changes

Property Card Refactor (#510)

  • Extracted property card data logic into a dedicated usePropertyCardData hook.
  • Consolidated store interactions and derived values into a normalized data layer.
  • Reduced component complexity and improved separation of concerns.
  • Added tests covering the extracted hook behavior.

Deep Import Enforcement (#512)

  • Added linting rules to discourage barrel imports across components.
  • Encouraged direct component imports to improve code-splitting and bundle efficiency.
  • Updated import guidelines and related documentation.

Analytics Loading Experience (#516)

  • Added row-level shimmer placeholders for analytics tab loading states.
  • Matched placeholder layout with existing chart skeletons to reduce cumulative layout shift (CLS).
  • Added tests covering loading-state rendering behavior.

Mobile Navigation Accessibility (#519)

  • Increased mobile navigation touch targets to meet WCAG 2.5.5 recommendations (minimum 44×44px interactive area).
  • Improved icon spacing and tap accuracy on smaller screens.
  • Added accessibility-focused test coverage and updated documentation.

Testing

  • Added/updated unit tests for extracted hooks and loading components.
  • Added accessibility coverage for mobile navigation interactions.
  • Verified existing functionality remains unchanged.

Documentation

  • Updated relevant comments and documentation to reflect the new architecture, loading states, and accessibility improvements.

Closes #510

Closes #512

Closes #516

Closes #519

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@eyooTech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Copy link
Copy Markdown
Contributor

Component-level improvements and mobile nav polish — work that users will feel. Clean. Merging.

@nanaf6203-bit nanaf6203-bit merged commit a5a05a9 into MettaChain:main Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants