Replace magic numbers with named constants - #121
Closed
Uchechukwu-Ekezie wants to merge 1 commit into
Closed
Conversation
Create centralized constants module (contracts/traits/src/constants.rs) with documented named constants for all magic numbers: Oracle: DEFAULT_MAX_PRICE_STALENESS (3600s), DEFAULT_MIN_SOURCES_REQUIRED (2), DEFAULT_OUTLIER_THRESHOLD (2), reputation scores (500/1000/200/10/50) Bridge: DEFAULT_GAS_MULTIPLIER (100), DEFAULT_CONFIRMATION_BLOCKS (6), BRIDGE_BASE_GAS (100000) IPFS: MAX_LOCATION_LENGTH (500), MAX_FILE_SIZE (100MB), etc. Token: TOKEN_SCALING_FACTOR (1e12) Analytics: BASIS_POINTS_DENOMINATOR (10000) Replace inline magic numbers in oracle and bridge constructors with constant references. Closes MettaChain#102
|
@Uchechukwu-Ekezie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create centralized constants module and replace hardcoded values.
Changes
contracts/traits/src/constants.rswith documented named constants for:How to test
cargo build --workspacecompiles cleanlyCloses #102