hal: zephyr: fix device / word address issues with i2c writes #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes use of word address as device address in i2c writes. Signed-off-by: Daniel Mangum <[email protected]>
Some callers pass a word address, but empty data buffer, when issuing i2c writes, such as when waking a device. Typically the HAL is passed a data buffer that includes the word address as the first byte, but when the data buffer is empty we opt to instead use the 1 byte word address as the data to be written. Signed-off-by: Daniel Mangum <[email protected]>
|
This PR has been marked as stale and will be automatically closed in 7 days. |
|
Hi @hasheddan , Is it possible for you to create a support ticket to discuss further? Our technical team shall get in touch with you further on this ticket. Please do let us know your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request
Fixes use of word address as device address in i2c writes.
Signed-off-by: Daniel Mangum [email protected]
Some callers pass a word address, but empty data buffer, when issuing
i2c writes, such as when waking a device. Typically the HAL is passed a
data buffer that includes the word address as the first byte, but when
the data buffer is empty we opt to instead use the 1 byte word address
as the data to be written.
Signed-off-by: Daniel Mangum [email protected]
Checklist