Skip to content

Update connect-php.md#274

Closed
mervynmanilall wants to merge 1 commit intoMicrosoftDocs:mainfrom
mervynmanilall:patch-1
Closed

Update connect-php.md#274
mervynmanilall wants to merge 1 commit intoMicrosoftDocs:mainfrom
mervynmanilall:patch-1

Conversation

@mervynmanilall
Copy link
Copy Markdown
Contributor

Many PHP developers use object-oriented programming for better structure and scalability. Including this approach helps make the documentation more inclusive and aligned with current PHP development practices.
This PR enhances the PHP connection guide for Azure Database for MySQL – Flexible Server by adding an object-oriented (OOP) approach using mysqli. It complements the existing procedural example and provides developers. Tabs have been added for each operation to allow easy navigation between these approaches.

Also, it removes extra 'f' on line 10 for insertion. This was causing an error when using this implementation.

- remove extra 'f' on line 10 for insert
- added tabs to easy navigate between procedural and object oriented approach for the different operations
@prmerger-automator
Copy link
Copy Markdown
Contributor

@mervynmanilall : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit ec4f4c2:

✅ Validation status: passed

File Status Preview URL Details
articles/mysql/flexible-server/connect-php.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@v-regandowner
Copy link
Copy Markdown
Contributor

@shreyaaithal - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged C+L Pull Request Review Team label label May 12, 2025
@mervynmanilall
Copy link
Copy Markdown
Contributor Author

Hello @shreyaaithal @markingmyname ,

Have you been able to check the proposed updates?

Regards

@mervynmanilall
Copy link
Copy Markdown
Contributor Author

Hi @v-regandowner , @shreyaaithal , @markingmyname

Just checking in to see if there’s any update on this PR. It’s been over a week, so I wanted to kindly ask if someone could take a look when time allows. Happy to make any changes if needed. Thanks so much in advance!

Regards

@mervynmanilall
Copy link
Copy Markdown
Contributor Author

Hi @v-regandowner , @shreyaaithal , @markingmyname

Just checking in to see if there’s any update on this PR.
Happy to make any changes if needed. Thanks so much in advance!

Regards

@v-dirichards
Copy link
Copy Markdown
Contributor

@shreyaaithal - Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

@mervynmanilall
Copy link
Copy Markdown
Contributor Author

Hi @v-regandowner , @v-dirichards , @shreyaaithal

Just checking in to see if there’s any update on this PR. It’s been over a week, so I wanted to kindly ask if someone could take a look when time allows. Happy to make any changes if needed. Thanks so much in advance!

Regards

@v-regandowner
Copy link
Copy Markdown
Contributor

@shreyaaithal @markingmyname @rwestMSFT - Could you review or reassign this pull request? Thanks!

@rwestMSFT
Copy link
Copy Markdown
Contributor

/cc @David-Engel

#assign:David-Engel

@mervynmanilall
Copy link
Copy Markdown
Contributor Author

Hello @David-Engel ,

Have you been able to review my changes?

@v-dirichards
Copy link
Copy Markdown
Contributor

@David-Engel Can you review this old PR and determine whether it needs to be closed or merged?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. If the changes no longer apply, add an explanation and a #please-close comment to close the PR.

@MicrosoftDocs/public-repo-pr-review-team

@David-Engel
Copy link
Copy Markdown

@David-Engel Can you review this old PR and determine whether it needs to be closed or merged?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. If the changes no longer apply, add an explanation and a #please-close comment to close the PR.

@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards
I don't own this content or the MySQL PHP driver. (I just own the unrelated SQL PHP driver.) I think @shreyaaithal should probably sign off on this.

@rwestMSFT - Were you looking for an extra set of eyes from a tangential area or did you assign this to me by mistake?

@mervynmanilall
Copy link
Copy Markdown
Contributor Author

Hello @rwestMSFT @shreyaaithal @markingmyname ,

Sorry to bother you again.
Any update please?

Regards

@rwestMSFT
Copy link
Copy Markdown
Contributor

@mervynmanilall We have nothing to share at this time. When we do, we will let you know. We can take weeks or months to respond to PRs. Thank you for your patience.

@rwestMSFT
Copy link
Copy Markdown
Contributor

Now that we have approval from the product group, I need to do an edit pass, which we'll do in an internal pull request.

This may take a few days to be published. In the meantime I am closing this PR.

#please-close

@rwestMSFT
Copy link
Copy Markdown
Contributor

@mervynmanilall Thanks again for contributing. When the updated article is published (in the next day or so), I encourage you to review the edit pass I made, to help you with future contributions. You did a good job, and we appreciate it when external contributors want to help us improve our content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants