Skip to content

Fix linkChecker: transform root-relative links, add PR trigger for live branch#25

Merged
Dickson-Mwendia merged 1 commit into
MicrosoftDocs:mainfrom
Dickson-Mwendia:fix-link-checker-issue
May 31, 2026
Merged

Fix linkChecker: transform root-relative links, add PR trigger for live branch#25
Dickson-Mwendia merged 1 commit into
MicrosoftDocs:mainfrom
Dickson-Mwendia:fix-link-checker-issue

Conversation

@Dickson-Mwendia
Copy link
Copy Markdown
Collaborator

@Dickson-Mwendia Dickson-Mwendia commented May 31, 2026

This pull request introduces several improvements to link validation in the CI workflow and updates documentation for managed identity support in MSAL for Go. The most significant changes are grouped below by theme.

CI Workflow Improvements:

  • The .github/workflows/linkchecker.yml workflow is updated to run on pull requests in addition to pushes, and now ignores the live branch for push events.
  • A new step is added to the workflow to resolve root-relative links in markdown files (e.g., /path) to absolute URLs (https://learn.microsoft.com/path) before running the link checker, ensuring that such links are properly validated.

Link Checker Configuration:

  • The .lycheeignore file is updated to ignore all URLs matching http://localhost.* and to add https://aka.ms/region-map to the ignore list, improving link checker accuracy and reducing false positives.

Documentation Update:

  • The msal-go/advanced/managed-identity.md documentation is updated to state that managed identity support is available starting with MSAL for Go version 1.3.1 (previously 1.3.0-preview).

@Dickson-Mwendia Dickson-Mwendia requested a review from jmprieur as a code owner May 31, 2026 10:29
@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit 145db12:

✅ Validation status: passed

File Status Preview URL Details
.github/workflows/linkchecker.yml ✅Succeeded
.lycheeignore ✅Succeeded

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@Dickson-Mwendia Dickson-Mwendia force-pushed the fix-link-checker-issue branch from 145db12 to a915c87 Compare May 31, 2026 10:31
@Dickson-Mwendia Dickson-Mwendia changed the title Fix linkChecker: exclude root-relative links, add PR trigger for live… Fix linkChecker: transform root-relative links, add PR trigger for live branch May 31, 2026
@learn-build-service-prod
Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit a915c87:

✅ Validation status: passed

File Status Preview URL Details
.github/workflows/linkchecker.yml ✅Succeeded

For more details, please refer to the build report.

@Dickson-Mwendia Dickson-Mwendia force-pushed the fix-link-checker-issue branch from a915c87 to 7b648d8 Compare May 31, 2026 10:43
@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit 7b648d8:

✅ Validation status: passed

File Status Preview URL Details
.github/workflows/linkchecker.yml ✅Succeeded
.lycheeignore ✅Succeeded
msal-go/advanced/managed-identity.md ✅Succeeded View

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@Dickson-Mwendia Dickson-Mwendia force-pushed the fix-link-checker-issue branch from 7b648d8 to 5833823 Compare May 31, 2026 10:46
@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit 5833823:

✅ Validation status: passed

File Status Preview URL Details
.github/workflows/linkchecker.yml ✅Succeeded
.lycheeignore ✅Succeeded
msal-go/advanced/managed-identity.md ✅Succeeded View

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

- Add sed step to convert root-relative markdown links to full
  learn.microsoft.com URLs before lychee runs (matches Java repo pattern)
- Remove --remap approach (lychee treats root-relative as filesystem paths)
- Add branches-ignore: [live] on push trigger
- Add pull_request trigger for all branches
- Fix broken v1.3.0-preview release link (tag never existed, use v1.3.1)
- Fix .lycheeignore: use regex pattern for localhost, add aka.ms/region-map

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Dickson-Mwendia Dickson-Mwendia force-pushed the fix-link-checker-issue branch from 5833823 to 219d184 Compare May 31, 2026 10:49
@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit 219d184:

✅ Validation status: passed

File Status Preview URL Details
.github/workflows/linkchecker.yml ✅Succeeded
.lycheeignore ✅Succeeded
msal-go/advanced/managed-identity.md ✅Succeeded View

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@Dickson-Mwendia Dickson-Mwendia merged commit 13dd6b0 into MicrosoftDocs:main May 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant