Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New-ADServiceAccount.md #3889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HerbertMauerer
Copy link
Contributor

PR Summary

remove LDS references
add forest uniqueness requirement
password only valid for sMSA
use of name for samAccountName

PR Checklist

  • Descriptive Title: Various updates: LDS, SamAccountName rules, passwords
  • Summary: There are a number of behavior changes and support learnings with GMSA. Making the changes we need in this cmdlet documentation.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

remove LDS references
add forest uniqueness requirement
password only valid for sMSA
use of name for samAccountName
Copy link
Contributor

Learn Build status updates of commit 32e13f1:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
docset/winserver2022-ps/activedirectory/New-ADServiceAccount.md ❌Error Details
docset/winserver2022-ps/activedirectory/Disable-ADAccount.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Enable-ADAccount.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Get-ADObject.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Get-ADServiceAccount.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Get-ADUser.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Install-ADServiceAccount.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Move-ADObject.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/New-ADObject.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/New-ADUser.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Remove-ADObject.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Remove-ADServiceAccount.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Remove-ADUser.yml ⚠️Warning Details
docset/winserver2022-ps/activedirectory/Search-ADAccount.yml ⚠️Warning Details

docset/winserver2022-ps/activedirectory/New-ADServiceAccount.md

  • Line 0, Column 0: [Error: MAML2Yaml_LoadFileFailed]
Failed to load file: C:/LocalRun/W/xufq-s/docset/winserver2022-ps/activedirectory/New-ADServiceAccount.md:149:(699) '

##Note:
'
 Unexpected header name Note:, please try to use PlatyPS validate the content

docset/winserver2022-ps/activedirectory/Disable-ADAccount.yml

  • Line 37, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Unlock-ADAccount.yml'.

docset/winserver2022-ps/activedirectory/Enable-ADAccount.yml

  • Line 37, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Unlock-ADAccount.yml'.

docset/winserver2022-ps/activedirectory/Get-ADObject.yml

  • Line 51, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Sync-ADObject.yml'.

docset/winserver2022-ps/activedirectory/Get-ADServiceAccount.yml

  • Line 22, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './New-ADServiceAccount.yml'.
  • Line 26, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Set-ADServiceAccount.yml'.
  • Line 28, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Uninstall-ADServiceAccount.yml'.

docset/winserver2022-ps/activedirectory/Get-ADUser.yml

  • Line 36, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Set-ADUser.yml'.

docset/winserver2022-ps/activedirectory/Install-ADServiceAccount.yml

  • Line 22, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './New-ADServiceAccount.yml'.
  • Line 28, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Set-ADServiceAccount.yml'.
  • Line 30, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Uninstall-ADServiceAccount.yml'.

docset/winserver2022-ps/activedirectory/Move-ADObject.yml

  • Line 37, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Sync-ADObject.yml'.

docset/winserver2022-ps/activedirectory/New-ADObject.yml

  • Line 39, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Sync-ADObject.yml'.

docset/winserver2022-ps/activedirectory/New-ADUser.yml

  • Line 25, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Set-ADUser.yml'.

docset/winserver2022-ps/activedirectory/Remove-ADObject.yml

  • Line 38, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Sync-ADObject.yml'.

docset/winserver2022-ps/activedirectory/Remove-ADServiceAccount.yml

  • Line 23, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './New-ADServiceAccount.yml'.
  • Line 25, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Set-ADServiceAccount.yml'.
  • Line 27, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Uninstall-ADServiceAccount.yml'.

docset/winserver2022-ps/activedirectory/Remove-ADUser.yml

  • Line 22, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Set-ADUser.yml'.

docset/winserver2022-ps/activedirectory/Search-ADAccount.yml

  • Line 29, Column 9: [Warning: file-not-found - See documentation] Invalid file link: './Unlock-ADAccount.yml'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the suggested changes

Comment on lines +696 to +698
## Notes:
- If the specified **SAMAccountName** string does not end with a $ (dollar sign), one is appended if necessary.
- The name needs to be unique in the forest as in some places the GMSA names are searched in the domain tree.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Notes:
- If the specified **SAMAccountName** string does not end with a $ (dollar sign), one is appended if necessary.
- The name needs to be unique in the forest as in some places the GMSA names are searched in the domain tree.
> [!NOTE]
> If the specified **SAMAccountName** string does not end with a dollar sign (`$`), one is appended if necessary. The name needs to be unique in the forest as in some places the GMSA names are searched in the domain tree.

Comment on lines +162 to +163
##Note:
This parameter is only valid with MSA accounts. For GMSA the password is managed automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##Note:
This parameter is only valid with MSA accounts. For GMSA the password is managed automatically.
> [!NOTE]
> This parameter is only valid with MSA accounts. For GMSA the password is managed automatically.

To specify a default naming context for an AD LDS environment, set the **msDS-defaultNamingContext** property of the Active Directory directory service agent object (**nTDSDSA**) for the AD LDS instance.
- If none of the previous cases apply, the **Path** parameter does not take any default value.
- If the cmdlet is run from an Active Directory PowerShell provider drive, the parameter is set to the current naming context of the provider drive.
- If the `-server` parameter is used, the naming context is the default naming context of the server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- If the `-server` parameter is used, the naming context is the default naming context of the server.
- If the **Server** parameter is used, the naming context is the default naming context of the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants