-
Notifications
You must be signed in to change notification settings - Fork 62
API review: Sensitivity label API #5364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add examples for configuring and retrieving the allowlist in C# and C++.
Co-authored-by: David Risney <[email protected]>
API review request for Sensitivity Label change event
specs/SensitivityLabel.md
Outdated
|
||
# Description | ||
|
||
This API introduces a SensitivityLabelChanged event to the CoreWebView2 object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to follow the link from the above explainer to https://learn.microsoft.com/en-us/information-protection/develop/concept-label-metadata but I am getting a 404.
Is there an doc that describes what these labels are for in some more detail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link needs update, here is the updated one -- https://learn.microsoft.com/en-us/deployedge/microsoft-edge-management-service-office-mip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up with owner of the page to get this updated.
specs/SensitivityLabel.md
Outdated
|
||
# Description | ||
|
||
This API introduces a SensitivityLabelChanged event to the CoreWebView2 object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix.
Updated definitions for sensitivity labels event as per review comments. Todo: update samples
Updated documentation to refer to detailed URL matching examples.
{ | ||
// ICoreWebView2Staging32 members | ||
// ICoreWebView2_32 members | ||
CoreWebView2SensitivityInfo SensitivityInfo { get; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were just going to have these two on the CoreWebView2:
IVectorView SensitivityLabels;
event Windows.Foundation.TypedEventHAndler<CoreWebView2, IInspectable> SensitivityLabelsChanged;
Why do we have CoreWebView2SensitivityInfo if it only has one property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has both SensitivityState and SensitivityLabels. Hence created a struct to encapsulate both.
We wanted the state of not applicable domains to be available to the host app, hence SensitivityState needs to be there.
This change includes the API definition for Sensitivity label change event and to configure allow list for the Web platform API that lets web page communicate the sensitivity label information to the web platform.