Skip to content

Conversation

@egmontkob
Copy link
Contributor

Proposed changes

Introduce new colors dselnormal and dselfocus for unfocused and focused
listbox's selected entry, forked off from the here misused dfocus and
dhotfocus, respectively.

Adjust skins not the underline listbox's selected entry.

Checklist

👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@egmontkob egmontkob requested a review from mc-worker November 25, 2025 13:19
@github-actions github-actions bot added this to the Future Releases milestone Nov 25, 2025
@github-actions github-actions bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Nov 25, 2025
@egmontkob
Copy link
Contributor Author

This change, if accepted, will slightly break the look of 3rd party skins, they'll need to be adjusted to introduce these two new colors. This won't be the first, nor the last such occasion, since we don't have proper fallback / compatibility mechanism in place.

I updated the skins using this quick-n-dirty one-off script:

#!/bin/bash

while IFS='' read line; do
  echo "$line"

  if [[ $line =~ " dfocus" ]]; then
    dfocline="$line"
  elif [[ $line =~ " dhotfocus" ]]; then
    dhotfocline="$line"
  fi

  if [[ $line =~ " dhotfocus" ]]; then
    echo "${dfocline/dfocus/dselnormal}"
    echo "${dhotfocline/dhotfocus/dselfocus}"
  fi
done <$1 >$1.tmp

mv "$1.tmp" "$1"

@egmontkob
Copy link
Contributor Author

I did not touch the documentation, nor the supported keywords for the --colors cmdline option. See #4908.

@egmontkob egmontkob modified the milestones: Future Releases, 4.8.34 Nov 25, 2025
…entry

Introduce new colors dselnormal and dselfocus for unfocused and focused
listbox's selected entry, forked off from the here misused dfocus and
dhotfocus, respectively.

Signed-off-by: Egmont Koblinger <[email protected]>
@egmontkob egmontkob merged commit e905e1f into MidnightCommander:master Nov 28, 2025
10 checks passed
@egmontkob egmontkob deleted the 3160-listbox-colors branch November 28, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Needs triage by maintainers prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

Dialog hotfocus color misused in listbox

2 participants