Fix default distanceLootModifier default values
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values appear to be intended to be used as a multiplier, so they take the form of 1.XX. However, the actual logic in `LootLevelsExpanded.cs` adds these values to `PerLevelLootScale` (in `DetermineLootScale`, for creatures that don't have `characterSpecificLoot` configured) or to `scale_factor` (in `MultiplyLootPerLevel` or `ExponentLootPerLevel`, for creatures that *do* have `characterSpecificLoot` configured) prior to multiplication with the creature's level. As a result, what is probably intended as a 2%/5%/8%/etc bonus actually winds up as a 102%/105%/108%/etc bonus (before any configured `amountScaleFactor` is taken into consideration) which seems erroneously high and probably unintended. This caused creatures to drop roughly double the expected loot with the default PerLevelLootScale value of 1 (e.g. a level 5 mob normally dropping 1 item would drop 10 rather than the expected 5).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values appear to be intended to be used as a multiplier, so they take the form of 1.XX.
However, the actual logic in
LootLevelsExpanded.csadds these values toPerLevelLootScale(inDetermineLootScale, for creatures that don't havecharacterSpecificLootconfigured) or toscale_factor(inMultiplyLootPerLevelorExponentLootPerLevel, for creatures that do havecharacterSpecificLootconfigured) prior to multiplication with the creature's level.As a result, what is probably intended as a 2%/5%/8%/etc bonus actually winds up as a 102%/105%/108%/etc bonus (before any configured
amountScaleFactoris taken into consideration) which seems erroneously high and probably unintended.This caused creatures to drop roughly double the expected loot with the default PerLevelLootScale value of 1 (e.g. a level 5 mob normally dropping 1 item would drop 10 rather than the expected 5).