Allow patching/unpatching of the loot system and the colorization system#4
Open
ulvrikironpaw wants to merge 1 commit intoMidnightsFX:masterfrom
Open
Allow patching/unpatching of the loot system and the colorization system#4ulvrikironpaw wants to merge 1 commit intoMidnightsFX:masterfrom
ulvrikironpaw wants to merge 1 commit intoMidnightsFX:masterfrom
Conversation
ulvrikironpaw
commented
Nov 14, 2025
- Moves to patch classes directly. I don't think Harmony will do this recursively for inner classes, so I think each class has to be patched. This allows for unpatching when the configuration option changes
- Moved into 4 top level harmony objects. I think this makes sense from an organization perspective?
- Added console commands for enabling/disabling loot and colorization. I tested these locally and they seem to disable/enable properly. Colorization stays after disabling for enemies spawned since that appears to be a mutate, rather than a behavior change
- Moved the data Init()'s inline
Owner
|
Planning on reviewing this in the next few weeks as I hopefully have some holiday hours available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.