Fix empty checkpoints for custom JAX mappings#1199
Open
MilesCranmerBot wants to merge 4 commits into
Open
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
+ Coverage 94.24% 94.34% +0.09%
==========================================
Files 21 21
Lines 1686 1714 +28
==========================================
+ Hits 1589 1617 +28
Misses 97 97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@MilesCranmerBot it feels like we are loading up this PySRRegressor with too much stuff In particular there are a bunch of new functions here which are not really "core" operations to the regressor. I believe there is a nice way to refactor this. Please do so. |
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Contributor
Author
|
Refactored in 2e59bfd: moved the checkpoint/pickle/export-column helper logic into Checks run:
|
MilesCranmer
reviewed
Jun 1, 2026
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1198
Tests
uv run --python /usr/bin/python3.12 --with pytest --with 'jax[cpu]>=0.4,<0.6' --with 'juliacall>=0.9.28,<0.9.29' --with 'sympy>=1,<2' --with 'pandas>=0.21,<4' --with 'numpy>=1.13,<3' --with 'scikit-learn>=1,<2' --with 'click>=7,<9' --with 'typing-extensions>=4,<5' python -m pytest pysr/test/test_jax.py -k "checkpoint or empty"\n-python3 -m compileall -q pysr/sr.py pysr/test/test_jax.py