Product testing#109
Open
chaitanya005 wants to merge 3 commits into
Open
Conversation
iMagesh
reviewed
Apr 20, 2022
Comment on lines
+59
to
+66
| fieldname: "file", | ||
| originalname: "rohtang-pass-4.jpg", | ||
| encoding: "7bit", | ||
| mimetype: "image/jpeg", | ||
| destination: "./images", | ||
| filename: "1650453223929--rohtang-pass-4.jpg", | ||
| path: "images/1650453223929--rohtang-pass-4.jpg", | ||
| size: 32163, |
Contributor
There was a problem hiding this comment.
see if you can use Faker to generate random images instead of hard-coding
iMagesh
reviewed
Apr 20, 2022
Comment on lines
+50
to
+53
| price: 1500, | ||
| size: "M", | ||
| color: "WHITE", | ||
| type: "SDKJF", |
Contributor
There was a problem hiding this comment.
use faker and don't hard-code these values
iMagesh
reviewed
Apr 20, 2022
| await editVariant(req, res); | ||
| expect(res.statusCode); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
A lot of test cases are missing..
check what will happen if I type different kind of date for every form field that I have.
What will happen if I give more data or wrong datatype
what if I write js inside the form field
There is a lot that we should test to make sure the form cannot be broken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.